Re: [ovs-dev] [PATCH v2 04/15] conntrack: New userspace connection tracker.

2016-05-13 Thread Flavio Leitner
On Wed, Apr 27, 2016 at 06:36:20AM +, Daniele Di Proietto wrote: > Thank you for your comments, Flavio! Thank you for the patchset :-) > > On 26/04/2016 16:35, "Flavio Leitner" wrote: > > >On Fri, Apr 15, 2016 at 05:02:36PM -0700, Daniele Di Proietto wrote: [...] > >>

Re: [ovs-dev] [PATCH v2 04/15] conntrack: New userspace connection tracker.

2016-04-27 Thread Fischetti, Antonio
ele, > >some comments inline prefixed with [Antonio F]. > > > >Regards, > >Antonio > > > >> -Original Message- > >> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of > Daniele Di > >> Proietto > >> Sent: Sa

Re: [ovs-dev] [PATCH v2 04/15] conntrack: New userspace connection tracker.

2016-04-27 Thread Daniele Di Proietto
Thank you for your comments, Flavio! On 26/04/2016 16:35, "Flavio Leitner" wrote: >On Fri, Apr 15, 2016 at 05:02:36PM -0700, Daniele Di Proietto wrote: >> This commit adds the conntrack module. >> >> It is a connection tracker that resides entirely in userspace. Its >>

Re: [ovs-dev] [PATCH v2 04/15] conntrack: New userspace connection tracker.

2016-04-27 Thread Daniele Di Proietto
ssage- >> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di >> Proietto >> Sent: Saturday, April 16, 2016 1:03 AM >> To: dev@openvswitch.org >> Subject: [ovs-dev] [PATCH v2 04/15] conntrack: New userspace connection >> tracker. >> >&g

Re: [ovs-dev] [PATCH v2 04/15] conntrack: New userspace connection tracker.

2016-04-27 Thread Daniele Di Proietto
Thanks for the detailed review Joe, replies inline On 19/04/2016 14:36, "Joe Stringer" wrote: >On 15 April 2016 at 17:02, Daniele Di Proietto wrote: >> This commit adds the conntrack module. >> >> It is a connection tracker that resides entirely in

Re: [ovs-dev] [PATCH v2 04/15] conntrack: New userspace connection tracker.

2016-04-26 Thread Flavio Leitner
On Fri, Apr 15, 2016 at 05:02:36PM -0700, Daniele Di Proietto wrote: > This commit adds the conntrack module. > > It is a connection tracker that resides entirely in userspace. Its > primary user will be the dpif-netdev datapath. > > The module main goal is to provide conntrack_execute(), which

Re: [ovs-dev] [PATCH v2 04/15] conntrack: New userspace connection tracker.

2016-04-25 Thread Fischetti, Antonio
Hi Daniele, some comments inline prefixed with [Antonio F]. Regards, Antonio > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di > Proietto > Sent: Saturday, April 16, 2016 1:03 AM > To: dev@openvswitch.org > Subject: [ovs-de

Re: [ovs-dev] [PATCH v2 04/15] conntrack: New userspace connection tracker.

2016-04-19 Thread Joe Stringer
On 15 April 2016 at 17:02, Daniele Di Proietto wrote: > This commit adds the conntrack module. > > It is a connection tracker that resides entirely in userspace. Its > primary user will be the dpif-netdev datapath. > > The module main goal is to provide

[ovs-dev] [PATCH v2 04/15] conntrack: New userspace connection tracker.

2016-04-15 Thread Daniele Di Proietto
This commit adds the conntrack module. It is a connection tracker that resides entirely in userspace. Its primary user will be the dpif-netdev datapath. The module main goal is to provide conntrack_execute(), which offers a convenient interface to implement the datapath ct() action. The