Re: [ovs-dev] [PATCH v2 14/15] ofproto: Refactor packet_out handling.

2016-08-30 Thread Ben Pfaff
On Tue, Aug 30, 2016 at 11:28:45AM -0700, Jarno Rajahalme wrote: > > On Aug 30, 2016, at 8:40 AM, Ben Pfaff wrote: > > I'm surprised to see ofproto.c including ofproto-dpif-xlate.h. That > > seems like a layer violation. > > I think this was due to the plate cache only. The learn

Re: [ovs-dev] [PATCH v2 14/15] ofproto: Refactor packet_out handling.

2016-08-30 Thread Jarno Rajahalme
> On Aug 30, 2016, at 8:40 AM, Ben Pfaff wrote: > > On Mon, Aug 22, 2016 at 04:31:40PM -0700, Jarno Rajahalme wrote: >> Refactor handle_packet_out() to prepare for bundle support for packet >> outs in a later patch. >> >> Two new callbacks are introduced in ofproto-provider

Re: [ovs-dev] [PATCH v2 14/15] ofproto: Refactor packet_out handling.

2016-08-30 Thread Ben Pfaff
On Mon, Aug 22, 2016 at 04:31:40PM -0700, Jarno Rajahalme wrote: > Refactor handle_packet_out() to prepare for bundle support for packet > outs in a later patch. > > Two new callbacks are introduced in ofproto-provider class: > ->packet_xlate() and ->packet_execute(). ->packet_xlate() translates

[ovs-dev] [PATCH v2 14/15] ofproto: Refactor packet_out handling.

2016-08-22 Thread Jarno Rajahalme
Refactor handle_packet_out() to prepare for bundle support for packet outs in a later patch. Two new callbacks are introduced in ofproto-provider class: ->packet_xlate() and ->packet_execute(). ->packet_xlate() translates the packet using the flow and actions provided by the caller, but defers