Re: [ovs-dev] [PATCH v2.40 4/7] ofp-actions: Add separate OpenFlow 1.3 action parser

2013-09-29 Thread Simon Horman
On Fri, Sep 27, 2013 at 12:41:19PM -0700, Ben Pfaff wrote: On Fri, Sep 27, 2013 at 09:18:33AM +0900, Simon Horman wrote: From: Joe Stringer j...@wand.net.nz This patch adds new ofpact_from_openflow13() and ofpacts_from_openflow13() functions parallel to the existing ofpact handling

Re: [ovs-dev] [PATCH v2.40 4/7] ofp-actions: Add separate OpenFlow 1.3 action parser

2013-09-29 Thread Ben Pfaff
On Mon, Sep 30, 2013 at 11:12:49AM +0900, Simon Horman wrote: I have written an incremental patch to implement your suggestion and it seems that a helper function is not necessary. For reference the incremental change that I currently have is as follows. It is a bit noisy but seems clean to

Re: [ovs-dev] [PATCH v2.40 4/7] ofp-actions: Add separate OpenFlow 1.3 action parser

2013-09-27 Thread Ben Pfaff
On Fri, Sep 27, 2013 at 09:18:33AM +0900, Simon Horman wrote: From: Joe Stringer j...@wand.net.nz This patch adds new ofpact_from_openflow13() and ofpacts_from_openflow13() functions parallel to the existing ofpact handling code. In the OpenFlow 1.3 version, push_mpls is handled