Re: [ovs-dev] [PATCH v6 06/12] dpif-netdev: Wait an RCU grace period before freeing ports.

2016-04-13 Thread Daniele Di Proietto
On 10/04/2016 12:23, "Ben Pfaff" wrote: >On Fri, Apr 08, 2016 at 03:12:59AM +, Daniele Di Proietto wrote: >> >> >> On 01/04/2016 09:52, "Jarno Rajahalme" wrote: >> >> > >> >> On Mar 30, 2016, at 8:08 PM, Daniele Di Proietto >> >>

Re: [ovs-dev] [PATCH v6 06/12] dpif-netdev: Wait an RCU grace period before freeing ports.

2016-04-10 Thread Ben Pfaff
On Fri, Apr 08, 2016 at 03:12:59AM +, Daniele Di Proietto wrote: > > > On 01/04/2016 09:52, "Jarno Rajahalme" wrote: > > > > >> On Mar 30, 2016, at 8:08 PM, Daniele Di Proietto > >> wrote: > >> > >> > >> On 30/03/2016 16:01, "Ben Pfaff"

Re: [ovs-dev] [PATCH v6 06/12] dpif-netdev: Wait an RCU grace period before freeing ports.

2016-04-07 Thread Daniele Di Proietto
On 01/04/2016 09:52, "Jarno Rajahalme" wrote: > >> On Mar 30, 2016, at 8:08 PM, Daniele Di Proietto >> wrote: >> >> >> On 30/03/2016 16:01, "Ben Pfaff" wrote: >> >>> (I'm taking a look at this patch specifically because Daniele asked me;

Re: [ovs-dev] [PATCH v6 06/12] dpif-netdev: Wait an RCU grace period before freeing ports.

2016-04-01 Thread Daniele Di Proietto
On 01/04/2016 09:52, "Jarno Rajahalme" wrote: > >> On Mar 30, 2016, at 8:08 PM, Daniele Di Proietto >> wrote: >> >> >> On 30/03/2016 16:01, "Ben Pfaff" wrote: >> >>> (I'm taking a look at this patch specifically because Daniele asked me;

Re: [ovs-dev] [PATCH v6 06/12] dpif-netdev: Wait an RCU grace period before freeing ports.

2016-04-01 Thread Jarno Rajahalme
> On Mar 30, 2016, at 8:08 PM, Daniele Di Proietto > wrote: > > > On 30/03/2016 16:01, "Ben Pfaff" wrote: > >> (I'm taking a look at this patch specifically because Daniele asked me; >> I'm not planning to review the whole series.) >> >> On Mon, Mar

Re: [ovs-dev] [PATCH v6 06/12] dpif-netdev: Wait an RCU grace period before freeing ports.

2016-03-30 Thread Daniele Di Proietto
On 30/03/2016 16:01, "Ben Pfaff" wrote: >(I'm taking a look at this patch specifically because Daniele asked me; >I'm not planning to review the whole series.) > >On Mon, Mar 28, 2016 at 12:41:40PM -0700, Daniele Di Proietto wrote: >> The dpif-netdev datapath keeps ports in a cmap

Re: [ovs-dev] [PATCH v6 06/12] dpif-netdev: Wait an RCU grace period before freeing ports.

2016-03-30 Thread Ben Pfaff
(I'm taking a look at this patch specifically because Daniele asked me; I'm not planning to review the whole series.) On Mon, Mar 28, 2016 at 12:41:40PM -0700, Daniele Di Proietto wrote: > The dpif-netdev datapath keeps ports in a cmap which is written only by > the main thread (holding

[ovs-dev] [PATCH v6 06/12] dpif-netdev: Wait an RCU grace period before freeing ports.

2016-03-28 Thread Daniele Di Proietto
The dpif-netdev datapath keeps ports in a cmap which is written only by the main thread (holding port_mutex), but which is read concurrently by many threads (most notably the pmd threads). When removing ports from the datapath we should postpone the deletion, otherwise another thread might access