Re: [ovs-dev] [PATCH v7 11/16] ovs-thread: Do not quiesce in ovs_mutex_cond_wait().

2016-04-15 Thread Daniele Di Proietto
Hi Mark, On 14/04/2016 05:36, "Kavanagh, Mark B" wrote: >Hi Daniele, > >One comment inline. > >Cheers, >Mark > >> >>ovs_mutex_cond_wait() is used in many functions in dpif-netdev to >>synchronize with pmd threads, but we can't guarantee that the callers do >>not hold

Re: [ovs-dev] [PATCH v7 11/16] ovs-thread: Do not quiesce in ovs_mutex_cond_wait().

2016-04-14 Thread Kavanagh, Mark B
Hi Daniele, One comment inline. Cheers, Mark > >ovs_mutex_cond_wait() is used in many functions in dpif-netdev to >synchronize with pmd threads, but we can't guarantee that the callers do >not hold RCU references, so it's better to avoid quiescing. You'll need to update the following comment

[ovs-dev] [PATCH v7 11/16] ovs-thread: Do not quiesce in ovs_mutex_cond_wait().

2016-04-07 Thread Daniele Di Proietto
ovs_mutex_cond_wait() is used in many functions in dpif-netdev to synchronize with pmd threads, but we can't guarantee that the callers do not hold RCU references, so it's better to avoid quiescing. In system_stats_thread_func() the code relied on ovs_mutex_cond_wait() to introduce a quiescent