On Wed, Sep 17, 2014 at 9:11 PM, Pravin Shelar pshe...@nicira.com wrote:
On Wed, Sep 17, 2014 at 9:02 PM, Joe Stringer joestrin...@nicira.com wrote:
On 18 September 2014 13:02, Joe Stringer joestrin...@nicira.com wrote:
@@ -229,17 +244,19 @@ static bool match_validate(const struct
Thanks for the review, comments inline
On 17 September 2014 17:37, Pravin Shelar pshe...@nicira.com wrote:
On Wed, Sep 10, 2014 at 3:16 AM, Joe Stringer joestrin...@nicira.com
wrote:
Reduce duplicate code by using nla_policy and nla_parse_strict().
Thanks for simplifying this code. I have
On 18 September 2014 13:02, Joe Stringer joestrin...@nicira.com wrote:
@@ -229,17 +244,19 @@ static bool match_validate(const struct
sw_flow_match *match,
}
}
- if ((key_attrs key_expected) != key_expected) {
+ attrs = attrs_to_bitmask(key_attrs,
On Wed, Sep 17, 2014 at 9:02 PM, Joe Stringer joestrin...@nicira.com wrote:
On 18 September 2014 13:02, Joe Stringer joestrin...@nicira.com wrote:
@@ -229,17 +244,19 @@ static bool match_validate(const struct
sw_flow_match *match,
}
}
- if ((key_attrs
On Wed, Sep 10, 2014 at 3:16 AM, Joe Stringer joestrin...@nicira.com wrote:
Reduce duplicate code by using nla_policy and nla_parse_strict().
Thanks for simplifying this code. I have couple of comments.
Signed-off-by: Joe Stringer joestrin...@nicira.com
---
v2: Remove attrs bitmasks from
Reduce duplicate code by using nla_policy and nla_parse_strict().
Signed-off-by: Joe Stringer joestrin...@nicira.com
---
v2: Remove attrs bitmasks from most functions.
Remove key/mask wrappers for parse_nlattrs().
Rebase against flag-based nla_parse_strict().
---
datapath/flow_netlink.c
