Re: [ovs-dev] [PATCH] Fix leak in patched_datapaths processing.

2016-09-01 Thread Flavio Fernandes
> On Sep 1, 2016, at 12:43 PM, Ben Pfaff wrote: > > On Thu, Sep 01, 2016 at 09:29:24AM -0500, Ryan Moats wrote: >> When unpersisting patch_datapaths, missed that the key field >> needed to be freed to avoid a memory leak. This patch fixes >> same. >> >> Signed-off-by: Ryan Moats > > I don't

Re: [ovs-dev] [PATCH] Fix leak in patched_datapaths processing.

2016-09-01 Thread Ben Pfaff
On Thu, Sep 01, 2016 at 09:29:24AM -0500, Ryan Moats wrote: > When unpersisting patch_datapaths, missed that the key field > needed to be freed to avoid a memory leak. This patch fixes > same. > > Signed-off-by: Ryan Moats I don't see a reason to be doing dynamic allocation here at all. My coun

Re: [ovs-dev] [PATCH] Fix leak in patched_datapaths processing.

2016-09-01 Thread Flavio Fernandes
> On Sep 1, 2016, at 10:29 AM, Ryan Moats wrote: > > When unpersisting patch_datapaths, missed that the key field > needed to be freed to avoid a memory leak. This patch fixes > same. > > Signed-off-by: Ryan Moats Acked-by: Flavio Fernandes > --- > ovn/controller/ovn-controller.c | 1 + > 1