hi Samuel,
I had some minor comments. Looks good otherwise.
Acked-by: Nithin Raju nit...@vmware.com
On Sep 24, 2014, at 8:42 AM, Samuel Ghinet sghi...@cloudbasesolutions.com
wrote:
The transactional get vport command.
This command uses the netlink transactional errors.
Signed-off-by:
Hello Eitan,
You want to return STATUS_INVALID_BUFFER_SIZE instead.
XXX We need to go through all datapath.c and remove NDIS return code (perhaps
in a different change)
Done.
Does the caller set *replyLen =0;
Perhaps regardless of the call, *replyLen should be initialized to 0.
I have moved
All of the vport commands are implemented in Vport.c. Pls. move this to that
file. Perhaps even the Vport dump. You can move all of them at once in a
subsequent commit.
I know that. I was not sure of the approach I should take.
The linux ovs driver does all the netlink communication part in
hi Sam,
Thanks for incorporating the comments in the latest patch.
On Sep 25, 2014, at 2:44 PM, Samuel Ghinet sghi...@cloudbasesolutions.com
wrote:
All of the vport commands are implemented in Vport.c. Pls. move this to that
file. Perhaps even the Vport dump. You can move all of them at once
Looks good. Please find comments inline.
Thanks,
Eitan
-Original Message-
From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
Sent: Wednesday, September 24, 2014 8:42 AM
To: dev@openvswitch.org
Cc: Alin Serdean; Eitan Eliahu; Nithin Raju; Ankur Sharma; Saurabh Shah
Subject:
