The following script leverage's the advantages of WMI infrastructure
offered in Hyper-V.
This scripts allows the user to change the
Msvm_EthernetPortAllocationSettingData property of a VM network adapter
connected to a Hyper-V Virtual Switch.
Usage:
import-module .\OVS.psm1
$vnic =
Moved the structure OVS_MESSAGE to Netlink.h.
This change is done for following reasons.
a. Patch 2 in this series provides a generic API in Netlink.c
for creating netlink message. That API needs OVS_MESSAGE.
Including Datapath.h in Netlink.c/h gives compilation error.
b. OVS_MESSAGE defines
Added NlFillOvsMsg API in Netlink.c This API will be used to populate
netlink message headers.
Signed-off-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Acked-by: Eitan Eliahu elia...@vmware.com
---
datapath-windows/ovsext/Netlink/Netlink.c
Added an API to retrieve the attribute length.
Added 2 more API for BE16 and BE8 attribute parsing.
Fixed a trailing whitespace issue.
Signed-off-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Acked-by: Eitan Eliahu elia...@vmware.com
---
This patch covers basic changes in registering add flow handler.
And declaring FLOW related attribute parsing policies.
Signed-off-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Acked-by: Eitan Eliahu elia...@vmware.com
---
NlAttrParseNested was using the whole netlink payload for iteration.
This is not correct, as it would lead to exceeding the
nested attribute boundries. Fixed the same in this patch.
Signed-off-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Signed-off-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Acked-by: Eitan Eliahu elia...@vmware.com
---
datapath-windows/ovsext/Netlink/Netlink.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
This patch covers the changes needed to support FLOW_NEW command.
API _OvsFlowMapNlToFlowPutFlags has a bug, which will be fixed
with the patches for FLOW_DEL.
Signed-off-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Acked-by: Eitan Eliahu
Registered FLOW_DEL command handler. The same command
handler as FLOW_ADD is good enough to handle FLOW_DEL
case as well with minor changes for checking to action
attribute.
Signed-off-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Acked-by:
Registered FLOW_SET command handler. The same command
handler as FLOW_ADD is good enough to handle FLOW_SET
case as well.
Signed-off-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Acked-by: Eitan Eliahu elia...@vmware.com
---
Added changes to handle DEL_FLOWS (FLUSH) scenario.
Signed-off-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Acked-by: Eitan Eliahu elia...@vmware.com
---
datapath-windows/ovsext/Flow.c | 19 ++-
On Sep 24, 2014, at 11:56 PM, Ankur Sharma ankursha...@vmware.com
wrote:
Moved the structure OVS_MESSAGE to Netlink.h.
This change is done for following reasons.
a. Patch 2 in this series provides a generic API in Netlink.c
for creating netlink message. That API needs OVS_MESSAGE.
On Sep 24, 2014, at 11:57 PM, Ankur Sharma ankursha...@vmware.com
wrote:
Added NlFillOvsMsg API in Netlink.c This API will be used to populate
netlink message headers.
Signed-off-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
On Sep 24, 2014, at 11:57 PM, Ankur Sharma ankursha...@vmware.com wrote:
Added an API to retrieve the attribute length.
Added 2 more API for BE16 and BE8 attribute parsing.
Fixed a trailing whitespace issue.
Signed-off-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Alin Gabriel Serdean
On Sep 24, 2014, at 11:57 PM, Ankur Sharma ankursha...@vmware.com wrote:
Signed-off-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Acked-by: Eitan Eliahu elia...@vmware.com
Acked-by: Nithin Raju nit...@vmware.com
On Sep 24, 2014, at 11:57 PM, Ankur Sharma ankursha...@vmware.com wrote:
NlAttrParseNested was using the whole netlink payload for iteration.
This is not correct, as it would lead to exceeding the
nested attribute boundries. Fixed the same in this patch.
Signed-off-by: Ankur Sharma
On Sep 24, 2014, at 11:57 PM, Ankur Sharma ankursha...@vmware.com wrote:
This patch covers basic changes in registering add flow handler.
And declaring FLOW related attribute parsing policies.
Signed-off-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Alin Gabriel Serdean
The Read event handler is executed when user mode issues a socket receive on
an MC socket associated with the event queue. A new IOCTL READ command is
used to differentiate between transaction based and packet miss sockets.
An entry for the handler will be added once the Vport family
Hi all,
I need to filter packets based on Layer 7 inside of ovs flow tables for my
graduation work. Doing some research on internet I've found l7-filter
http://l7-filter.sourceforge.net/
Does anyone know if it is possible to use this software inside the OVS code?
Thanks in advance.
Best
I want to check *Statistics : load_average *of openvswitch*, *I have gone
throgh this link http://openvswitch.org/ovs-vswitchd.conf.db.5.pdf
but I am not getting how to extract Statistics : load_average field from
Open_vSwitch table.
Is there any command for this?
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Date: Wed, 24 Sep 2014 00:15:35 -0700
From: Ankur Sharma ankursha...@vmware.com
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH v1 01/10] datapath-windows: move OVS_MESSAGE
to Netlink.h
Ankur,
The NlFillOvsMsg function you add looks very similar to my versions:
BuildReplyMsgFromMsgIn and BuildMsgOut.
Please look on my latest patch on vport dump to see how I defined
OvsCreateMsgFromVport. This patch of mine is not merged yet.
We could use both versions, and refactor later. Or
One very minor thing:
I believe the titles of the commit messages are normally put like Add
NlAttrLen API, not Added NlAttrLen API.
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Date: Wed, 24 Sep 2014 00:15:37 -0700
From: Ankur Sharma
Hello Ankur,
This code confused me a little.
It looks correct, but I would have a few suggestions:
o)
BOOLEAN
NlAttrParse(const PNL_MSG_HDR nlMsg, UINT32 attrOffset,
UINT32 attrLen,
the attrLen field gives the impression that it is the length of one single
attribute.
You could
On Sep 24, 2014, at 11:58 PM, Ankur Sharma ankursha...@vmware.com wrote:
This patch covers the changes needed to support FLOW_NEW command.
API _OvsFlowMapNlToFlowPutFlags has a bug, which will be fixed
with the patches for FLOW_DEL.
Signed-off-by: Ankur Sharma ankursha...@vmware.com
Hey Ankur,
A few notes:
+NETLINK_CMD nlFlowFamilyCmdOps[] = {
+{ .cmd = OVS_FLOW_CMD_NEW,
+ .handler = OvsFlowNlNewCmdHandler,
+ .supportedDevOp = OVS_TRANSACTION_DEV_OP,
+ .validateDpIndex = FALSE
+}
+};
It is possible that we need to have
On Sep 24, 2014, at 11:58 PM, Ankur Sharma ankursha...@vmware.com wrote:
Registered FLOW_SET command handler. The same command
handler as FLOW_ADD is good enough to handle FLOW_SET
case as well.
Signed-off-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Alin Gabriel Serdean
On Thu, Sep 25, 2014 at 07:39:23AM -0700, Gauri Bhutkar wrote:
I want to check *Statistics : load_average *of openvswitch*, *I have gone
throgh this link http://openvswitch.org/ovs-vswitchd.conf.db.5.pdf
but I am not getting how to extract Statistics : load_average field from
Open_vSwitch
Sub-test RSTP - dummy interface checks the ovs-vswitchd.log
output immediately after command execution. The check may
fail if the write of new log is delayed by the IO thread.
This commit fixes the above issue by waiting for the
ovs-vswitchd.log output.
Signed-off-by: Alex Wang al...@nicira.com
On Sep 24, 2014, at 11:58 PM, Ankur Sharma ankursha...@vmware.com wrote:
Registered FLOW_DEL command handler. The same command
handler as FLOW_ADD is good enough to handle FLOW_DEL
case as well with minor changes for checking to action
attribute.
Signed-off-by: Ankur Sharma
On Sep 24, 2014, at 11:58 PM, Ankur Sharma ankursha...@vmware.com wrote:
Added changes to handle DEL_FLOWS (FLUSH) scenario.
Signed-off-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Acked-by: Eitan Eliahu elia...@vmware.com
LG.
Hey Ankur,
+if (keyAttrs[OVS_KEY_ATTR_TUNNEL]) {
+destKey-tunKey.tunnelId = NlAttrGetU64
+ (tunAttrs[OVS_TUNNEL_KEY_ATTR_ID]);
+destKey-tunKey.dst = NlAttrGetU32
+ (tunAttrs[OVS_TUNNEL_KEY_ATTR_IPV4_DST]);
+
Hey Ankur,
There are a few differences between flow new and flow set, with regard to the
transactional errors that will need to be implemented:
Flow New: can do NEW or SET.
If netlink command flow new is issued, with netlink flags create and
exclusive, and the flow exists, it must return
LG. Maybe we should call the function as OvsFlowNlCmdHandler, and get rid of
the 'New'.
.validateDpindex should be TRUE.
Acked-by: Nithin Raju nit...@vmware.com
-- Nithin
___
dev mailing list
dev@openvswitch.org
On Thu, Sep 25, 2014 at 8:51 AM, Alex Wang al...@nicira.com wrote:
Sub-test RSTP - dummy interface checks the ovs-vswitchd.log
output immediately after command execution. The check may
fail if the write of new log is delayed by the IO thread.
This commit fixes the above issue by waiting for
Oh, now I see, flow flush is handled :)
Date: Wed, 24 Sep 2014 00:15:44 -0700
From: Ankur Sharma ankursha...@vmware.com
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH v1 10/10] datapath-windows/Flow.c: DEL_FLOWS
command handler.
Message-ID:
Hey Eitan,
*/
#if defined OVS_USE_NL_INTERFACE OVS_USE_NL_INTERFACE == 1
+#pragma warning( push )
+#pragma warning( disable:4127 )
+
#include precomp.h
Could you put some doc comment saying what warning you are disabling, and
perhaps, why? :)
You've got a few else-s like this:
I now see this new version.
The while has been removed I see, along with the issues I had pointed out with
the values returned.
I will write my comments here, of the things that still remained :)
}
+
/*
* --
*
In the future it might be useful if we could do recursive validation checks in
NlAttrValidate when we have nested attributes.
Because I am not sure we can currently validate the netlink attributes nested
in parent netlink attributes, using functions like NlAttrValidate.
Acked-by: Samuel Ghinet
Hey Ankur,
A problem I see here with flow delete is that Flow delete requires:
- no attributes (i.e. no key): if flow flush is requested
- key only: if a specific flow key is to be deleted.
When / if masks will be allowed for flows, the mask is expected not to exist.
How does the current code
Reported-by: Daniel Badea daniel.ba...@windriver.com
Signed-off-by: Alex Wang al...@nicira.com
---
lib/netdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/netdev.c b/lib/netdev.c
index 1fd5121..a9ad7d1 100644
--- a/lib/netdev.c
+++ b/lib/netdev.c
@@ -682,7 +682,7
hi Samuel,
I had some minor comments. Looks good otherwise.
Acked-by: Nithin Raju nit...@vmware.com
On Sep 24, 2014, at 8:42 AM, Samuel Ghinet sghi...@cloudbasesolutions.com
wrote:
The transactional get vport command.
This command uses the netlink transactional errors.
Signed-off-by:
On Thu, Sep 25, 2014 at 8:51 AM, Alex Wang al...@nicira.com wrote:
Sub-test RSTP - dummy interface checks the ovs-vswitchd.log
output immediately after command execution. The check may
fail if the write of new log is delayed by the IO thread.
This commit fixes the above issue by waiting for
When kernel cannot obtain the pci numa info, the numa_node file
in corresponding pci directory in sysfs will show -1. Then the
rte_eth_dev_socket_id() function will return it to ovs. On
current master, ovs assumes rte_eth_dev_socket_id() always
returns non-negative value. So using this -1 in
Thanks, applied to master,
On Thu, Sep 25, 2014 at 12:39 PM, Gurucharan Shetty shet...@nicira.com
wrote:
On Thu, Sep 25, 2014 at 8:51 AM, Alex Wang al...@nicira.com wrote:
Sub-test RSTP - dummy interface checks the ovs-vswitchd.log
output immediately after command execution. The check may
Both patches applied. Thanks!
On Wed, Sep 24, 2014 at 8:57 PM, Simon Horman
simon.hor...@netronome.com wrote:
Hi,
this short series proposes to minor simplifications to ofproto-dpif-rid.
They are not related to each other other than that there is a minor
conflict in applying the second patch
Acked-by: Daniele Di Proietto ddiproie...@vmware.com
On 9/25/14, 11:45 AM, Alex Wang al...@nicira.com wrote:
Reported-by: Daniel Badea daniel.ba...@windriver.com
Signed-off-by: Alex Wang al...@nicira.com
---
lib/netdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Thu, Sep 25, 2014 at 2:00 PM, Daniele Di Proietto ddiproie...@vmware.com
wrote:
Acked-by: Daniele Di Proietto ddiproie...@vmware.com
Thanks, will apply it soon, also will change the name to 'fix error check'
___
dev mailing list
Thanks for the fix!
Acked-by: Daniele Di Proietto ddiproie...@vmware.com
On 9/25/14, 1:28 PM, Alex Wang al...@nicira.com wrote:
When kernel cannot obtain the pci numa info, the numa_node file
in corresponding pci directory in sysfs will show -1. Then the
rte_eth_dev_socket_id() function will
Don't forget to add Daniel to AUTHORS.
--Justin
On September 25, 2014 at 1:27:30 PM, Alex Wang (al...@nicira.com) wrote:
When kernel cannot obtain the pci numa info, the numa_node file
in corresponding pci directory in sysfs will show -1. Then the
rte_eth_dev_socket_id() function will return
Thx, Daniele also reminded me of that, will fold that in with the patch.
On Thu, Sep 25, 2014 at 2:07 PM, Justin Pettit jpet...@nicira.com wrote:
Don't forget to add Daniel to AUTHORS.
--Justin
On September 25, 2014 at 1:27:30 PM, Alex Wang (al...@nicira.com) wrote:
When kernel cannot
Acked-by: Justin Pettit jpet...@nicira.com
On Fri, Sep 19, 2014 at 7:29 AM, Gurucharan Shetty shet...@nicira.com
wrote:
Reported-by: Ziyou Wang ziy...@vmware.com
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
---
AUTHORS |1 +
vtep/README.ovs-vtep |1 +
2 files
Acked-by: Justin Pettit jpet...@nicira.com
On Fri, Sep 19, 2014 at 7:29 AM, Gurucharan Shetty shet...@nicira.com
wrote:
This is needed to create, get, set records in the Tunnel table.
(We need to add the Tunnel table's 'local' and 'remote' columns
that point to the Physical_Locator record
Acked-by: Justin Pettit jpet...@nicira.com
On Fri, Sep 19, 2014 at 7:29 AM, Gurucharan Shetty shet...@nicira.com
wrote:
Before destroying a logical switch, cleanup any left over local
mac information in Ucast_Macs_Local or Mcast_Macs_Local table.
We need to do this to atleast cleanup the
The windows ovs kernel uses an OVS_VPORT_TYPE enum that is incompatible with
the userspace counterpart (enum ovs_vport_type from openvswitch.h). We must use
the same enum type for the netlink communication to work properly.
This patch makes the fix: typedef enum ovs_vport_type OVS_VPORT_TYPE and
Acked-by: Justin Pettit jpet...@nicira.com
On Fri, Sep 19, 2014 at 7:29 AM, Gurucharan Shetty shet...@nicira.com
wrote:
ovs-vtep is an emulator and it works only on one
physical switch. This switch name is stored in the variable
'ps_name' and then passed around. An upcoming commit requires
Functionality for vport dump.
Later, when we will add more netlink dump commands, some common code will need
to be split to functions.
Notes:
a) the current implementation of vport assumes the datapath feature
multiple upcall pids is not used. A single upcall pid is used now.
c) the vxlan
Acked-by: Justin Pettit jpet...@nicira.com
On Fri, Sep 19, 2014 at 7:29 AM, Gurucharan Shetty shet...@nicira.com
wrote:
string.split() function splits a quoted string if there is a whitespace
inside the quote.
ex: The following code snippet will output ['printing', 'No',
'Diagnostic']
args
The transactional get vport command.
This command uses the netlink transactional errors.
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Acked-by: Nithin Raju nit...@vmware.com
---
datapath-windows/ovsext/Datapath.c | 83 +-
1 file changed, 82
Contains error codes for netlink transactional errors.
These errors are passed to the error field (INT) of the NL_MSG_ERR struct.
The userspace requires them to be negative values: the nl_msg_nlmsgerr userspace
function transforms them from negative to positive values.
These error codes
Hello Eitan,
You want to return STATUS_INVALID_BUFFER_SIZE instead.
XXX We need to go through all datapath.c and remove NDIS return code (perhaps
in a different change)
Done.
Does the caller set *replyLen =0;
Perhaps regardless of the call, *replyLen should be initialized to 0.
I have moved
All of the vport commands are implemented in Vport.c. Pls. move this to that
file. Perhaps even the Vport dump. You can move all of them at once in a
subsequent commit.
I know that. I was not sure of the approach I should take.
The linux ovs driver does all the netlink communication part in
On Sep 25, 2014, at 7:52 AM, Daniele Venturino daniele.ventur...@m3s.it wrote:
After some testing, here’s my ack.
Acked-by: Daniele Venturino daniele.ventur...@m3s.it
Pushed to master, thanks!
Jarno
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index
hi Sam,
Thanks for incorporating the comments in the latest patch.
On Sep 25, 2014, at 2:44 PM, Samuel Ghinet sghi...@cloudbasesolutions.com
wrote:
All of the vport commands are implemented in Vport.c. Pls. move this to that
file. Perhaps even the Vport dump. You can move all of them at once
While calculating the hash on a VPORT name, we don't include the NUL character.
We should be doing the same while doing lookup as well.
Signed-off-by: Nithin Raju nit...@vmware.com
---
datapath-windows/ovsext/Datapath.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
Thanks Sam for the review.
rc stands for Return Code and it holds the Boolean intermediate return code,
returned from the NL functions.
I removed the blank line and lifted the else(s).
Regarding the sharing of code between READ and READ_EVENT, a common function
would take too many parameters.
The Read event handler is executed when user mode issues a socket receive on
an MC socket associated with the event queue. A new IOCTL READ command is
used to differentiate between transaction based and packet miss sockets.
An entry for the handler will be added once the Vport family
67 matches
Mail list logo
