Hi Saurabh,
At the end of the day today. Was on short PTO last week.
Alin.
-Mesaj original-
De la: Saurabh Shah [mailto:ssaur...@vmware.com]
Trimis: Wednesday, August 27, 2014 2:46 AM
Către: Alin Serdean; dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] Add build of ovsext.sln using
Hi Saurabh,
Could you please try to do the autoreconf again.
./boot.sh
./configure
Thanks.
-Mesaj original-
De la: Saurabh Shah [mailto:ssaur...@vmware.com]
Trimis: Wednesday, August 27, 2014 3:01 AM
Către: Samuel Ghinet; dev@openvswitch.org
Cc: Alin Serdean; Nithin Raju
Subiect: RE
Hi Eithan,
Yes. Also Win8 or Win8.1
I still to format it accordingly and will send out the patch.
Alin.
-Mesaj original-
De la: Eitan Eliahu [mailto:elia...@vmware.com]
Trimis: Wednesday, August 27, 2014 5:40 PM
Către: Alin Serdean; Saurabh Shah; dev@openvswitch.org
Subiect: RE: [ovs
Hi Eithan,
Will add them anyway for the moment.
Alin.
-Mesaj original-
De la: Eitan Eliahu [mailto:elia...@vmware.com]
Trimis: Wednesday, August 27, 2014 6:08 PM
Către: Alin Serdean; Saurabh Shah; dev@openvswitch.org
Subiect: RE: [ovs-dev] [PATCH] Add build of ovsext.sln using MSBuild
You need to commit the patch also. It needs to do the diff between git ls-files
and the actual files.
-Mesaj original-
De la: Saurabh Shah [mailto:ssaur...@vmware.com]
Trimis: Wednesday, August 27, 2014 6:59 PM
Către: Alin Serdean; Samuel Ghinet; dev@openvswitch.org
Cc: Nithin Raju
This commit adds to the automake build system the full build required
by the forwarding extension solution.
It will help a lot in the future CI to check the full build of the project.
To configure the forwarding extension to be built one could use the following:
./configure CC=./build-aux/cccl
Hi,
Will send the patch until the end of the day.
Alin.
-Mesaj original-
De la: Saurabh Shah [mailto:ssaur...@vmware.com]
Trimis: Thursday, August 28, 2014 9:31 PM
Către: Alin Serdean; dev@openvswitch.org; Ben Pfaff
Subiect: Re: [ovs-dev] [PATCH 3/4] Changes needed to compile dpif
Rename dpif_linux - dpif_netlink the actual file can be renamed as well
in the future.
Bypass all epoll functionality.
Treat dpif_netlink_recv__ with lazy polling using GetOverlappedResult
with the newly added overlapped structure in netlink.c
Initialize dpif_netlink_class on MSVC as well and
Hi Eitan,
I think we could use the same design.
I can respin the patch on Monday if you can wait.
Alin.
De la: Eitan Eliahu [mailto:elia...@vmware.com]
Trimis: Friday, August 29, 2014 6:30 AM
Către: Alin Serdean; dev@openvswitch.org; Nithin Raju; Saurabh Shah
Subiect: RE: [ovs-dev] [PATCHv2
MSVC does not like variable length array either.
This patch treats the following error:
lib/dpif-netdev.c(2272) :
error C2057: expected constant expression
lib/dpif-netdev.c(2272) :
error C2466: cannot allocate an array of constant size 0
lib/dpif-netdev.c(2272) :
error C2133: 'batches' :
Hi Ankur,
Just a small nit I you use git format-patch could you also add the -M option?
Thank you,
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Wednesday, September 3, 2014 4:04 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev]
Please.
I will look over the other patches after the meeting :).
Alin.
-Mesaj original-
De la: Ankur Sharma [mailto:ankursha...@vmware.com]
Trimis: Wednesday, September 3, 2014 7:34 PM
Către: Alin Serdean; dev@openvswitch.org
Subiect: RE: [ovs-dev] [PATCH 1/5] datapath-windows/Netlink
Acked-by: Alin Gabriel Serdean aserdean at cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Tuesday, September 2, 2014 6:05 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 5/5] Netlink.c: Added netlink put APIs.
Acked-by: Alin Gabriel Serdean aserdean at cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Tuesday, September 2, 2014 6:05 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 4/5] OvsTypes.h : Added support for
Acked-by: Alin Gabriel Serdean aserdean at cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Tuesday, September 2, 2014 6:05 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH 3/5] NetlinkProto.h: Minor fix for
Maybe just rename NL_BUF with NL_BUFFER otherwise I am fine with the patch.
Acked-by: Alin Gabriel Serdean aserdean at cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Tuesday, September 2, 2014 6:05 PM
Către:
Sure be my guest :).
-Mesaj original-
De la: Ankur Sharma [mailto:ankursha...@vmware.com]
Trimis: Wednesday, September 3, 2014 1:14 PM
Către: Alin Serdean; dev@openvswitch.org
Subiect: RE: [ovs-dev] [PATCH 1/5] datapath-windows/Netlink: Move netlink files
to a new directory.
Hi Alin
Hi Eitan,
#else
sock-fd = socket(AF_NETLINK, SOCK_RAW, protocol);
if (sock-fd 0) {
+int last_error = GetLastError();
The above breaks linux build. You could leave last_error outside and use it
wherever appropriate.
#define OVS_DEVICE_NAME_NT L\\Device\\OpenvSwitchDevice
Hi Eitan
Beside some style issue in:
+#ifdef _WIN32
+/* Pend an I/O request in the driver. The driver completes the I/O whenever
+* an event or a packet is ready to be read. Once the I/O is completed
+* the overlapped structure event associated with the pending I/O will be set
+*/
Acked-by: Alin
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Tuesday, September 9, 2014 9:03 AM
Către: dev@openvswitch.org; Samuel Ghinet
Subiect: [ovs-dev] [PATCH v2] datapath-windows: update
Hi Eitan,
Trailing whitespace:
+ OVS_CTRL_CMD_MC_SUBSCRIBE_REQ,
+static int __inline
And could not apply patch because
+/* NL Attributes for joining/unjoining an MC group */ enum
+ovs_nl_mcast_attr {
+OVS_NL_ATTR_MCAST_GRP, /* Join an MC group */
+
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty
Trimis: Wednesday, September 10, 2014 10:56 PM
Către: dev@openvswitch.org
Cc: Gurucharan Shetty
Subiect: [ovs-dev] [PATCH 2/3]
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Thanks for removing a lot warnings.
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty
Trimis: Wednesday, September 10, 2014 10:56 PM
Către: dev@openvswitch.org
Cc: Gurucharan
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty
Trimis: Wednesday, September 10, 2014 10:56 PM
Către: dev@openvswitch.org
Cc: Gurucharan Shetty
Subiect: [ovs-dev] [PATCH 1/3]
Sorry I missed this one.
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: Gurucharan Shetty [mailto:shet...@nicira.com]
Trimis: Tuesday, September 9, 2014 10:39 PM
Către: dev@openvswitch.org
Cc: Alin Serdean; Eitan Eliahu; Gurucharan Shetty
Subiect
Hi Guru,
You are right probably either use WaitForMultipleObjects or add wrapper
functionality for it.
Alin.
-Mesaj original-
De la: Gurucharan Shetty [mailto:shet...@nicira.com]
Trimis: Tuesday, September 9, 2014 11:28 PM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs
Hi Eitan,
I think putting in pragmas to disable warnings is a bit over our hand.
Either we just disable them in a common include header or we leave them and
actually fix the warnings.
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Eitan Eliahu
Trimis:
Hi Eitan,
Still cannot get the patch to apply:
$ git apply patch1
error: patch failed: datapath-windows/include/OvsDpInterfaceExt.h:70
error: datapath-windows/include/OvsDpInterfaceExt.h: patch does not apply
This part:
@@ -70,6 +70,14 @@
/* Commands available under the OVS_WIN_CONTROL_FAMILY.
: Alin Serdean; Gurucharan Shetty; dev@openvswitch.org
Cc: Gurucharan Shetty
Subiect: RE: [ovs-dev] [PATCH 3/3] Avoid uninitialized variable warnings with
OBJECT_OFFSETOF() in MSVC.
Hi Alin,
I would prefer to disable the warning in a very limited scope rather than
disabling them across all source
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Thursday, September 11, 2014 3:36 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v4 2/2] datapath-windows/Netlink: Nested
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Thursday, September 11, 2014 3:36 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v4 1/2] datapath-windows/NetlinkBuf.h:
+1 :)
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Eitan Eliahu
Trimis: Thursday, September 11, 2014 8:01 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v5] Netlink_socket.c Join/Unjoin an MC group for
event subscription
Use a specific out of band
The patch contains the necessary modifications to compile and also to run
under MSVC.
Added the files to the build system and also changed dpif_linux to be under
a more generic name dpif_windows.
Added a TODO under the windows part in case we want to implement another
counterpart for epoll
I can change the filename after the patch gets merged no problem :).
Thank you,
Alin.
-Mesaj original-
De la: Ben Pfaff [mailto:b...@nicira.com]
Trimis: Wednesday, September 17, 2014 11:38 PM
Către: Eitan Eliahu
Cc: Alin Serdean; Nithin Raju; dev@openvswitch.org
Subiect: Re: [ovs-dev
Did a full clone-autoreconf-make-make check under Linux did not see any
issues.
Alin.
-Mesaj original-
De la: Eitan Eliahu [mailto:elia...@vmware.com]
Trimis: Wednesday, September 17, 2014 1:47 PM
Către: Ben Pfaff
Cc: Alin Serdean; Nithin Raju; dev@openvswitch.org
Subiect: RE: [ovs-dev
I will rebase and also the filename change in V2.
-Mesaj original-
De la: Ben Pfaff [mailto:b...@nicira.com]
Trimis: Wednesday, September 17, 2014 2:06 PM
Către: Alin Serdean
Cc: Eitan Eliahu; 'Nithin Raju'; dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] Changes needed for dpif-linux
original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Wednesday, September 17, 2014 3:16 PM
Către: Alin Serdean
Cc: Eitan Eliahu; Ben Pfaff; dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to compile under
MSVC
On Sep 17, 2014, at 1:11 PM, Alin
Ok will update it to dpif_netlink_vport*.
-Mesaj original-
De la: Ben Pfaff [mailto:b...@nicira.com]
Trimis: Wednesday, September 17, 2014 3:37 PM
Către: Alin Serdean
Cc: Nithin Raju; Eitan Eliahu; dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] Changes needed for dpif-linux
Unfortunately there some special characters in dpif-linux.c
that do not allow me to send the patch normally.
Trying via attachment.
Short description:
The patch contains the necessary modifications to compile and also to run
under MSVC.
Added the files to the build system and also changed
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: Samuel Ghinet
Trimis: Tuesday, September 23, 2014 3:46 PM
Către: dev@openvswitch.org
Cc: nit...@vmware.com; Ankur Sharma; ssaur...@vmware.com; Alin Serdean;
elia...@vmware.com
Subiect: [PATCH v2
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: Samuel Ghinet
Trimis: Wednesday, September 24, 2014 5:01 PM
Către: dev@openvswitch.org
Cc: Alin Serdean; nit...@vmware.com; ssaur...@vmware.com; elia...@vmware.com;
Ankur Sharma; kg...@vmware.com
Some minor formatting issues.
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: Samuel Ghinet
Trimis: Wednesday, September 24, 2014 6:41 PM
Către: dev@openvswitch.org
Cc: Alin Serdean; elia...@vmware.com; nit...@vmware.com; ssaur...@vmware.com
Hi Eitan,
1. Git apply whitespaces
$ git apply ovs-dev-datapath-windows-Event-read-handler.patch
ovs-dev-datapath-windows-Event-read-handler.patch:108: trailing whitespace.
* Utility function to fill up information about the state of a port in a reply
Hi Ankur,
As Eitan was mentioning drop:
nlMsg-nlmsgLen = NLMSG_ALIGN(NlBufSize(nlBuf));
I see you declaring the following structure but never used:
/* Structure to hold arguments needed by NlFillOvsMsg */
typedef struct _NL_FILL_ARGS {
UINT16 nlmsgType;
UINT8 genlCmd;
UINT8
Think it would be a good idea to inline the functions.
Also maybe add asserts to nla.
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Wednesday, September 24, 2014 10:16 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v1
Maybe drop ret because it is confusing.
return TRUE;
//goto done;
...
return TRUE;
done:
return FALSE;
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Wednesday, September 24, 2014 10:16 AM
Către: dev@openvswitch.org
Sounds good to me.
Alin.
-Mesaj original-
De la: Ankur Sharma [mailto:ankursha...@vmware.com]
Trimis: Thursday, September 25, 2014 4:24 AM
Către: Alin Serdean; dev@openvswitch.org
Subiect: RE: [ovs-dev] [PATCH v1 03/10] datapath-windows/Netlink: Added
NlAttrLen API
Hi Alin,
Yes Eitan
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Wednesday, September 24, 2014 10:16 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v1 05/10] datapath-windows/Netlink:
$ git apply
ovs-dev-v1-06-10-datapath-windows-Flow.c-Basic-support-for-add-flow..patch
ovs-dev-v1-06-10-datapath-windows-Flow.c-Basic-support-for-add-flow..patch:12:
trailing whitespace.
{ .cmd = OVS_FLOW_CMD_NEW,
warning: 1 line adds whitespace errors.
Acked-by: Alin Gabriel
In OvsFlowNlNewCmdHandler you could drop the following commented lines:
NTSTATUS rc = STATUS_SUCCESS;
POVS_MESSAGE msgIn = (POVS_MESSAGE)usrParamsCtx-inputBuffer;
POVS_MESSAGE msgOut = (POVS_MESSAGE)usrParamsCtx-outputBuffer;
PNL_MSG_HDR nlMsgHdr = (msgIn-nlMsg);
PGENL_MSG_HDR
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Wednesday, September 24, 2014 10:16 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v1 08/10] datapath-windows/Flow.c:
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Wednesday, September 24, 2014 10:16 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v1 09/10] datapath-windows/Flow.c:
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Wednesday, September 24, 2014 10:16 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v1 10/10] datapath-windows/Flow.c:
Just forgot the following:
$ git apply
ovs-dev-v1-10-10-datapath-windows-Flow.c-DEL_FLOWS-command-handler..patch
ovs-dev-v1-10-10-datapath-windows-Flow.c-DEL_FLOWS-command-handler..patch:20:
trailing whitespace.
if ((genlMsgHdr-cmd == OVS_FLOW_CMD_DEL)
warning: 1 line adds whitespace
Tested-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: Sorin Vinturis
Trimis: Wednesday, September 24, 2014 12:43 PM
Către: dev@openvswitch.org
Cc: Alin Serdean; nit...@vmware.com; Sorin
Tested-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: Samuel Ghinet
Trimis: Thursday, September 25, 2014 2:44 AM
Către: dev@openvswitch.org
Cc: Alin Serdean; nit...@vmware.com; elia
1. ovs-dev-v1-datapath-windows-Event-read-handler.patch:12: new blank line at
EOF.
+
warning: 1 line adds whitespace errors.
2. OvsPostEvent adds elements to the queue can you please find a similar name
for OvsRemoveEventEntry
3. Really don't like that we have to push in:
+#pragma warning(
-Mesaj original-
De la: Eitan Eliahu [mailto:elia...@vmware.com]
Trimis: Thursday, September 25, 2014 7:48 AM
Către: Alin Serdean; dev@openvswitch.org
Subiect: RE: [ovs-dev] [PATCH v1] datapath-windows Event read handler
Alin, this warning is used to warn about constant in a condition
It was not guarded until now so was wondering why guard it now :), unless that
you want to use this as a mark for later on.
Alin.
De la: Eitan Eliahu [mailto:elia...@vmware.com]
Trimis: Thursday, September 25, 2014 8:34 AM
Către: Alin Serdean; dev@openvswitch.org
Subiect: RE: [ovs-dev] [PATCH
None what so ever. Was just wondering if there was a hidden meaning to it that
I missed :).
Alin.
De la: Eitan Eliahu [mailto:elia...@vmware.com]
Trimis: Thursday, September 25, 2014 8:41 AM
Către: Alin Serdean; dev@openvswitch.org
Subiect: RE: [ovs-dev] [PATCH v1] datapath-windows Event read
The following script leverage's the advantages of WMI infrastructure
offered in Hyper-V.
This scripts allows the user to change the
Msvm_EthernetPortAllocationSettingData property of a VM network adapter
connected to a Hyper-V Virtual Switch.
Usage:
import-module .\OVS.psm1
$vnic =
:35 AM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] WMI Script that updates Hyper-V friendly port
names
On Sep 24, 2014, at 11:18 PM, Alin Serdean aserd...@cloudbasesolutions.com
wrote:
The following script leverage's the advantages of WMI infrastructure
offered
Hello Nithin,
I will update the documentation as soon as I can. Also I need to add the
visualddk flag explanation.
Thanks,
Alin.
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Saturday, September 27, 2014 5:16 AM
Către: Alin Serdean
Cc: dev@openvswitch.org
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Eitan Eliahu
Trimis: Saturday, September 27, 2014 11:39 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v4] datapath-windows Event read
Tested under Release/Debug.
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Monday, September 29, 2014 8:17 PM
Către: Ankur Sharma
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev]
Hi Nithin,
We used a modified version of netdev-windows.
Alin.
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Tuesday, September 30, 2014 6:09 PM
Către: Samuel Ghinet
Cc: dev@openvswitch.org; Alin Serdean; Eitan Eliahu; Ankur Sharma
Subiect: Re: [PATCH 14/14
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis
Trimis: Thursday, October 2, 2014 11:53 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v2] datapath-windows: Incorrect
Waiting for the respin.
Just a couple of more remarks.
ovs-dev-v1-3-5-datapath-windows-Flow-Dump-handler.patch:50: trailing whitespace.
{ .cmd = OVS_FLOW_CMD_GET,
ovs-dev-v1-3-5-datapath-windows-Flow-Dump-handler.patch:52: trailing whitespace.
.supportedDevOp =
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Tested-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Sunday, October 5, 2014 1:10 AM
Către: dev@openvswitch.org
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Tested-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Sunday, October 5, 2014 1:10 AM
Către: dev@openvswitch.org
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Tested-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Sunday, October 5, 2014 1:10 AM
Către: dev@openvswitch.org
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Tested-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Sunday, October 5, 2014 1:10 AM
Către: dev@openvswitch.org
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Tested-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Sunday, October 5, 2014 1:10 AM
Către: dev@openvswitch.org
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Tested-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Sunday, October 5, 2014 1:10 AM
Către: dev@openvswitch.org
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Tested-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Sunday, October 5, 2014 1:10 AM
Către: dev@openvswitch.org
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Saturday, October 4, 2014 1:54 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v3 5/5] datapath-windows: Flow get
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Saturday, October 4, 2014 1:54 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v3 3/5] datapath-windows: Flow Dump
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Saturday, October 4, 2014 1:54 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v3 2/5] datapath-windows: Added the API
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Saturday, October 4, 2014 1:54 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v3 1/5] datapath-windows: Netlink
Good catch Nithin thank you for folding it up!
Thanks,
Alin.
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Wednesday, October 8, 2014 12:29 AM
Către: Samuel Ghinet; dev@openvswitch.org
Cc: Alin Serdean; Eitan Eliahu; Ankur Sharma
Subiect: RE: [PATCH 12/14
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: Lucian Petrut [mailto:petrutlucia...@gmail.com]
Trimis: Wednesday, October 8, 2014 8:05 PM
Către: dev@openvswitch.org
Cc: Alin Serdean; Lucian Petrut
Subiect: [PATCH] Update the WMI Script handling
: Wednesday, October 8, 2014 8:44 PM
Către: Alin Serdean
Cc: Lucian Petrut; dev@openvswitch.org; Lucian Petrut
Subiect: Re: [ovs-dev] [PATCH] Update the WMI Script handling Hyper-V friendly
port names
I'm confused. The From: at the top of the email indicates you're the author.
You can't sensibly
Add the following files:
meta-flow.inc
nx-match.inc
to lib/.gitignore
Signed-off-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
---
lib/.gitignore | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/.gitignore b/lib/.gitignore
index 0e344f7..2b4a231 100644
--- a/lib/.gitignore
Thank you Ben!
Alin.
-Mesaj original-
De la: Ben Pfaff [mailto:b...@nicira.com]
Trimis: Wednesday, October 8, 2014 8:54 PM
Către: Nithin Raju
Cc: Alin Serdean; Lucian Petrut; dev@openvswitch.org; Lucian Petrut
Subiect: Re: [ovs-dev] [PATCH] Update the WMI Script handling Hyper-V
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Tested-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Thursday, October 9, 2014 12:22 AM
Către: dev@openvswitch.org; Alin Serdean
Cc: Nithin
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Tuesday, October 7, 2014 4:06 AM
Către: dev@openvswitch.org; Alin Serdean
Cc: Nithin Raju
Subiect: [PATCH] datapath-windows: Update OvsGetExtInfoIoctl
Functions such as OvsCreatePort are vague in regard to who creates it or
when. It wasn't a problem thus far, since the vports were created,
updated and destroyed from one place only (hyper-v switch part). But
now, with the netlink implementation of the vport commands, a part of
the vport is
Validation ports are used internally by the hyper-v switch to validate
and verify settings for the real hyper-v switch ports that will be
connected to the VNic. The validation ports are of no use to us - we
must skip handling them, and return STATUS_SUCCESS as the OID result.
Signed-off-by:
The fields externalVport and internalVport of the OVS_SWITCH_CONTEXT
struct are currently defined as PVOID. However, all over the code they
are used as POVS_VPORT_ENTRY. In order to improve clarity and reduce the
need for useless casts to POVS_VPORT_ENTRY, this patch changes the type
from PVOID to
The fields externalVport and internalVport of the OVS_SWITCH_CONTEXT
struct are currently defined as PVOID. However, all over the code they
are used as POVS_VPORT_ENTRY. In order to improve clarity and reduce the
need for useless casts to POVS_VPORT_ENTRY, this patch changes the type
from PVOID to
OvsGetVportNo computes a new port number. Therefore, OvsComputeVportNo
is a more clear name for what the function does. Reading OvsGetVportNo
may give the false impression that it returns the port number of an
existing vport.
Also, since the responsibility of assigning dp port numbers no longer
The field nameLink of the OVS_VPORT_ENTRY is the link within the
OVS_SWITCH_CONTEXT's hash array of vports nameHashArray, hashed by the
ovsName field of the OVS_VPORT_ENTRY.
Later on, the friendly name of the hyper-v switch port will need to be
set from userspace using WMI. This will require that
For this, the old method of finding vports based on the
ovs port numbers is removed. Now, the lookup of a vport
by ovs port number is done the same way as the lookup by
hyper-v switch port id.
This is done so that the kernel is able to interact with
the userspace correctly when using vport
The field portLink of the OVS_VPORT_ENTRY is the link within the
OVS_SWITCH_CONTEXT's hash array of vports portHashArray, hashed by the
portId field of the OVS_VPORT_ENTRY.
Later on, we will need to modify the OVS_VPORT_ENTRY so that its port
numbers are set to maximum MAXUINT16. This will
The port friendly name will be set by WMI / powershell script.
It will be used from within the netlink command vport new to
identify the hyper-v switch port it represents.
This patch also adds a function to lookup a vport by the
port friendly name.
Signed-off-by: Samuel Ghinet
Hi Nithin,
Yes I will reintroduce it.
I checked there are no compilation issues at the moment.
Thanks,
Alin.
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Thursday, October 9, 2014 4:40 AM
Către: Alin Serdean
Cc: dev@openvswitch.org; Samuel Ghinet
Subiect: Re
Sure.
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Thursday, October 9, 2014 4:44 AM
Către: Alin Serdean
Cc: dev@openvswitch.org; Samuel Ghinet
Subiect: Re: [ovs-dev] [PATCH 01/10] datapath-windows: Remove the old IOCTL
vport functions.
On Oct 8, 2014, at 6:42
The old IOCTL vport functions (using the non-netlink device) are no
longer needed. They should be removed.
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Co-authored-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
---
datapath-windows/ovsext/Vport.c | 276
I will respin the rest if they are ack.
Thanks,
Alin.
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Thursday, October 9, 2014 5:07 AM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev,01/10][PATCH v2] datapath-windows: Remove the old IOCTL
vport
source='lib/nx-match.c' object='lib/nx-match.lo' libtool=yes \
DEPDIR=.deps depmode=none /bin/sh ./build-aux/depcomp \
/bin/sh ./libtool --tag=CC --mode=compile ./build-aux/cccl
-DHAVE_CONFIG_H -I. -I ./include/windows -I ./datapath-windows/include
1 - 100 of 1132 matches
Mail list logo
