Re: [ovs-dev] Hitless resynchronisation of forwarding state

> On Jul 1, 2016, at 2:48 AM, Jan Scheurich wrote: > >>> Refreshing the 250K flow entries using the bundle mechanism increases >>> the vswitchd memory linearly up to 1.9 GB, significantly more than the 910 >>> MB one would expect for accommodating two versions of

Re: [ovs-dev] [PATCH v2 3/3] pvector: Expose non-concurrent priority vector.

> On Jul 22, 2016, at 2:51 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Wed, Jul 06, 2016 at 05:26:17AM -0700, Jarno Rajahalme wrote: >> PMD threads use pvectors but do not need the overhead of the >> concurrent version. Expose the non-concurrent version for >>

Re: [ovs-dev] [PATCH v2] tests: Ignore proxy configuration.

Thanks for the review, pushed to master. Jarno > On Jul 28, 2016, at 10:24 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Thu, Jul 28, 2016 at 05:29:44PM -0700, Jarno Rajahalme wrote: >> As any proxy configuration may ruin kernel testsuite tests, it is >> better to ign

Re: [ovs-dev] [PATCH 01/13] lib: Separate versioning to its own module.

> On Jul 26, 2016, at 11:08 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Fri, Jul 15, 2016 at 03:19:07AM -0700, Jarno Rajahalme wrote: >> Separate rule versioning to lib/versions.h to make it easier to use >> versioning for other data types. >> >> Signed

[ovs-dev] [PATCH v2 26/26] ofproto: Reduce bundle memory use.

. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/bundles.c | 2 +- ofproto/bundles.h | 4 +- ofproto/ofproto-provider.h | 43 +++- ofproto/ofproto.c | 570 + tests/ofproto.at | 4 - 5 files c

[ovs-dev] [PATCH v2 25/26] ofproto: Add 'command' to ofproto_flow_mod.

This helps releasing ofputil_flow_mod earlier in a later patch. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-provider.h | 1 + ofproto/ofproto.c | 9 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/ofproto/ofproto-provider.h b/o

[ovs-dev] [PATCH v2 24/26] ofproto: Add 'modify_cookie' to ofproto_flow_mod.

ofproto internally modifies 'modify_cookie' field, and adding a replica to ofproto_flow_mod allows the ofputil_flow_mod argument to be changed to a const. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif.c | 27 +-- ofproto/ofproto-prov

[ovs-dev] [PATCH v2 23/26] ofproto: Reduce dependency on ofputil_flow_mod after rule has been created.

One step towards the goal of removing the ofputil_flow_mod from the bundle message. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-provider.h | 7 + ofproto/ofproto.c | 68 ++ 2 files changed, 45 insertions(

[ovs-dev] [PATCH v2 21/26] ofproto: Support group mods in bundles.

uot;bundle" command that reads a file in which each line contains one flow mod or group mod, and then executes them all as a single atomic bundle transaction. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- NEWS| 7 +- include/openvswitch/ofp

[ovs-dev] [PATCH v2 22/26] ofp-util: remove flow mod's delete_reason.

We can use the rule's removed_reason instead. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- include/openvswitch/ofp-util.h | 3 --- lib/learn.c| 1 - lib/ofp-parse.c| 1 - lib/ofp-util.c | 4 ofproto/ofproto-dpif.c

[ovs-dev] [PATCH v2 16/26] meta-flow: Clean up masking with prerequisities checking.

the callers first check the prerequisites, while supplying 'wc' to mf_are_prereqs_ok(), and if successful, mask the bits of the field that were read or set using mf_mask_field_masked(). Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- include/openvswitch/meta-flow.h | 8 +--- lib/classi

[ovs-dev] [PATCH v2 15/26] meta-flow: Add mf_mask_field_masked().

Having a masked version allows generating better wildcarding. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- include/openvswitch/meta-flow.h | 4 +++- include/openvswitch/ofp-parse.h | 4 ++-- lib/dpctl.c | 4 ++-- lib/meta-flow.c

[ovs-dev] [PATCH v2 13/26] ofproto-dpif: Always forward 'used' from the old_rule.

t;Use classifier versioning.") Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif.c | 38 +++--- ofproto/ofproto-provider.h | 7 --- ofproto/ofproto.c | 9 + 3 files changed, 40 insertions(+), 14 deletions(-) diff

[ovs-dev] [PATCH v2 12/26] vconn: Better bundle error management.

the commit is sent, a barrier is required before sending the commit message. Finally, make vconn collect bundle errors into a list instead of calling a callback. This makes bundle error management simpler. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- include/openvswitch/vconn.h

[ovs-dev] [PATCH v2 18/26] ofp-util: Do not free() field that is not allocated.

Group properties field array is not dynamically allocated, so it should not be freed. This has not been a problem, as this function has not been called by anyone so far, but following patch will. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- lib/ofp-util.c | 1 - 1 file changed, 1 de

[ovs-dev] [PATCH v2 17/26] ofproto-dpif-xlate: Hash only fields specified for 'hash' selection method.

takes care of unwildcarding, we can simplify the code by hashing only the specified fields. Also change the test case to include fields that have prerequisities. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- include/openvswitch/meta-flow.h | 2 -- lib/meta-flow.c

[ovs-dev] [PATCH v2 19/26] ofproto: Use ofputil_uninit_group_mod().

Use ofputil_uninit_group_mod() instead of ofputil_bucket_list_destroy(). Currently these have the same effect, but this will change in a following patch. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- lib/ofp-parse.c | 6 +++--- lib/ofp-print.c | 4 ++-- ofproto/ofp

[ovs-dev] [PATCH v2 20/26] meta-flow: Compact struct field_array.

struct field_array is included in each ofgroup, but the current implementation is very sparse, using more than 20kb of data. Also loop over 1-bits instead of each and every MF type to make processing faster. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- include/openvswitch/meta-flow.

[ovs-dev] [PATCH v2 14/26] meta-flow: Add byte access to struct mf_value.

This allows reducing pointer casting when individual bytes of mf_value are accessed. First users are in the following patches. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- include/openvswitch/meta-flow.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/openvswitch/meta-fl

[ovs-dev] [PATCH v2 11/26] vconn: Update length of bundled messages.

, it will not be sent by itself, and we need to update the length explicitly instead. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- lib/ofp-util.c | 3 ++- lib/vconn.c| 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 6d73e69..06b48b8

[ovs-dev] [PATCH v2 05/26] ofproto: Use ofproto_mutex for groups and keep track of referring flows.

Adding groups support for bundles is simpler if also groups are modified under ofproto_mutex. Eliminate the search for rules when deleting a group so that we will not keep the mutex for too long. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- include/openvswitch/ofp-actions.h

[ovs-dev] [PATCH v2 08/26] ofproto: Report flow mods also from bundles.

Flow mod stats get skewed if they are not reported from bundles. Move reporting to ofproto_flow_mod_finish() so that it will be done in all cases. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff

[ovs-dev] [PATCH v2 06/26] ofproto: Add generic ofproto_collection.

Define rule_collection in terms of a new ofproto_collection. This makes it easier to add other types of collections later. This patch makes no functional changes. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-provider.h | 112 ++--- ofproto/ofp

[ovs-dev] [PATCH v2 10/26] ofproto: Make groups versioned.

This is a prepatory step for adding group mod support for bundles in a following patch. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 5 +- ofproto/ofproto-dpif.c | 4 +- ofproto/ofproto-dpif.h | 3 +- ofproto/ofproto-provider.h

[ovs-dev] [PATCH v2 09/26] ofproto: refactor group mods.

This changes ofproto providers modify_group() to never fail. Separating major refactoring to a separate patch should make following patches easier to review. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif.c | 4 +- ofproto/ofproto-provider.h | 27 +++- o

[ovs-dev] [PATCH v2 07/26] ofproto: Generalize flow_mod_requester.

Group mods also need a 'requester', so rename 'flow_mod_requester' as 'openflow_mod_requester'. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto.c | 50 -- 1 file changed, 24 insertions(+), 26 deletions(-) diff --git a/o

[ovs-dev] [PATCH v2 04/26] ofproto: Make flow handling more symmetric.

references to the referring flows. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 83fe3a1..83719a5 100644 --- a/ofproto/ofproto.c +++ b/o

[ovs-dev] [PATCH v2 02/26] ofproto: Lockless group lookups.

Make groups RCU protected and make group lookups lockless. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 22 +++--- ofproto/ofproto-dpif.c | 27 +++ ofproto/ofproto-dpif.h | 7 +- ofproto/ofproto-provider.h | 12 ++-- ofproto/ofp

[ovs-dev] [PATCH v2 01/26] lib: Separate versioning to its own module.

Separate rule versioning to lib/versions.h to make it easier to use versioning for other data types. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- lib/automake.mk | 1 + lib/classifier-private.h | 31 +-- lib/classifier.c

[ovs-dev] [PATCH v2 03/26] ofproto: Take group references only when needed.

Avoid unnecessary references when RCU protection suffices. This makes group lookup memory management more like flow lookup memory management. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 22 +- ofproto/ofproto-dpif.c

[ovs-dev] [PATCH v2 00/26] Support groups in bundles.

in the ofputil_flow_mod. - We failed to report the counts of flow mods from bundles. Jarno Rajahalme (26): lib: Separate versioning to its own module. ofproto: Lockless group lookups. ofproto: Take group references only when needed. ofproto: Make flow handling more symmetric. ofproto: Use

[ovs-dev] [PATCH v2] tests: Ignore proxy configuration.

As any proxy configuration may ruin kernel testsuite tests, it is better to ignore all proxy configuration. Suggested-by: Ben Pfaff <b...@ovn.org> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- tests/atlocal.in| 10 ++ tests/system-traffic.at | 8 2 f

Re: [ovs-dev] [PATCH 1/2] tests: Ignore proxy configuration in kernel testsuite.

> On Jul 14, 2016, at 17:32, Ben Pfaff <b...@ovn.org> wrote: > >> On Thu, Jul 14, 2016 at 03:07:21AM -0700, Jarno Rajahalme wrote: >> >>> On Jul 13, 2016, at 9:36 PM, Ben Pfaff <b...@ovn.org> wrote: >>> >>> On Wed, Jul 06, 2016 at 06:0

Re: [ovs-dev] [PATCHv2 2/2] tunneling: get skb marking to work properly with tunnels

I already tested and pushed these to master. Jarno > On Jul 22, 2016, at 05:28, Ansis Atteka <ansisatt...@gmail.com> wrote: > > On Jul 21, 2016 2:08 PM, "Jarno Rajahalme" <ja...@ovn.org> wrote: > > > > Looks good to me: > > > > Acked-b

[ovs-dev] [PATCH] tests: Make ovsdb test more robust and faster.

. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- tests/ovsdb-server.at | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at index 2f2ef99..baf253a 100644 --- a/tests/ovsdb-server.at +++ b/tests/ovsdb-server.at @@ -1213,7 +

Re: [ovs-dev] [PATCH 3/3] system-traffic: Fix up FTP tests.

For the series: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jul 19, 2016, at 12:54 PM, Joe Stringer <j...@ovn.org> wrote: > > Prior to commit b87a5aacefe2 ("datapath: Fix cached ct with helper."), > we were relying on automatic helpers to ensure that FTP co

Re: [ovs-dev] [PATCHv2 2/2] tunneling: get skb marking to work properly with tunnels

Looks good to me: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jul 19, 2016, at 2:25 PM, Ansis Atteka <aatt...@ovn.org> wrote: > > There are two issues that this patch fixes: > 1. it was impossible to set skb mark at all through > NXM_NX_PKT_MARK register

[ovs-dev] [PATCH 09/13] ofproto: refactor group mods.

This changes ofproto providers modify_group() to never fail. Separating major refactoring to a separate patch should make following patches easier to review. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif.c | 4 +- ofproto/ofproto-provider.h | 27 +++- o

[ovs-dev] [PATCH 10/13] ofproto: Make groups versioned.

This is a prepatory step for adding group mod support for bundles in a following patch. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 5 +- ofproto/ofproto-dpif.c | 4 +- ofproto/ofproto-dpif.h | 3 +- ofproto/ofproto-provider.h

[ovs-dev] [PATCH 13/13] ofproto: Support group mods in bundles.

uot;bundle" command that reads a file in which each line contains one flow mod or group mod, and then executes them all as a single atomic bundle transaction. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- NEWS| 7 +- include/openvswitch/ofp

[ovs-dev] [PATCH 12/13] ovs-ofctl: Fail if bundle errors are received.

It is possible that a bundle add message fails, but the following commit succeeds, since the message was not added to the bundle. Make ovs-ofctl fail also in these cases. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- utilities/ovs-ofctl.c | 13 +++-- 1 file changed, 11 inse

[ovs-dev] [PATCH 11/13] vconn: Update length of bundled messages.

, it will not be sent by itself, and we need to update the length explicitly instead. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- lib/ofp-util.c | 3 ++- lib/vconn.c| 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 4ae83df..40fd2b1

[ovs-dev] [PATCH 06/13] ofproto: Add generic ofproto_collection.

Define rule_collection in terms of a new ofproto_collection. This makes it easier to add other types of collections later. This patch makes no functional changes. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-provider.h | 112 ++--- ofproto/ofp

[ovs-dev] [PATCH 08/13] ofproto: Report flow mods also from bundles.

Flow mod stats get skewed if they are not reported from bundles. Move reporting to ofproto_flow_mod_finish() so that it will be done in all cases. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff

[ovs-dev] [PATCH 07/13] ofproto: Generalize flow_mod_requester.

Group mods also need a 'requester', so rename 'flow_mod_requester' as 'openflow_mod_requester'. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto.c | 50 -- 1 file changed, 24 insertions(+), 26 deletions(-) diff --git a/o

[ovs-dev] [PATCH 04/13] ofproto: Make flow handling more symmetric.

references to the referring flows. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 9173376..e9f7a98 100644 --- a/ofproto/ofproto.c +++ b/o

[ovs-dev] [PATCH 03/13] ofproto: Take group references only when needed.

Avoid unnecessary references when RCU protection suffices. This makes group lookup memory management more like flow lookup memory management. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 22 +- ofproto/ofproto-dpif.c

[ovs-dev] [PATCH 02/13] ofproto: Lockless group lookups.

Make groups RCU protected and make group lookups lockless. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 22 +++--- ofproto/ofproto-dpif.c | 27 +++ ofproto/ofproto-dpif.h | 7 +- ofproto/ofproto-provider.h | 12 ++-- ofproto/ofp

[ovs-dev] [PATCH 05/13] ofproto: Use ofproto_mutex for groups and keep track of referring flows.

Adding groups support for bundles is simpler if also groups are modified under ofproto_mutex. Eliminate the search for rules when deleting a group so that we will not keep the mutex for too long. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif.c | 2 +- o

[ovs-dev] [PATCH 01/13] lib: Separate versioning to its own module.

Separate rule versioning to lib/versions.h to make it easier to use versioning for other data types. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- lib/automake.mk | 1 + lib/classifier-private.h | 31 +++-- lib/classifier.c

Re: [ovs-dev] [PATCH 1/2] tests: Ignore proxy configuration in kernel testsuite.

> On Jul 13, 2016, at 9:36 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Wed, Jul 06, 2016 at 06:02:45AM -0700, Jarno Rajahalme wrote: >> >>> On Jul 1, 2016, at 8:30 PM, Ben Pfaff <b...@ovn.org> wrote: >>> >>> On Tue, Jun 21, 2016 at 09:57:

Re: [ovs-dev] [PATCH 5/5] ofp-actions: Remove XXX comment for write-actions in ofpacts_format().

Does not ring a bell either! Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jul 13, 2016, at 5:06 PM, Ben Pfaff <b...@ovn.org> wrote: > > I don't know why this was here. The write_actions instruction works fine. > > Signed-off-by: Ben Pfaff <b...@ovn.org> &g

Re: [ovs-dev] [PATCH 4/5] ofp-actions: Translate OF1.1+ mod_nw_ttl action to OF1.0 properly.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jul 13, 2016, at 5:06 PM, Ben Pfaff <b...@ovn.org> wrote: > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > NEWS | 4 ++-- > lib/ofp-actions.c| 4 +++- > tests/ofp-actions.at | 18 +

Re: [ovs-dev] [PATCH 3/5] ofp-actions: Translate mod_nw_ecn action to OF1.1 properly.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jul 13, 2016, at 5:06 PM, Ben Pfaff <b...@ovn.org> wrote: > > Also, translate OF1.2+ "set_field" on OXM_OF_IP_ECN properly to OF1.1 > "mod_nw_ecn". > > Signed-off-by: Ben Pfaff <b...@ovn

Re: [ovs-dev] [PATCH 2/5] ofp-actions: Translate OF1.0 "enqueue" actions for OF1.1+.

With a small question below: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jul 13, 2016, at 5:06 PM, Ben Pfaff <b...@ovn.org> wrote: > > Previously, the OF1.0 "enqueue" action was simply omitted when actions > were translated into OpenFlow 1.1 or later, wh

Re: [ovs-dev] [PATCH 1/5] ofp-actions: Add extension to support "group" action in OF1.0.

That was surprisingly small change; speaks for all the infra you have built in here! Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jul 13, 2016, at 5:06 PM, Ben Pfaff <b...@ovn.org> wrote: > > From time to time it confuses users that "group" actions disa

Re: [ovs-dev] [PATCH] ofproto: ofp_packet_out messages in bundles

fills them. > The caller can then invoke ofproto_class->packet_out() passing the args that > were filled. > > Jarno Rajahalme <ja...@ovn.org <mailto:ja...@ovn.org>> escreveu no dia > quarta, 29/06/2016 às 12:36: > > > On Jun 23, 2016, at 4:51 AM, Andre Mantas &

Re: [ovs-dev] [PATCH 1/2] tests: Ignore proxy configuration in kernel testsuite.

> On Jul 1, 2016, at 8:30 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Tue, Jun 21, 2016 at 09:57:15AM -0700, Jarno Rajahalme wrote: >> Add '--noproxy' parameter to 'wget' so that the test cases do not try >> to use a proxy that may be configured in the test env

Re: [ovs-dev] [PATCH] pvector: Expose non-concurrent priority vector.

Thanks for the review! > On Jul 1, 2016, at 9:08 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Tue, Jun 21, 2016 at 05:18:45PM -0700, Jarno Rajahalme wrote: >> PMD threads use pvectors but do not need the overhead of the >> concurrent version. Expose the inte

[ovs-dev] [PATCH v2 2/3] pvector: Get rid of special purpose of INT_MIN.

Allow clients to use the whole priority range. Note that this changes the semantics of PVECTOR_FOR_EACH_PRIORITY so that the iteration still continues for entries at the given priority. Suggested-by: Ben Pfaff <b...@ovn.org> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- lib/

[ovs-dev] [PATCH v2 3/3] pvector: Expose non-concurrent priority vector.

-by: Jarno Rajahalme <ja...@ovn.org> --- lib/classifier.c| 30 lib/classifier.h| 6 +- lib/dpif-netdev.c | 14 ++-- lib/pvector.c | 190 +--- lib/pvector.h

[ovs-dev] [PATCH v2 1/3] pvector: Move PVECTOR_EXTRA_ALLOC to pvector.c.

There is no need to expose PVECTOR_EXTRA_ALLOC in the API. Suggested-by: Ben Pfaff <b...@ovn.org> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- lib/pvector.c | 6 +- lib/pvector.h | 6 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/pvector.c b/l

Re: [ovs-dev] download patches nat support?

The referred patches have been merged to Linux 4.6 and backported to OVS master git repo, so you do not need to apply those patches manually any more. Jarno > On Jul 5, 2016, at 2:16 AM, Cristina Palomo Regidor > wrote: > > > > Hello, > I would like

Re: [ovs-dev] [PATCH 2/2] ovs-ofctl: Clarify CT action documentation.

Thanks for the review, pushed to master, Jarno > On Jul 1, 2016, at 8:31 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Tue, Jun 21, 2016 at 09:57:16AM -0700, Jarno Rajahalme wrote: >> Since the 'commit' flag is required to set the mark and/or labels, the >> set

Re: [ovs-dev] [PATCH branch-2.5 2/2] datapath: Only set mark and labels with a commit flag.

With a small nit below: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jul 1, 2016, at 11:37 AM, Pravin B Shelar <pshe...@ovn.org> wrote: > > Upstream commit: >commit 7d904c7bcd51f72579c0c3134a50896c5a3efb9f >Author: Jarno Rajahalme <ja...@ovn.org> >

Re: [ovs-dev] [PATCH branch-2.5 1/2] datapath: backport: Set mark and labels before confirming.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jul 1, 2016, at 11:37 AM, Pravin B Shelar <pshe...@ovn.org> wrote: > > Upstream commit: >commit 1c1779fa54b2a9d4e1de990095d790d64b9e00a1 >Author: Jarno Rajahalme <ja...@ovn.org> >Date: Tue Jun 21 14:

Re: [ovs-dev] [RFC Patch] dpif-netdev: dpcls per in_port with sorted subtables

I like this RFC patch and suggest you send a non-RFC patch after taking care of the following: - There are numerous coding style violations. I've done my best to note them below, but you should also read 'CodingStyle.md'. - The subject line should have 'Patch' in all upper-case and have the

Re: [ovs-dev] [PATCH v2 19/24] datapath: backport: udp_offload: Set encapsulation before inner completes.

it: >commit 229740c63169462a838a8b8e16391ed000934631 >Author: Jarno Rajahalme <ja...@ovn.org> > >udp_offload: Set encapsulation before inner completes. > >UDP tunnel segmentation code relies on the inner offsets being set for >an UDP tunnel GSO packet, but the

Re: [ovs-dev] [PATCH v3] dpif-netdev: Remove PMD latency on seq_mutex

> On Jun 29, 2016, at 4:58 PM, Flavio Leitner <f...@redhat.com> wrote: > > On Wed, Jun 29, 2016 at 05:04:06AM -0700, Jarno Rajahalme wrote: >> >>> On Jun 23, 2016, at 11:40 AM, Flavio Leitner <f...@redhat.com> wrote: >>> ... > >>> + &g

Re: [ovs-dev] Hitless resynchronisation of forwarding state

> On Jun 28, 2016, at 9:17 AM, Jan Scheurich wrote: > > Hi, > > We would like to resume our earlier discussion about how to support a simple, > generic and efficient procedure for controllers to resync all OF forwarding > state with OVS after a reconnect while

[ovs-dev] [PATCH 1/2] datapath: Set mark and labels before confirming.

Upstream commit: commit 1c1779fa54b2a9d4e1de990095d790d64b9e00a1 Author: Jarno Rajahalme <ja...@ovn.org> Date: Tue Jun 21 14:59:37 2016 -0700 openvswitch: Set mark and labels before confirming. Set conntrack mark and labels right before committing so that the i

[ovs-dev] [PATCH 2/2] datapath: Only set mark and labels with a commit flag.

Upstream commit: commit 7d904c7bcd51f72579c0c3134a50896c5a3efb9f Author: Jarno Rajahalme <ja...@ovn.org> Date: Tue Jun 21 14:59:38 2016 -0700 openvswitch: Only set mark and labels with a commit flag. Only set conntrack mark or labels when the commit flag is spe

Re: [ovs-dev] [PATCH v3] dpif-netdev: Remove PMD latency on seq_mutex

> On Jun 23, 2016, at 11:40 AM, Flavio Leitner wrote: > > The PMD thread needs to keep processing RX queues in order > to achieve maximum throughput. It also needs to sweep emc > cache and quiesce which use seq_mutex. That mutex can > eventually block the PMD thread causing

Re: [ovs-dev] [PATCH] ofproto: ofp_packet_out messages in bundles

> On Jun 23, 2016, at 4:51 AM, Andre Mantas wrote: > > This patch allows ofp_packet_out messages to be added to bundles. In a > multi controller scenario, packet_out messages inside bundles can serve > as a commit_reply for other controllers - since the original

Re: [ovs-dev] [RFC Patch] dpif-netdev: Sorted subtable vectors per in_port in dpcls

> On Jun 23, 2016, at 2:51 AM, Jan Scheurich wrote: > >> This no longer applies cleanly, and I also needed to add this incremental to >> make the testsuite pass: > > I will rebase and adapt the tests as suggested in the next version. > >> Did you consider keeping a

Re: [ovs-dev] [PATCH 4/4] system-traffic: Remove basic connectivity tests.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jun 22, 2016, at 6:00 PM, Joe Stringer <j...@ovn.org> wrote: > > For many of the tests, we would first execute a "basic connectivity > check" to validate the sanity of the setup before running the test > traffic

Re: [ovs-dev] [PATCH 1/4] datapath: Pass net into ovs_fragment.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jun 22, 2016, at 6:00 PM, Joe Stringer <j...@ovn.org> wrote: > > From: "Eric W. Biederman" <ebied...@xmission.com> > > Upstream commit: >openvswitch: Pass net into ovs_fragment > >In

Re: [ovs-dev] [RFC Patch] dpif-netdev: Sorted subtable vectors per in_port in dpcls

t; sorts the vectors according to match frequency every second. > Also, it should be possible to expand the pvector API to allow using the pvector priorities directly as the counts. I posted a patch for this (https://patchwork.ozlabs.org/patch/638920/), after which you could apply the follow

[ovs-dev] [PATCH] pvector: Expose non-concurrent priority vector.

PMD threads use pvectors but do not need the overhead of the concurrent version. Expose the internal non-concurrent version for that use. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- lib/pvector.c | 71 +++ lib/pvector.

Re: [ovs-dev] [PATCH net-next] openvswitch: Only set mark and labels when commiting a connection.

Thanks for the review! > On Jun 21, 2016, at 1:57 PM, Joe Stringer <j...@ovn.org> wrote: > > On 20 June 2016 at 17:19, Jarno Rajahalme <ja...@ovn.org> wrote: >> Only allow setting conntrack mark or labels when the commit flag is >> specified. This make

[ovs-dev] [RFC PATCH net v2 2/2] openvswitch: Only set mark and labels with a commit flag.

ct_mark and/or ct_labels. Validate for this in the kernel API. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- net/openvswitch/conntrack.c | 76 ++--- 1 file changed, 51 insertions(+), 25 deletions(-) diff --git a/net/openvswitch/conntrack.c

[ovs-dev] [PATCH net v2 1/2] openvswitch: Set mark and labels before confirming.

Set conntrack mark and labels right before committing so that the initial conntrack NEW event has the mark and labels. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- v2: Separate Kernel API change to an RFC patch (2/2). net/openvswitch/conntrack.c | 33 ++

Re: [ovs-dev] [PATCH] tun-metadata: Use correct offset when accessing fragmented metadata.

[Google filtered by ack as spam, so I'm trying again.] Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jun 9, 2016, at 11:50 AM, Jesse Gross <je...@kernel.org> wrote: > > Since tunnel metadata is stored in a fixed area in the flow match field, we > must al

[ovs-dev] [PATCH 2/2] ovs-ofctl: Clarify CT action documentation.

Since the 'commit' flag is required to set the mark and/or labels, the set values are always available for following lookups. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- utilities/ovs-ofctl.8.in | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/uti

[ovs-dev] [PATCH 1/2] tests: Ignore proxy configuration in kernel testsuite.

Add '--noproxy' parameter to 'wget' so that the test cases do not try to use a proxy that may be configured in the test environment. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- tests/system-traffic.at | 102 1 file changed, 51 inse

Re: [ovs-dev] [PATCH 2/2] ofproto: Set to revalidate when a new version is available.

Thanks for the review, pushed to master with the suggested changes. Jarno > On May 6, 2016, at 2:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Wed, May 04, 2016 at 01:08:13PM -0700, Jarno Rajahalme wrote: >> There is no need to set the revalidate flag after each flow mod

Re: [ovs-dev] [PATCH v3 00/18] datapath: NAT backports.

Thanks for the reviews, series pushed to master. Jarno > On Jun 20, 2016, at 6:48 PM, Jesse Gross <je...@kernel.org> wrote: > > On Fri, Jun 17, 2016 at 6:44 PM, Jarno Rajahalme <ja...@ovn.org> wrote: >> This series adds the conntrack NAT integration upstreamed in L

Re: [ovs-dev] [PATCH net-next] openvswitch: Only set mark and labels when commiting a connection.

The title should have been: openvswitch: Only set mark and labels with a commit flag. This reflects the fact that modifying the mark and/or labels of an existing connection is allowed. The commit flag is still required to do that, though. Jarno > On Jun 20, 2016, at 5:19 PM, Jarno Rajaha

[ovs-dev] [PATCH net-next] openvswitch: Only set mark and labels when commiting a connection.

to accept setting ct_mark and/or ct_labels. Validate for this on the kernel API. Finally, set conntrack mark and labels right before committing so that the initial conntrack NEW event has the mark and labels. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- net/openvswitch/conntrack.

Re: [ovs-dev] [PATCH v3 11/18] datapath: conntrack NAT helper compat code for Linux 4.5 and earlier.

Thanks for the review Jesse, responses below: > On Jun 20, 2016, at 2:39 PM, Jesse Gross <je...@kernel.org> wrote: > > On Fri, Jun 17, 2016 at 6:44 PM, Jarno Rajahalme <ja...@ovn.org> wrote: >> diff --git a/datapath/conntrack.c b/datapath/conntrack.c >&

[ovs-dev] [PATCH v3 18/18] datapath: Fix cached ct with helper.

ion") Signed-off-by: Joe Stringer <j...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Fixes: 11251c170d92 ("datapath: Allow attaching helpers to ct action") Signed-off-by: Jarno Raj

[ovs-dev] [PATCH v3 17/18] datapath: __nf_ct_l{3, 4}proto_find() always return a valid pointer

alid pointer If the protocol is not natively supported, this assigns generic protocol tracker so we can always assume a valid pointer after these calls. Signed-off-by: Pablo Neira Ayuso <pa...@netfilter.org> Acked-by: Jarno Rajahalme <jrajaha...@nicira.com> Acked-by: Jo

[ovs-dev] [PATCH v3 15/18] datapath: call only into reachable nf-nat code

f-by: Pablo Neira Ayuso <pa...@netfilter.org> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Fixes: c5f6c06b58d6 ("datapath: Interface with NAT.") Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/conntrack.c | 16 1 file changed, 8 ins

[ovs-dev] [PATCH v3 16/18] datapath: change nf_connlabels_get bit arg to 'highest used'

org> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> OVS compat code defined nf_connlabels_get() if it was missing. Now we redefine it if it is missing, or if it has the old signature. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- acinclude.m4

[ovs-dev] [PATCH v3 14/18] datapath: Fix checking for new expected connections.

Upstream commit: commit 5745b0be05a0f8ccbc92a36b69f3a6bc58e91954 Author: Jarno Rajahalme <ja...@ovn.org> Date: Mon Mar 21 11:15:19 2016 -0700 openvswitch: Fix checking for new expected connections. OVS should call into CT NAT for packets of new expected connection

[ovs-dev] [PATCH v3 06/18] datapath: Update the CT state key only after nf_conntrack_in().

Upstream commit: commit 394e910e909b174270b8231fd51942eb2f541fb9 Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Mar 10 10:54:19 2016 -0800 openvswitch: Update the CT state key only after nf_conntrack_in(). Only a successful nf_conntrack_in() call can effect a conn

[ovs-dev] [PATCH v3 08/18] datapath: Handle NF_REPEAT in conntrack action.

Upstream commit: commit 5b6b929376a621e2bd3367f5de563d7123506597 Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Mar 10 10:54:21 2016 -0800 openvswitch: Handle NF_REPEAT in conntrack action. Repeat the nf_conntrack_in() call when it returns NF_REPEAT. This

[ovs-dev] [PATCH v3 12/18] datapath: conntrack NF_NAT_RANGE_PROTO_RANDOM_FULLY compat code.

Linux kernel 3.13 and older do not have NF_NAT_RANGE_PROTO_RANDOM_FULLY (unless backported by the distribution). Silently fall back to NF_NAT_RANGE_PROTO_RANDOM to maintain OVS API compatibility. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/conntrack.c | 12 +++-

[ovs-dev] [PATCH v3 13/18] datapath: Use proper buffer size in nla_memcpy

gt; Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Fixes: c5f6c06b58d6 ("datapath: Interface with NAT.") Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/conntrack.c | 3 ++- 1 file changed, 2 inser

[ovs-dev] [PATCH v3 11/18] datapath: conntrack NAT helper compat code for Linux 4.5 and earlier.

Upstream commit: commit 264619055bd52bc2278af848472176642d759874 Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Mar 10 10:54:17 2016 -0800 netfilter: Allow calling into nat helper without skb_dst. NAT checksum recalculation code assumes existence of skb_dst,

<    1   2   3   4   5   6   7   8   9   10   >