[ovs-dev] Possible debug improvement in datapath/actions.c (do_output)

2014-12-08 Thread Sabyasachi Sengupta
Looking at do_output, it appears that we silently drop a packet if a bad out_port was specified because vport will be NULL from ovs_vport_rcu and we just free the skb and return from thereon. Instead, an ideal behavior should be to log this in user space via log_execute_message and also

Re: [ovs-dev] format_uint32_masked call for printing reg value in match_format

2015-01-23 Thread Sabyasachi Sengupta
Yes, just wondering about the flow parsing scripts out there that may be break.. On Fri, 23 Jan 2015, Ben Pfaff wrote: On Fri, Jan 23, 2015 at 02:52:46PM -0800, Sabyasachi Sengupta wrote: I see that in ovs-2.3 onwards, we use format_uint32_masked from match_format for printing register

[ovs-dev] format_uint32_masked call for printing reg value in match_format

2015-01-23 Thread Sabyasachi Sengupta
Hi, I see that in ovs-2.3 onwards, we use format_uint32_masked from match_format for printing register values. While use of format_uint32_masked for printing recirc_id, dp_hash and pkt_mark are fine, register values can have a legit value of 0. As format_uint32_masked uses %#x, we may end up

[ovs-dev] possible issue about sending BFD packet?

2015-02-03 Thread Sabyasachi Sengupta
Hi, I'm trying to set up BFD between two vlans created on different bridges running on different hosts. I noticed that unless bfd:bfd_remote_dst_mac is specified while setting up the BFD, the packet never leaves the host switch due to skipping output to input port. Looking at RFC 5880/5881,

Re: [ovs-dev] possible issue about sending BFD packet?

2015-02-03 Thread Sabyasachi Sengupta
. the bfd_remote_dst_mac construct). Am I missing something here? On Tue, 3 Feb 2015, Alex Wang wrote: Hey, On Tue, Feb 3, 2015 at 2:19 PM, Sabyasachi Sengupta sabyasachi.sengu...@alcatel-lucent.com wrote: Hi, I'm trying to set up BFD between two vlans created on different bridges

[ovs-dev] Possible memory leak in bundle_destroy?

2015-01-21 Thread Sabyasachi Sengupta
Hi, I saw that bundle_destroy calls mbridge_unregister_bundle with bundle-aux. However the second parameter of mbridge_unregister_bundle is ofbundle. When creating the bundle in mbridge_bundle_register, we setup mbundle using ofbundle. Shouldn't the call to unregister be just ofbundle

[ovs-dev] question about availability of Centos 7.1 kernel support

2015-03-30 Thread Sabyasachi Sengupta
Hi, Can anyone please let me know if Centos 7.1 (3.10.0-229) kernel supported in master branch? I'm currently based off branch-2.3. If this is already available, what would be the commit hash(es) to be picked up? Thanks, Sabya ___ dev mailing list

Re: [ovs-dev] question about availability of Centos 7.1 kernel support

2015-04-01 Thread Sabyasachi Sengupta
: 1127, Ph: 1-650-623-3461 On Wed, 1 Apr 2015, Ben Pfaff wrote: Does it build? Then I imagine it's supported. On Wed, Apr 01, 2015 at 01:44:41PM -0700, Sabyasachi Sengupta wrote: Can anyone respond to this question? I can provide a patch for enabling the 3.10.229 kernel (backported from native

Re: [ovs-dev] question about availability of Centos 7.1 kernel support

2015-04-02 Thread Sabyasachi Sengupta
. On Wed, Apr 01, 2015 at 04:46:54PM -0700, Sabyasachi Sengupta wrote: ovs from master branch off github does not build in C7.1. There are quite a few errors in datapath directory, was hoping if a patch was already available. Probably no one tried it yet? --- Nuage Networks Business Unit, Alcatel-Lucent

Re: [ovs-dev] question about availability of Centos 7.1 kernel support

2015-04-03 Thread Sabyasachi Sengupta
not certify any version of OVS for any purpose. If you wish to have a certified version of OVS, you will have to obtain that certification elsewhere. On Fri, Apr 03, 2015 at 06:02:51PM -0700, Sabyasachi Sengupta wrote: Well, the last released version of ovs-2.3.1 was in Dec/03/2014 (per NEWS

Re: [ovs-dev] question about availability of Centos 7.1 kernel support

2015-04-03 Thread Sabyasachi Sengupta
Well, the last released version of ovs-2.3.1 was in Dec/03/2014 (per NEWS) and there is no formal plan discussed about ovs-2.4 in any of the mailing lists. I see there is ovs-2.3.2 documented in NEWS with xxx suggesting there will be a release sometime in future. Unless there is a certified

Re: [ovs-dev] question about availability of Centos 7.1 kernel support

2015-04-01 Thread Sabyasachi Sengupta
Can anyone respond to this question? I can provide a patch for enabling the 3.10.229 kernel (backported from native Linux) if one is not already available.. On Mon, 30 Mar 2015, Sabyasachi Sengupta wrote: Hi, Can anyone please let me know if Centos 7.1 (3.10.0-229) kernel supported

[ovs-dev] [PATCH] ofproto-dpif: Use xzalloc instead of xmalloc

2015-06-05 Thread Sabyasachi Sengupta
Use xzalloc instead of xmalloc for some key structure allocations in ofproto-dpif (viz. ofproto_dpif, ofport_dpif and rule_dpif) so as to prevent uninitialized values in these structures. Also add seat belts around these structure allocations. Signed-off-by: Sabyasachi Sengupta sabyasachi.sengu

[ovs-dev] [PATCH v2] ofproto-dpif: Use xzalloc instead of xmalloc

2015-06-05 Thread Sabyasachi Sengupta
Use xzalloc instead of xmalloc for some key structure allocations in ofproto-dpif (viz. ofproto_dpif, ofport_dpif and rule_dpif) so as to prevent uninitialized values in these structures. Signed-off-by: Sabyasachi Sengupta sabyasachi.sengu...@alcatel-lucent.com --- diff --git a/ofproto

Re: [ovs-dev] [PATCH] ofproto-dpif: Use xzalloc instead of xmalloc

2015-06-05 Thread Sabyasachi Sengupta
05, 2015 at 10:48:30AM -0700, Sabyasachi Sengupta wrote: Use xzalloc instead of xmalloc for some key structure allocations in ofproto-dpif (viz. ofproto_dpif, ofport_dpif and rule_dpif) so as to prevent uninitialized values in these structures. Also add seat belts around these structure allocations

[ovs-dev] [PATCH]: bfd: display last wall clock time of last flap

2015-06-23 Thread Sabyasachi Sengupta
Extend bfd to save wall clock time of the last flap in bfd_forwarding__, and display it throught bfd/show. This information is also exported out to ovsdb in bfd_get_status. Signed-off-by: Sabyasachi Sengupta sabyasachi.sengu...@alcatel-lucent.com diff --git a/lib/bfd.c b/lib/bfd.c index

Re: [ovs-dev] [PATCH]: bfd: display last wall clock time of last flap

2015-06-25 Thread Sabyasachi Sengupta
It's much easier for a script to parse a number than a date. Well, I tried to use time_msec instead of time_wall_msec() in an attempt to see how the output would look like. To me, the original proposal of printing wall clock time -- [root@rtr-29-225-196-232 ~]# ovs-appctl bfd/show

Re: [ovs-dev] [PATCH]: bfd: display last wall clock time of last flap

2015-06-24 Thread Sabyasachi Sengupta
Hi Ben, It's a little unconventional for us to use a wall clock time for this. I'd be more inclined to report it as N seconds ago or N ms ago. Any particular reason to use a wall clock time? I've seen that all BFD other outputs use now -/+ convention, but just that I thought wall clock

[ovs-dev] [PATCH]: ovsdb: add capability to dump table content in ovsdb-client

2015-06-26 Thread Sabyasachi Sengupta
. Signed-off-by: Sabyasachi Sengupta sabyasachi.sengu...@alcatel-lucent.com --- ovsdb/ovsdb-client.c | 105 +- 1 files changed, 69 insertions(+), 36 deletions(-) diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c index 2942953..84474d0 100644

[ovs-dev] [PATCH]: ovs-ctl: let openvswitch startup to NOT hold up system boot upon error

2015-06-11 Thread Sabyasachi Sengupta
) and system remained in hung state forever, unless manually rebooted from console. Signed-off-by: Sabyasachi Sengupta sabyasachi.sengu...@alcatel-lucent.com --- diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in index 97716e9..449e715 100755 --- a/utilities/ovs-ctl.in +++ b/utilities/ovs-ctl.in

Re: [ovs-dev] [PATCH]: ovs-ctl: let openvswitch startup to NOT hold up system boot upon error

2015-06-15 Thread Sabyasachi Sengupta
Can this patch be considered? We keep hitting it in our data center where a number of fresh installed EL7 hosts fail to boot up due to default selinux permissions, but ovs should not prevent the system to bootup to multiuser.. On Thu, 11 Jun 2015, Sabyasachi Sengupta wrote: Abort

Re: [ovs-dev] [PATCH v2]: ovsdb: add capability to dump table content in ovsdb-client

2015-06-30 Thread Sabyasachi Sengupta
It seems we just need to extract the text between the table name and the first blank line below it. this should pretty easy with either awk or sed. As for efficiency, the db files I have access to are sufficiently small that the script should work in practise, especially used only for

[ovs-dev] [PATCH v2]: ovsdb: add capability to dump table content in ovsdb-client

2015-06-30 Thread Sabyasachi Sengupta
a transaction only for that table instead of all, and then print the response for that transaction. Signed-off-by: Sabyasachi Sengupta sabyasachi.sengu...@alcatel-lucent.com --- ovsdb/ovsdb-client.c | 105 +- 1 files changed, 69 insertions(+), 36

[ovs-dev] issue with ovs_rcu corrupted cbset

2015-07-29 Thread Sabyasachi Sengupta
We recently came across a case where ovs trips due to a bad function pointer because of a possible corruption in ovs rcu cbset. This typically happens if we have 100+ VMs with ~1000 flows. (gdb) p *cbset $16 = {list_node = {prev = 0x7f69c0e77b70, next = 0x208f730}, cbs = {{ function =

Re: [ovs-dev] [PATCH] Fix extract_ofp_msgs to use HMAP_NODE_NULL_INITIALIZER instead of hard-coding {0, NULL} while creating _instances[] arrays

2015-10-13 Thread Sabyasachi Sengupta
13, 2015 at 06:38:57PM -0700, Sabyasachi Sengupta wrote: This change will cause segfaults if anything ever reaches the end of a bucket. Oh, didn't realize that, but it seems to work fine in my setup. Just wondering how it works while initializing all_raw_instances. I'm curious how would

[ovs-dev] openvswitch 2.4: HAVE_RHEL_OVS_HOOK on 2.6.32-573.3.1.el6.x86_64

2015-10-19 Thread Sabyasachi Sengupta
Hi, I'm facing issues in recompiling openvswitch with --with-linux on Centos 6.7 that runs 2.6.32-573.3.1.el6.x86_64 kernel. Below is the error: CC [M] /home/sabyasse/Linux/src/sandbox/ovs/datapath/linux/actions.o In file included from

Re: [ovs-dev] openvswitch 2.4: HAVE_RHEL_OVS_HOOK on 2.6.32-573.3.1.el6.x86_64

2015-10-20 Thread Sabyasachi Sengupta
I do not see this issue on branch-2.4, you need to clone ovs git repo and checkout branch-2.4 to get the code. I realized I was using little older branch-2.4 - from the original release date of 8/24. After moving to the top, especially after importing the commit

[ovs-dev] [PATCH] Fix extract_ofp_msgs to use HMAP_NODE_NULL_INITIALIZER instead of hard-coding {0, NULL} while creating _instances[] arrays

2015-10-13 Thread Sabyasachi Sengupta
--- build-aux/extract-ofp-msgs |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/build-aux/extract-ofp-msgs b/build-aux/extract-ofp-msgs index e4deecf..9dc9691 100755 --- a/build-aux/extract-ofp-msgs +++ b/build-aux/extract-ofp-msgs @@ -300,7 +300,7 @@ def

Re: [ovs-dev] [PATCH] Fix extract_ofp_msgs to use HMAP_NODE_NULL_INITIALIZER instead of hard-coding {0, NULL} while creating _instances[] arrays

2015-10-13 Thread Sabyasachi Sengupta
This change will cause segfaults if anything ever reaches the end of a bucket. Oh, didn't realize that, but it seems to work fine in my setup. Just wondering how it works while initializing all_raw_instances. I'm curious how would it be different for _instances.

[ovs-dev] intermittent crash during ovsdb updates with ovs-2.4

2015-09-21 Thread Sabyasachi Sengupta
Hi, We are moving to the recently released ovs-2.4 and are seeing some random crashes during ovsdb periodic updates into vswitchd. Some preliminary analysis is below. The crash typically happens after we've successfully brought up ovs and have downloaded some configs and after we start

[ovs-dev] potential branch-2.5 GRE tunnel recreate issue

2016-02-09 Thread Sabyasachi Sengupta
Hi Pravin, I'm trying out GRE tunnel configure/deconfigure with branch-2.5 and master and saw that it was not able to configure the tunnel if it is recreated with openvswitch-dkms. My environment is Centos 6.6 (2.6.32-504 kernel). I noticed that as part of commit e23775, you added ifdef

[ovs-dev] ovs-2.5 --with-dpdk compilation error -- warning: implicit declaration of function ‘_mm_alignr_epi8’

2016-10-31 Thread Sabyasachi Sengupta
Hi, I'm trying to follow the instructions in ovs-2.5/INSTALL.DPDK.md and am getting the following error. This is with dpdk-2.2.0 and Centos 7.1: from lib/netdev-dpdk.c:58: /third-party/dpdk/x86_64-native-linuxapp-gcc/include/rte_memcpy.h: In function ‘rte_memcpy’: