@openvswitch.org; Nithin Raju; Samuel Ghinet
Subject: Re: [ovs-dev] [PATCH] Create a NBL for each NB when required
Hi Alin,
Thanks for working on it! I am almost done reviewing the change. I have a
few comments below.
ovs/ovs-issues#15
All NET_BUFFERs of a NET_BUFFER_LIST must go through
the pipeline
Hello Nithin,
I have a few notes regarding the patch:
struct {
POVS_MESSAGE ovsMsg;/* OVS message passed during dump start. */
UINT32 index[8];/* markers to continue dump from. One or more
* of them may be used. */
}
Hello Nithin,
BOOLEAN validateDp; /* Does command require a valid DP argument. */
} NETLINK_CMD, *PNETLINK_CMD;
Perhaps a better name would be validateDpIfIndex? Or, is there going to be
something more to be validated later on, when validateDp = TRUE?
if
Hello Nithin,
typedef struct _OVS_USER_PARAMS_CONTEXT {
PIRP irp;
POVS_OPEN_INSTANCE ovsInstance;
UINT32 devOp;
Perhaps it would be useful to add a comment for devOp, something like:
UINT32 devOp; /* a value of OVS_*_DEV_OP */
since it may not be obvious that devOp is a 'flags' of
Hello Nithin,
/* Netlink datapath family. */
NETLINK_CMD nlDatapathFamilyCmdOps[] = {
{ OVS_DP_CMD_GET, OvsGetDpCmdHandler,
OVS_WRITE_DEV_OP | OVS_READ_DEV_OP, FALSE }
};
Could you make the NETLINK_CMD variable initialization in the same style as the
NETLINK_FAMILY variable
...@nicira.com]
Sent: Wednesday, August 27, 2014 6:16 PM
To: Samuel Ghinet
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] Rename files under datapath-windows
On Tue, Aug 26, 2014 at 08:03:47PM +, Samuel Ghinet wrote:
This patch includes the file renaming and accommodations needed for the file
of spaces.
This patch also transforms tabs into spaces.
Signed-off-by: Samuel Ghinet sghinet at cloudbasesolutions.com
Co-authored-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
---
build-aux/extract-odp-netlink-windows-dp-h | 2 +-
datapath-windows/automake.mk
Ben,
The tabs are automatically transformed into spaces when the email is sent.
Could you please replace the tabs in automake.mk into spaces before applying
the patch?
Thanks,
Sam
From: Samuel Ghinet
Sent: Friday, August 29, 2014 7:06 AM
To: dev
.
Thanks,
Sam
From: Samuel Ghinet
Sent: Thursday, August 21, 2014 10:45 PM
To: Nithin Raju
Cc: dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH 01/15] datapath-windows: Update CodingStyle
Also, I think it would be cleaner would improve code readability
to keep it as an array, please do not
Acked-by: Samuel Ghinet, it is possible I do not agree with your alternative.
Also, if you ignore a suggestion of mine, please do not say Acked-by: Samuel
Ghinet
Or when I suggest you add some doc comments, it is possible I do not find the
documentation clear
Nithin,
You have in this patch 2:
BOOLEAN validateDp;
while in patch 8:
BOOLEAN validateDpIndex;
I had expected you make only a single patch, with the latest version.
Also you have ignored some of my suggestions.
So this patch goes: Not acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
goes: Not acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Thanks,
Sam
Date: Fri, 29 Aug 2014 01:15:15 -0700
From: Nithin Raju nit...@vmware.com
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 3/9 v2] datapath-windows: add a context
Nithin,
I had given some suggestions, which you agreed upon, but you did not apply them
to this patch.
Also, note the typo in the comment:
In this patch, we add support for the GET_DP netlink command to dump
the datpaaths
So this patch goes: Not acked-by: Samuel Ghinet sghi
Nithin,
This patch goes: Not acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Regards,
Sam
Message: 1
Date: Fri, 29 Aug 2014 01:15:17 -0700
From: Nithin Raju nit...@vmware.com
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 5/9 v2] datapath
Nithin,
This patch goes: Not acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Regards,
Sam
Date: Fri, 29 Aug 2014 01:15:18 -0700
From: Nithin Raju nit...@vmware.com
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 6/9 v2] datapath-windows: Check
Nithin,
This patch goes: Not acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Regards,
Sam
Date: Fri, 29 Aug 2014 01:15:19 -0700
From: Nithin Raju nit...@vmware.com
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 7/9 v2] datapath-windows: add
Nithin,
This patch goes: Not acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Regards,
Sam
Date: Fri, 29 Aug 2014 01:15:20 -0700
From: Nithin Raju nit...@vmware.com
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 8/9 v2] datpath-windows: fix
Nithin,
I had expected you modify the original patch with my suggestions, not add a new
patch on top of it, by which to refactor the original patch.
So this patch is: Not acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Regards,
Sam
Date: Fri, 29
as argument a NET_BUFFER. I have also added a few
ASSERTs where the NET_BUFFER_LIST is expected to have
only one NET_BUFFER.
Signed-off-by: Samuel Ghinet sghinet at cloudbasesolutions.com
Co-authored-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
---
datapath-windows/ovsext/OvsActions.c
Hello,
Part 2 of the patch is below:
===
---
datapath-windows/ovsext/OvsBufferMgmt.c | 39 +
1 file changed, 20 insertions(+), 19 deletions(-)
diff --git a/datapath-windows/ovsext/OvsBufferMgmt.c
b/datapath-windows/ovsext/OvsBufferMgmt.c
Hello,
Below is part 3 of the patch - main refactor of the ingress path
(OvsStartNBLIngress / OvsExtSendNBL)
Thank you!
Samuel Ghinet
=
addressing issues:
o) clearer variable names
o) merge OvsExtSendNBL and OvsStartNBLIngress into OvsExtSendNBL
(there is no reason
,
Sam
From: Samuel Ghinet
Sent: Friday, August 29, 2014 4:29 PM
To: dev@openvswitch.org; Ankur Sharma; ssaur...@vmware.com; elia...@vmware.com;
nit...@vmware.com
Cc: Alin Serdean
Subject: Please review: [PATCH 1/3] Create a NBL for each NB when required
Hello
the refactor first, then the bug fix. Or, if
you prefer both in the same commit, I'll make it like that.
Please tell me how you find it easier.
Thanks,
Samuel
From: Saurabh Shah [ssaur...@vmware.com]
Sent: Friday, August 29, 2014 9:51 PM
To: Samuel Ghinet; Alin
From: Nithin Raju [nit...@vmware.com]
Sent: Friday, August 29, 2014 11:10 PM
To: Alin Serdean
Cc: dev@openvswitch.org; Samuel Ghinet
Subject: Re: [ovs-dev] [PATCH] Create a NBL for each NB when required
hi Sam/Alin,
Thanks for working on this.
In general, it would have been better
It might be a bit late for this note now, but perhaps a separate patch could
add it:
UINT32 devOp;/* Device operation of the userspace call. */
devOp is as vague as Device operation IMHO.
Could you please refer to these flags (defined in Datapath.c):
#define OVS_READ_DEV_OP
Looks good,
Sam
Date: Fri, 29 Aug 2014 12:05:14 -0700
From: Ankur Sharma ankursha...@vmware.com
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 9/9 v3] datapath-windows: refactor code to
setup dump start state
Message-ID:
comment in another patch aforementioned.
Regards,
Sam
From: Ankur Sharma [ankursha...@vmware.com]
Sent: Saturday, August 30, 2014 2:04 AM
To: Ben Pfaff
Cc: Eitan Eliahu; Samuel Ghinet; dev@openvswitch.org; Nithin Raju
Subject: RE: [ovs-dev] [PATCH 9/9 v2
Looks good, as far as I can tell.
One minor style thing though:
+goto done;
+}
+}
+else {
+/* The I/O was completed synchronously */
+poll_immediate_wake();
+}
I think it should have been:
} else {
Regards,
Sam
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
From: Samuel Ghinet
Sent: Sunday, September 07, 2014 2:54 AM
To: dev@openvswitch.org
Cc: Alin Serdean; nit...@vmware.com; ssaur...@vmware.com; Ankur Sharma
Subject: [PATCH 9/9 v3] datapath-windows
Hello Ankur,
I've got one questions about the buffer management and netlink put functions:
Do we have here some netlink put functions to use for nested netlink attributes?
Thanks,
Samuel
Date: Thu, 4 Sep 2014 09:44:45 -0700
From: Ben Pfaff
Thanks a lot Ankur,
Sam
From: Ankur Sharma [ankursha...@vmware.com]
Sent: Sunday, September 07, 2014 8:20 PM
To: Samuel Ghinet; dev@openvswitch.org
Cc: Alin Serdean; Eitan Eliahu; Nithin Raju; Saurabh Shah
Subject: RE: [ovs-dev] [PATCH v2 2/6] NetlinkBuf.c
functionality that sets
multiple upcall pids datapath feature ATM.
d) the vxlan destination udp port is currently a constant. When it will become
configurable and we will have netlink put support for nested attributes, the
vport options netlink attribute will become relevant.
Signed-off-by: Samuel
, if the original NBL had
more NBs.
Signed-off-by: Samuel Ghinet sghinet at cloudbasesolutions.com
Co-authored-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
---
datapath-windows/ovsext/Actions.c | 60 +-
datapath-windows/ovsext/BufferMgmt.c | 78 +---
datapath-windows/ovsext
I have tested:
- vxlan
- vlan (using patch ports, as specified in INSTALL.Windows)
using:
- ping
- tcp
- tcp LSO (tcp segmentation)
I have put both the each NB - NBL and its refactor in the same patch.
Thanks,
Sam
From: Samuel Ghinet
Sent: Monday
dropping, at the beginning, the reference to the splitNbl (last patch
version)?
Thanks,
Samuel
From: Nithin Raju [nit...@vmware.com]
Sent: Tuesday, September 09, 2014 6:36 PM
To: Samuel Ghinet
Cc: Alin Serdean; Saurabh Shah; dev@openvswitch.org
Subject: Re
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
From: Alin Serdean
Sent: Tuesday, September 09, 2014 8:43 PM
To: Nithin Raju; dev@openvswitch.org; Samuel Ghinet
Subject: RE: [ovs-dev] [PATCH v2] datapath-windows: update CodingStyle
guideline
There would be one issue from me:
there was an email - reply to a vport patch time ago, where hyper-v switch
ports were separated from ovs / datapath ports.
The discussion had remained pending, but it might be important if we plan
netlink commands vport new and vport delete for the near future.
.
Tested:
- vxlan
- vlan (using patch ports, as specified in INSTALL.Windows)
using:
- ping
- tcp
- tcp LSO (tcp segmentation)
Reported-at: ovs/ovs-issues#15
Signed-off-by: Samuel Ghinet sghinet at cloudbasesolutions.com
---
datapath-windows/ovsext/Actions.c| 36 +++-
datapath-windows
Eitan,
A few notes:
o) regarding the call:
error = nl_sock_send__(sock, request, 0, true);
(parameter 3 is sequence)
I found doc comment in nl_sock_allocate_seq, saying:
/* Make it impossible for the next request for sequence numbers to wrap
* around to 0. Start over with 1 to avoid ever
Hey Nithin,
AFAIK OvsCleanupOpenInstance is called by OvsCleanupDevice, which is a callback
called by NDIS when an IO is pending and the file must be closed.
FreeUserDumpState is only for dump operations.
Is it possible that an IO to be pending (packet queueing) while at the same
time a dump
Acked-by Samuel Ghinet sghi...@cloudbasesolutions.com
Date: Wed, 10 Sep 2014 16:20:16 -0700
From: Ankur Sharma ankursha...@vmware.com
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH v2 1/2] datapath-windows/NetlinkBuf.h: Added
NlBufSize
Message-ID
Hi Ankur,
+VOID
+NlMsgPutNested(PNL_BUFFER buf, UINT16 type,
+ const PVOID data, UINT32 size)
+{
+UINT32 offset = NlMsgStartNested(buf, type);
+
+UNREFERENCED_PARAMETER(data);
+UNREFERENCED_PARAMETER(size);
+
+ASSERT(offset);
+
+
will happen (I assume this is the expected behavior).
Sam
From: Nithin Raju [nit...@vmware.com]
Sent: Thursday, September 11, 2014 4:31 AM
To: Samuel Ghinet; Alin Serdean
Cc: dev@openvswitch.org
Subject: datapath-windows: adding vport from userspace to kernel
hi
is
empty, instead?
Thanks,
Sam
From: Nithin Raju [nit...@vmware.com]
Sent: Thursday, September 11, 2014 4:41 AM
To: Samuel Ghinet
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during
instance cleanup
On Sep
From: Eitan Eliahu [elia...@vmware.com]
Sent: Saturday, September 13, 2014 12:01 AM
To: Nithin Raju
Cc: Samuel Ghinet; dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during
instance cleanup
My understating is the Cleanup callback is called when the file
At first on reading this code, I was wondering why?
Now I think I understand: the function zeroes memory, and must return the ptr
to 'next' item to be filled (which is called tail). Am I correct?
Also, I think it would be nice if you could rename NlBufCopyAtTailUninit -
NlBufZeroAtTailUninit or
Hello Nithin,
Overall, it looks ok.
Very minor things, though:
(OvsDpFillInfo)
o) could you please rename nlWrite into something more boolean-like, like ok
or whatever you prefer?
When I first read that piece of code, I was thinking nlWrite is a ptr returned
by NlMsgPutHead. It confused me for
, 2014 2:41 AM
To: Samuel Ghinet
Cc: dev@openvswitch.org; Alin Serdean; Saurabh Shah; Eitan Eliahu; Ankur Sharma
Subject: Re: [PATCH] datapath-windows: Handle NBLs with multiple NBs
hi Sam,
Thanks for the updating the patch to make it specific to handle NBLs with
multiple NBs.
In general it looks
Eitan: yes, I agree. That's why we need to keep the atDispatch variable (in the
patch, which holds the result of the flag check).
From: Eitan Eliahu [elia...@vmware.com]
Sent: Monday, September 15, 2014 7:06 PM
To: Samuel Ghinet; Nithin Raju
Cc: dev
device. So technically it should be impossible
that two processes share a HANDLE.
Sam
From: Eitan Eliahu [elia...@vmware.com]
Sent: Monday, September 15, 2014 6:50 PM
To: Samuel Ghinet; Nithin Raju
Cc: dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH] datapath
and vswitchd vport commands to
work
properly.
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/include/OvsDpInterfaceExt.h | 2 +
datapath-windows/include/OvsPub.h| 25 ++---
datapath-windows/ovsext/Actions.c| 6 +--
datapath-windows/ovsext
destination udp port is currently a constant. When it will become
configurable, the vport options netlink attribute will become relevant.
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext/Datapath.c | 222 -
datapath-windows
Nithin,
I don't think there's a need to implement such a function.
You can use memcmp, which behaves quite like strncmp.
Regards,
Sam
From: Nithin Raju [nit...@vmware.com]
Sent: Wednesday, September 17, 2014 5:06 AM
To: dev@openvswitch.org; Samuel Ghinet
Hello Nithin,
This patch looks good!
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
From: Nithin Raju [nit...@vmware.com]
Sent: Wednesday, September 17, 2014 5:06 AM
To: dev@openvswitch.org; Samuel Ghinet; elia...@vmware.com;
ankursha
Oh, except a little typo in the commit message:
Eg. the Windows kernel does not send embed an error
Sam
From: Samuel Ghinet
Sent: Wednesday, September 17, 2014 4:34 PM
To: Nithin Raju; dev@openvswitch.org; elia...@vmware.com; ankursha...@vmware.com
Subject
?
Thanks,
Sam
From: Eitan Eliahu [elia...@vmware.com]
Sent: Monday, September 15, 2014 6:50 PM
To: Samuel Ghinet; Nithin Raju
Cc: dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during
instance cleanup
Each time that a device
I meant to send it to ML.
From: Samuel Ghinet
Sent: Wednesday, September 17, 2014 7:46 PM
To: Eitan Eliahu
Subject: RE: [PATCH v2] datapath-windows: Netlink command: vport dump
Hi Eitan,
Yes, you're right, I forgot to check the return values from
,
Sam,
From: Eitan Eliahu [elia...@vmware.com]
Sent: Thursday, September 18, 2014 2:16 PM
To: Samuel Ghinet; Nithin Raju
Cc: dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during
instance cleanup
Hi Sam,
As far as I understand
clarity a bit on the ways
ret is used and changed.
Anyway, it's good the way it is in NlAttrValidate as well.
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Sam
Date: Tue, 16 Sep 2014 19:06:07 -0700
From: Nithin Raju nit...@vmware.com
To: dev
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Date: Tue, 16 Sep 2014 19:06:10 -0700
From: Nithin Raju nit...@vmware.com
To: dev@openvswitch.org, sghi...@cloudbasesolutions.com,
elia...@vmware.com, ankursha...@vmware.com
Subject: [ovs-dev
Hey Nithin,
I think this could work refactored a bit (such as to better separate commands),
but we should postpone refactor for a later time.
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Date: Tue, 16 Sep 2014 19:06:11 -0700
From: Nithin Raju
Looks good to me!
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Date: Wed, 17 Sep 2014 23:12:05 -0700
From: Eitan Eliahu elia...@vmware.com
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] datapath-windows: NetLink kernel side,
Event
From: Eitan Eliahu [elia...@vmware.com]
Sent: Thursday, September 18, 2014 2:35 PM
To: Samuel Ghinet; Nithin Raju
Cc: dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during
instance cleanup
No Sam, Duplication of handles is done
more on the
netlink vport commands :)
Thanks,
Sam
From: Nithin Raju [nit...@vmware.com]
Sent: Friday, September 19, 2014 3:00 AM
To: Samuel Ghinet
Cc: dev@openvswitch.org; Alin Serdean; Saurabh Shah; Eitan Eliahu; Ankur Sharma
Subject: Re: [PATCH] datapath
and
changes the afferent kernel driver code:
o) vport types synthetic and emulated turn to: netdev
o) vport type internal turns to: internal
o) vport type external truns to: netdev (plus, we hold a field in vport,
isExternal
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath
.
Tested:
- vxlan
- vlan (using patch ports, as specified in INSTALL.Windows)
using:
- ping
- tcp
- tcp LSO (tcp segmentation)
Reported-at: ovs/ovs-issues#15
Signed-off-by: Samuel Ghinet sghinet at cloudbasesolutions.com
---
datapath-windows/ovsext/Actions.c| 20 +-
datapath-windows
we did so far?
Thanks,
Sam
From: Nithin Raju [nit...@vmware.com]
Sent: Friday, September 19, 2014 2:21 AM
To: Samuel Ghinet
Cc: dev@openvswitch.org; Eitan Eliahu; Saurabh Shah; Ankur Sharma; Alin Serdean
Subject: Re: [PATCH v2] datapath-windows: Netlink
Oh, I've sent reply with explanations before reading this reply of yours.
Anyway, I wrote explanations there for other things as well.
Regards,
Sam
From: Nithin Raju [nit...@vmware.com]
Sent: Friday, September 19, 2014 7:43 PM
To: Samuel Ghinet
Cc: dev
destination udp port is currently a constant. When it will become
configurable, the vport options netlink attribute will become relevant.
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext/Datapath.c | 273 -
datapath-windows/ovsext
transactional operations.
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/automake.mk | 1 +
datapath-windows/ovsext/Datapath.c | 10 ++
datapath-windows/ovsext/Datapath.h | 10 +-
datapath-windows/ovsext/Netlink/NetlinkError.h
portLink of OVS_VPORT_ENTRY is renamed by portIdLink, so as to
distinguish it from the new portNoLink.
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/include/OvsPub.h | 2 -
datapath-windows/ovsext/Actions.c | 27 +++--
datapath-windows/ovsext/Datapath.c | 6
be linked
together correctly.
Tested:
- vxlan
- vlan (using patch ports, as specified in INSTALL.Windows)
using:
- ping
- tcp
- tcp LSO (tcp segmentation)
Reported-at: ovs/ovs-issues#2
Signed-off-by: Samuel Ghinet sghinet at cloudbasesolutions.com
---
datapath-windows/ovsext/Actions.c
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Date: Wed, 24 Sep 2014 00:15:35 -0700
From: Ankur Sharma ankursha...@vmware.com
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH v1 01/10] datapath-windows: move OVS_MESSAGE
to Netlink.h
. Or you may wish to make some
use of my functions as well.
Either way it's fine by me.
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Date: Wed, 24 Sep 2014 00:15:36 -0700
From: Ankur Sharma ankursha...@vmware.com
To: dev@openvswitch.org
Subject: [ovs
One very minor thing:
I believe the titles of the commit messages are normally put like Add
NlAttrLen API, not Added NlAttrLen API.
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Date: Wed, 24 Sep 2014 00:15:37 -0700
From: Ankur Sharma ankursha
, and not validate the
message itself.
It is possible such changes would make code clearer a bit.
However, there is existing code that relies on the current format of
NlAttrParse, so perhaps on a new patch.
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Date: Wed
Hey Ankur,
A few notes:
+NETLINK_CMD nlFlowFamilyCmdOps[] = {
+{ .cmd = OVS_FLOW_CMD_NEW,
+ .handler = OvsFlowNlNewCmdHandler,
+ .supportedDevOp = OVS_TRANSACTION_DEV_OP,
+ .validateDpIndex = FALSE
+}
+};
It is possible that we need to have
Hey Ankur,
+if (keyAttrs[OVS_KEY_ATTR_TUNNEL]) {
+destKey-tunKey.tunnelId = NlAttrGetU64
+ (tunAttrs[OVS_TUNNEL_KEY_ATTR_ID]);
+destKey-tunKey.dst = NlAttrGetU32
+ (tunAttrs[OVS_TUNNEL_KEY_ATTR_IPV4_DST]);
+
Hey Ankur,
There are a few differences between flow new and flow set, with regard to the
transactional errors that will need to be implemented:
Flow New: can do NEW or SET.
If netlink command flow new is issued, with netlink flags create and
exclusive, and the flow exists, it must return
Oh, now I see, flow flush is handled :)
Date: Wed, 24 Sep 2014 00:15:44 -0700
From: Ankur Sharma ankursha...@vmware.com
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH v1 10/10] datapath-windows/Flow.c: DEL_FLOWS
command handler.
Message-ID:
: Wed, 24 Sep 2014 16:13:59 +
From: Eitan Eliahu elia...@vmware.com
To: Samuel Ghinet sghi...@cloudbasesolutions.com,
dev@openvswitch.org dev@openvswitch.org
Cc: Kaushik Guha kg...@vmware.com
Subject: Re: [ovs-dev] [PATCH 1/3] datapath-windows: Add file
NetlinkError.h
Message-ID
I now see this new version.
The while has been removed I see, along with the issues I had pointed out with
the values returned.
I will write my comments here, of the things that still remained :)
}
+
/*
* --
*
In the future it might be useful if we could do recursive validation checks in
NlAttrValidate when we have nested attributes.
Because I am not sure we can currently validate the netlink attributes nested
in parent netlink attributes, using functions like NlAttrValidate.
Acked-by: Samuel Ghinet
Hey Ankur,
A problem I see here with flow delete is that Flow delete requires:
- no attributes (i.e. no key): if flow flush is requested
- key only: if a specific flow key is to be deleted.
When / if masks will be allowed for flows, the mask is expected not to exist.
How does the current code
and
changes the afferent kernel driver code:
o) vport types synthetic and emulated turn to: netdev
o) vport type internal turns to: internal
o) vport type external truns to: netdev (plus, we hold a field in vport,
isExternal
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Acked-by: Nithin
destination udp port is currently a constant. When it will become
configurable, the vport options netlink attribute will become relevant.
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Acked-by: Nithin Raju nit...@vmware.com
The transactional get vport command.
This command uses the netlink transactional errors.
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Acked-by: Nithin Raju nit...@vmware.com
---
datapath-windows/ovsext/Datapath.c | 83 +-
1 file changed, 82
correspond to the userspace error codes defined in:
C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\include\errno.h
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Acked-by: Eitan Eliahu elia...@vmware.com
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
---
datapath
From: Eitan Eliahu [elia...@vmware.com]
Sent: Wednesday, September 24, 2014 8:00 PM
To: Samuel Ghinet; dev@openvswitch.org
Cc: Alin Serdean; Nithin Raju; Ankur Sharma; Saurabh Shah
Subject: RE: [PATCH 2/3] datapath-windows: Add Netlink vport command get
Looks good. Please find
, September 25, 2014 9:51 PM
To: Samuel Ghinet
Cc: dev@openvswitch.org; Alin Serdean; Eitan Eliahu; Ankur Sharma; Saurabh Shah
Subject: Re: [PATCH 2/3] datapath-windows: Add Netlink vport command get
hi Samuel,
I had some minor comments. Looks good otherwise.
Acked-by: Nithin Raju nit
Hello guys,
This patch number 00 is an introduction to the patch series.
I am sorry we could not provide the design behind this much faster. This series
of patches is based on that design.
I have tested these vport commands with both VMs and vxlan, with both VMs
connecting and reconnecting
The old IOCTL vport functions (using the non-netlink device) are no
longer needed. They should be removed.
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext/Vport.c | 403
datapath-windows/ovsext/Vport.h | 15 --
2
. This will make more
clear the usages from netlink vport commands side and from hyper-v
switch side. It will also make more obvious which nic and port
functions are helper functions.
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext/Oid.c | 24
-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext/Oid.c | 4
datapath-windows/ovsext/Vport.c | 8 +---
datapath-windows/ovsext/Vport.h | 1 -
3 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/datapath-windows/ovsext/Oid.c b/datapath-windows/ovsext/Oid.c
to POVS_VPORT_ENTRY.
This patch does not cleanup the code that already uses casts to
POVS_VPORT_ENTRY. This cleanup can be done later on as well.
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext/Switch.h | 6 --
1 file changed, 4 insertions(+), 2 deletions
changing the value without modifying many
parts of the code.
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext/Datapath.c | 2 +-
datapath-windows/ovsext/Vport.c| 2 +-
datapath-windows/ovsext/Vport.h| 2 ++
3 files changed, 4 insertions(+), 2
falls on the hyper-v switch port handlers side, but on the netlink vport
commands side (vport add), we will need to use this compute port number
function from outside Vport.c. Therefore, this function declaration is
moved from Vport.c to Vport.h, and becomes public.
Signed-off-by: Samuel Ghinet sghi
to ovsPortNameHashArray,
while the nameLink is renamed to ovsPortNameLink. This change will make
a clearer connection between these and the vport field ovsName to
which they revolve around.
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext/Switch.c | 12
. Also,
in order to differentiate between portLink and portNoLink, portLink
is renamed to portIdLink.
In a future patch the vport functionality will be changed to constraint
the port numbers to MAXUINT16.
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext
into the
hash array of port numbers here, nor into the hash array of port names.
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext/Actions.c | 27 --
datapath-windows/ovsext/Switch.c | 28 ++-
datapath-windows/ovsext/Switch.h | 18 ++--
datapath-windows
1 - 100 of 220 matches
Mail list logo
