[ovs-dev] [PATCH v2 36/47] ofp-msg: Support decoding of ONF extensions for OF1.3

2014-06-10 Thread Simon Horman
This is in preparation for supporting EXT-187: flow entry notification extension (ONF flow monitor). Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- lib/ofp-msgs.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/lib/ofp-msgs.c

[ovs-dev] [PATCH v2 33/47] ofproto: Add OFPRAW_ONFST13_FLOW_*

2014-06-10 Thread Simon Horman
Add raw types for EXT-187: flow entry notification extension (ONF flow monitor). Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- lib/ofp-msgs.h | 53 + 1 file changed, 37 insertions(+), 16 deletions(-) diff --git a/lib

[ovs-dev] [PATCH v2 42/47] ofp-util: Support encoding of EXT-187 requests

2014-06-10 Thread Simon Horman
Support encoding of EXT-187: flow entry notification extension (ONF flow monitor) requests. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- lib/ofp-util.c| 29 - ofproto/ofproto.c | 21 + 2 files changed, 41 insertions

[ovs-dev] [PATCH v2 40/47] ofp-util: Support decoding of EXT-187 requests

2014-06-10 Thread Simon Horman
Support decoding of EXT-187: flow entry notification extension (ONF flow monitor) requests. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- lib/ofp-util.c | 58 ++ 1 file changed, 58 insertions(+) diff --git a/lib

[ovs-dev] [PATCH v2 37/47] ofp-print: Test of EXT-187 cancel, paused and resumed messages

2014-06-10 Thread Simon Horman
Test printing of EXT-187: flow entry notification extension (ONF flow monitor) cancel, paused and resumed messages. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- tests/ofp-print.at | 28 1 file changed, 28 insertions(+) diff --git a/tests

[ovs-dev] [PATCH v2 45/47] ofp-util: Support encoding of EXT-187 replies

2014-06-10 Thread Simon Horman
Support encoding of EXT-187: flow entry notification extension (ONF flow monitor) replies. This re-uses existing Nicira extension code as other than the header the wire format is the same. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- lib/ofp-util.c | 6 -- 1 file

[ovs-dev] [PATCH v2 47/47] openflow: EXT-187 is now supported

2014-06-10 Thread Simon Horman
EXT-187: flow entry notification extension (ONF flow monitor) is now supported for OpenFlow1.3. OpenFlow1.4 flow monitor is also now supported. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- OPENFLOW-1.1+ | 5 - 1 file changed, 5 deletions(-) diff --git a/OPENFLOW

[ovs-dev] [PATCH v2 46/47] ofproto: EXT-187 tests

2014-06-10 Thread Simon Horman
Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- tests/ofproto.at | 346 +++ 1 file changed, 346 insertions(+) diff --git a/tests/ofproto.at b/tests/ofproto.at index 4240b98..892ab93 100644 --- a/tests/ofproto.at +++ b

[ovs-dev] [PATCH v6 repost 2 4/6] ofproto-dpif: MPLS recirculation

2014-06-10 Thread Simon Horman
. Signed-off-by: Simon Horman ho...@verge.net.au --- v6 * Rename may_xlate_l3_actions as was_mpls. The use-cases for this flag have grown over time and the old name had become misleading. * Also move was_mpls into struct xlate_ctx. This allows this state to be accessed when translating

[ovs-dev] [PATCH v6 repost 2 5/6] ofp-actions: Allow pop_mpls on MPLS packets

2014-06-10 Thread Simon Horman
With recirculation in place this should be safe. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 - v5 * No change --- lib/ofp-actions.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index cc1f9a0..119677e 100644 --- a/lib/ofp-actions.c

[ovs-dev] [PATCH v6 repost 2 0/6] Flow-Based Recirculation for MPLS

2014-06-10 Thread Simon Horman
-recirculation-v6 Simon Horman (6): ofproto-dpif: Move RECIRC_RULE_PRIORITY to common header ofproto-dpif: Add recirc_id field to struct rule_dpif ofproto-dpif: Add idle_timeout parameter to ofproto_dpif_add_internal_flow() ofproto-dpif: MPLS recirculation ofp-actions: Allow pop_mpls

[ovs-dev] [PATCH v6 repost 2 3/6] ofproto-dpif: Add idle_timeout parameter to ofproto_dpif_add_internal_flow()

2014-06-10 Thread Simon Horman
recirculation. Signed-off-by: Simon Horman ho...@verge.net.au -- v6 * Rebase v5 * No change v4 * Rebase v3 * Rebase * Break back out into separate patch v2 * Erroneously squashed into odp-util: Add odp_put_recirc_action() helper --- ofproto/bond.c | 2 +- ofproto/ofproto-dpif.c | 10

[ovs-dev] [PATCH v6 repost 2 1/6] ofproto-dpif: Move RECIRC_RULE_PRIORITY to common header

2014-06-10 Thread Simon Horman
This is in preparation for using this value in ofproto-dpif-xlate.c when composing recirculation actions added as a result of processing (MPLS) actions. Signed-off-by: Simon Horman ho...@verge.net.au --- v3 - v5 * No change v2 * First post --- ofproto/bond.c | 1 - ofproto/ofproto

[ovs-dev] [PATCH v6 repost 2 2/6] ofproto-dpif: Add recirc_id field to struct rule_dpif

2014-06-10 Thread Simon Horman
to be translated. Signed-off-by: Simon Horman ho...@verge.net.au --- v5 * Rebase v4 * No change v3 * Rebase * Add rule_set_recirc_id() v2 * No change --- ofproto/ofproto-dpif.c | 47 +++ ofproto/ofproto-dpif.h | 2 ++ 2 files changed, 49 insertions

[ovs-dev] [PATCH/RFC v2 1/4] ofp-msg: Add helpers for allowing multipart requests

2014-06-10 Thread Simon Horman
Add helpers for allowing requests and use them in handle_openflow__(). This is a in preparation for supporting multipart requests on a per message type basis. Signed-off-by: Simon Horman ho...@verge.net.au --- lib/ofp-msgs.c| 34 ++ lib/ofp-msgs.h| 2

[ovs-dev] [PATCH/RFC v2 0/4] Support multipart requests with multiple parts

2014-06-10 Thread Simon Horman
/openvswitch.git devel/multipart-request-v2 Simon Horman (4): ofp-msg: Add helpers for allowing multipart requests connmgr: Buffer multipart requests ofproto: Support multipart flow monitor requests openflow: Multipart requests are now supported OPENFLOW-1.1+ | 4 - lib/ofp-msgs.c

[ovs-dev] [PATCH/RFC v2 3/4] ofproto: Support multipart flow monitor requests

2014-06-10 Thread Simon Horman
Signed-off-by: Simon Horman ho...@verge.net.au --- lib/ofp-msgs.c| 3 +- ofproto/ofproto.c | 63 +++- tests/ofproto.at | 122 ++ 3 files changed, 167 insertions(+), 21 deletions(-) diff --git a/lib/ofp-msgs.c b

[ovs-dev] [PATCH/RFC v2 2/4] connmgr: Buffer multipart requests

2014-06-10 Thread Simon Horman
request support to individual message types. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * Use ofpmsg_may_buffer_mp_request() to only buffer messages for which buffering is enabled. Currently there are none. * Annotate mp_reqs field of struct ofconn with OVS_GUARDED_BY(ofproto_mutex

[ovs-dev] [PATCH/RFC v2 4/4] openflow: Multipart requests are now supported

2014-06-10 Thread Simon Horman
Signed-off-by: Simon Horman ho...@verge.net.au --- OPENFLOW-1.1+ | 4 1 file changed, 4 deletions(-) diff --git a/OPENFLOW-1.1+ b/OPENFLOW-1.1+ index 4f6ec92..89a6b0d 100644 --- a/OPENFLOW-1.1+ +++ b/OPENFLOW-1.1+ @@ -82,10 +82,6 @@ following additional work. (This is based on the change

[ovs-dev] [PATCH v2.60 repost] datapath: Add basic MPLS support to kernel

2014-06-11 Thread Simon Horman
yamah...@valinux.co.jp Cc: Joe Stringer j...@wand.net.nz Signed-off-by: Simon Horman ho...@verge.net.au --- v2.60 * Add missing break statement in do_execute_actions(). Previously there was a fall-through from OVS_ACTION_ATTR_HASH to OVS_ACTION_ATTR_PUSH_MPLS which is incorrect. (Thanks

Re: [ovs-dev] [PATCH/RFC] ofproto: Use OFPRR_GROUP_DELETE

2014-06-11 Thread Simon Horman
On Wed, Jun 11, 2014 at 10:50:51AM -0700, Ben Pfaff wrote: On Fri, May 30, 2014 at 05:14:14PM +0900, Simon Horman wrote: Use OFPRR_GROUP_DELETE as the reason for deleting flows due to the removal of a group that they use. This implementation adds an delete_reason member to struct

Re: [ovs-dev] [PATCH/RFC] connmgr: Do not use OFPRR_METER_DELETE before OF1.4

2014-06-11 Thread Simon Horman
On Wed, Jun 11, 2014 at 10:53:43AM -0700, Ben Pfaff wrote: On Fri, May 30, 2014 at 05:14:47PM +0900, Simon Horman wrote: OFPRR_METER_DELETE was introduced in OF1.4 however meters were introduced in OF1.3. Regardless of the OF version when flows are deleted cause flows to be deleted

[ovs-dev] [PATCH v2] connmgr: Do not use OFPRR_METER_DELETE before OF1.4

2014-06-11 Thread Simon Horman
to controllers connected using OF1.3 map OFPRR_METER_DELETE to OFPRR_DELETE which exists in that version. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * As suggested by Ben Pfaff - Handle reason translation in ofputil_encode_flow_removed rather than connmgr_send_flow_removed --- lib/ofp

Re: [ovs-dev] [PATCH v6 repost 2 0/6] Flow-Based Recirculation for MPLS

2014-06-12 Thread Simon Horman
On Thu, Jun 12, 2014 at 11:38:35AM -0700, Ben Pfaff wrote: On Wed, Jun 11, 2014 at 09:28:02AM +0900, Simon Horman wrote: The motivation of this series is to allow some sequences of actions that include MPLS actions to be performed using recirculation. Sequences of actions that could

Re: [ovs-dev] [PATCH v6 repost 2 4/6] ofproto-dpif: MPLS recirculation

2014-06-12 Thread Simon Horman
On Thu, Jun 12, 2014 at 01:17:21PM -0700, Ben Pfaff wrote: On Wed, Jun 11, 2014 at 09:28:06AM +0900, Simon Horman wrote: In some cases an pop MPLS action changes a packet to be a non-mpls packet. In this case subsequent any L3+ actions require access to portions of the packet which were

[ovs-dev] [PATCH] ofproto: Initialise return value of modify_flows__

2014-06-12 Thread Simon Horman
by dd51dae29bccca3 (ofproto: Move logic for collecting read-only rules into rule_criteria.). I am assuming that the implication is that it is no longer necessary. As a result of this assumption this patch simply initialises the return value to 0. Signed-off-by: Simon Horman ho...@verge.net.au --- I

Re: [ovs-dev] [PATCH 2/3] ofproto: Break out perl code for sorting multiline messages

2014-06-12 Thread Simon Horman
On Thu, Jun 12, 2014 at 02:10:21PM -0700, Ben Pfaff wrote: On Fri, Jun 06, 2014 at 07:54:17PM +0900, Simon Horman wrote: The flow monitoring tests includes a perl script to sort multiline messages. Break it out into a separate file so it can be used by other tests. This is in preparation

Re: [ovs-dev] [PATCH 3/3] ofproto: Add NX flow monitor with !own test

2014-06-12 Thread Simon Horman
On Thu, Jun 12, 2014 at 02:11:18PM -0700, Ben Pfaff wrote: On Fri, Jun 06, 2014 at 07:54:18PM +0900, Simon Horman wrote: Signed-off-by: Simon Horman ho...@verge.net.au I think that this is inverted too. !own turns off the NXFMF_OWN bit, which ovs-ofctl monitor bridge watch: turns

[ovs-dev] [PATCH v2 1/2] ofproto: Break out perl code for sorting multiline messages

2014-06-12 Thread Simon Horman
The flow monitoring tests includes a perl script to sort multiline messages. This commit breaks it out of an individual test so that it can be used elsewhere. Signed-off-by: Simon Horman ho...@verge.net.au [b...@nicira.com changed approach from a separate file to a shell function] Signed-off

[ovs-dev] [PATCH v2 2/2] ofproto: Honour NXFMF_OWN flag of flow monitors

2014-06-12 Thread Simon Horman
with !own I noticed this while working on support for OpenFlow1.4 flow monitors. Signed-off-by: Simon Horman ho...@verge.net.au v2 * As pointed out by Ben Phaff - I had the sense of the NXFMF_OWN bit inverted * Include updates to test - Needed as bit sense is inverted * Include !own test

[ovs-dev] [PATCH v2 0/2] Honour NXFMF_OWN flag of flow monitors

2014-06-12 Thread Simon Horman
Correct what appears to be erroneous behaviour of flow monitors by sending full rather than abbreviate updates to the controller that caused an update if the NXFMF_OWN flag is set. Simon Horman (2): ofproto: Break out perl code for sorting multiline messages ofproto: Honour NXFMF_OWN flag

[ovs-dev] [PATCH] ofproto: Honour out_port of flow monitors

2014-06-13 Thread Simon Horman
to be a regression introduced by b20f4073eecd4761 (ofproto: Do straightforward removal of asynchronous flow operations.) Signed-off-by: Simon Horman ho...@verge.net.au --- ofproto/connmgr.c | 8 ++- ofproto/connmgr.h | 4 +++- ofproto/ofproto-provider.h | 2 ++ ofproto/ofproto.c

Re: [ovs-dev] [PATCH v2 05/47] ofproto: Add ofoperation_has_out_group

2014-06-13 Thread Simon Horman
On Fri, Jun 13, 2014 at 11:19:39AM -0700, Ben Pfaff wrote: On Tue, Jun 10, 2014 at 07:27:09PM +0900, Simon Horman wrote: This is analogous to ofoperation_has_out_port, operating on a group rather than a port. This is in preparation for adding out_group support to flow monitors which

Re: [ovs-dev] [PATCH] ofproto: Initialise return value of modify_flows__

2014-06-13 Thread Simon Horman
On Fri, Jun 13, 2014 at 10:46:07AM -0700, Ben Pfaff wrote: On Fri, Jun 13, 2014 at 11:06:09AM +0900, Simon Horman wrote: dd51dae29bccca3 (ofproto: Move logic for collecting read-only rules into rule_criteria.) modifies modify_flows__ such that the variable error, the return value, may

[ovs-dev] [PATCH v7 1/3] ofproto-dpif: MPLS recirculation

2014-06-15 Thread Simon Horman
. Co-authored-by: Ben Pfaff b...@nicira.com Signed-off-by: Ben Pfaff b...@nicira.com Signed-off-by: Simon Horman ho...@verge.net.au --- v7 * New approach to determining if recirculation should occur. - Add ofpact_needs_recirculation_after_mpls() rather than sprinkling logic throughout

[ovs-dev] [PATCH v7 0/3] Flow-Based Recirculation for MPLS

2014-06-15 Thread Simon Horman
ports * More tests To aid review this series and its dependencies are available in git https://github.com/horms/openvswitch devel/mpls-flow-based-recirculation-v7 Simon Horman (3): ofproto-dpif: MPLS recirculation ofp-actions: Allow pop_mpls on MPLS packets ofproto-dpif: Add MPLS tests

[ovs-dev] [PATCH v7 2/3] ofp-actions: Allow pop_mpls on MPLS packets

2014-06-15 Thread Simon Horman
With recirculation in place this should be safe. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 - v5 * No change --- lib/ofp-actions.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index dc74e8a..9849771 100644 --- a/lib/ofp-actions.c

[ovs-dev] [PATCH v3 00/41] OF1.4 Flow Monitor

2014-06-15 Thread Simon Horman
dependencies are available in git at https://github.com/horms/openvswitch.git devel/flow_monitor-v3 Simon Horman (41): ofproto: Use ofp14_flow_monitor_flags internally connmgr: Support OFPFMF14_ONLY_OWN ofp-util: Add command and out_group to struct ofputil_flow_monitor_request ofp-parse

[ovs-dev] [PATCH v3 04/41] ofp-parse: Initialise flow monitor out_group

2014-06-15 Thread Simon Horman
This is in preparation for supporting OpenFlow1.4 flow monitors Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * No change --- lib/ofp-parse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c index fbbe896..5ad1d62 100644 --- a/lib/ofp-parse.c +++ b

[ovs-dev] [PATCH v3 02/41] connmgr: Support OFPFMF14_ONLY_OWN

2014-06-15 Thread Simon Horman
If the ONLY_OWN flag of a flow monitor is set then ofmonitor_report should skip sending updates to other controllers. This is in preparation for supporting OpenFlow1.4 flow monitors. Signed-off-by: Simon Horman ho...@verge.net.au --- v3 * Rebase v2 * No change --- ofproto/connmgr.c | 1 + 1

[ovs-dev] [PATCH v3 08/41] ofproto: Use list when handling monitor requests

2014-06-15 Thread Simon Horman
Use a list rather than an array to track monitor requests in handle_flow_monitor_request(). This is in preparation for supporting OpenFlow1.4 flow monitor requests with delete and modify commands. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * No change --- ofproto/connmgr.c | 2

[ovs-dev] [PATCH v3 09/41] ofproto: Break out monitor deletion code

2014-06-15 Thread Simon Horman
Break out monitor deletion code into a new function flow_monitor_delete which is paramatised over the id of the monitor to delete. This is in preparation for supporting OpenFlow1.4 flow monitor requests with delete and modify commands. Signed-off-by: Simon Horman ho...@verge.net.au --- v2

[ovs-dev] [PATCH v3 06/41] connmgr: Support monitor out_group

2014-06-15 Thread Simon Horman
Filter updates based on the out_group of a flow monitor. This is analogous to the existing treatment of out_port. This is in preparation for supporting OpenFlow1.4 flow monitors. Signed-off-by: Simon Horman ho...@verge.net.au --- v3 * Rework for removal of asynchronous operations v2

[ovs-dev] [PATCH v3 05/41] connmgr: Add out_group to struct ofmonitor

2014-06-15 Thread Simon Horman
This is in preparation for adding out_group support to flow monitors which is in turn in preparation for supporting OpenFlow1.4 flow monitors. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * No change --- ofproto/connmgr.c | 1 + ofproto/connmgr.h | 1 + 2 files changed, 2 insertions

[ovs-dev] [PATCH v3 10/41] ofproto: Handle monitor and delete commands in flow monitor requests

2014-06-15 Thread Simon Horman
Handle modify and delete commands in OpenFlow1.4 flow monitor requests. These commands are not yet allowed by the decoder which will be updated by a subsequent patch. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * No change --- ofproto/ofproto.c | 19 +++ 1 file changed

[ovs-dev] [PATCH v3 01/41] ofproto: Use ofp14_flow_monitor_flags internally

2014-06-15 Thread Simon Horman
-by: Simon Horman ho...@verge.net.au --- v3 * Rebase v2 * No change --- lib/ofp-parse.c| 16 lib/ofp-print.c| 4 +++- lib/ofp-util.c | 37 ++--- lib/ofp-util.h | 6 -- ofproto/connmgr.c | 14

[ovs-dev] [PATCH v3 07/41] ofproto: Add out_group support to flow monitors

2014-06-15 Thread Simon Horman
the flow monitor request decoder. This is in preparation for supporting OpenFlow1.4 flow monitors. Signed-off-by: Simon Horman ho...@verge.net.au --- v3 * Rebase v2 * No change --- ofproto/ofproto.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ofproto/ofproto.c b/ofproto

[ovs-dev] [PATCH v3 03/41] ofp-util: Add command and out_group to struct ofputil_flow_monitor_request

2014-06-15 Thread Simon Horman
This is in preparation for supporting OpenFlow flow monitor request commands other than OFPFMC_ADD. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * No change --- lib/ofp-util.c | 2 ++ lib/ofp-util.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/lib/ofp-util.c b/lib/ofp-util.c

[ovs-dev] [PATCH v3 20/41] ofp-print: Support Printing of OF14 Flow Monitor Replies

2014-06-15 Thread Simon Horman
Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * Use OFPRAW_OFPST14_FLOW_MONITOR_REPLY rather than OFPRAW_NXST_FLOW_MONITOR_REPLY as a key to differentiate NX and OF messages. This is consistent with the approach taken for Flow Monitor Requests and allows the code to be used for EXT

[ovs-dev] [PATCH v3 22/41] ofp-parse: Allow parsing of flow monitor request's out_group

2014-06-15 Thread Simon Horman
This has the effect of exposing an out_group argument to ovs-ofctl's monitor subcommand for use with OpenFlow1.4+. A subsequent patch will update the documentation for ovs-ofctl. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * No change --- lib/ofp-parse.c | 7 +++ 1 file changed

[ovs-dev] [PATCH v3 16/41] ofproto: Provide flow monitor paused and resumed reply composition helpers

2014-06-15 Thread Simon Horman
This is in preparation for supporting OpenFlow1.4 flow monitor replies. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * No change --- ofproto/connmgr.c | 16 +--- ofproto/connmgr.h | 5 + ofproto/ofproto.c | 25 + 3 files changed, 35 insertions

[ovs-dev] [PATCH v3 17/41] ofp-util: Support encoding of OF1.4 flow monitor replies

2014-06-15 Thread Simon Horman
At this time the encoding function is always called with OFP10_VERSION. A subsequent patch will call it with the prevailing version. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * Re-arrange case statement to group unsupported versions with default --- lib/ofp-util.c| 108

[ovs-dev] [PATCH v3 18/41] ofproto: Support OpenFlow1.4 flow monitor replies

2014-06-15 Thread Simon Horman
Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * Do not use OF1.4 paused and resumed messages for OF1.1 - OF1.3 --- ofproto/connmgr.c | 12 +++ ofproto/connmgr.h | 8 +--- ofproto/ofproto.c | 60 ++- 3 files changed, 55

[ovs-dev] [PATCH v3 21/41] ofp-parse: Provide helper to parse group id

2014-06-15 Thread Simon Horman
Provide and use helper to parse group id. This in preparation for adding group_out support to the parser for flow monitor requests. This also requires parsing of a group id. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * No change --- lib/ofp-parse.c | 48

[ovs-dev] [PATCH v3 12/41] ofp-print: Support printing of OF1.4 Flow Monitor Requests

2014-06-15 Thread Simon Horman
This is consists of extending and renaming existing code for NX flow monitor requests. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * No change --- lib/ofp-print.c| 68 +++--- tests/ofp-print.at | 12 ++ 2 files changed, 72

[ovs-dev] [PATCH v3 15/41] ofp-util: Use enum ofp14_flow_update_event in struct ofputil_flow_update

2014-06-15 Thread Simon Horman
checking. This is in preparation for supporting OpenFlow 1.4 flow monitor replies. Signed-off-by: Simon Horman ho...@verge.net.au --- v3 * Rebase v2 * No change --- lib/ofp-print.c | 14 +-- lib/ofp-util.c| 107 +++--- lib/ofp-util.h

[ovs-dev] [PATCH v3 13/41] ofputil: Support encoding OF1.4 flow monitor requests

2014-06-15 Thread Simon Horman
Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * Re-arrange case statement to group unsupported versions with default --- lib/ofp-util.c| 48 ++-- lib/ofp-util.h| 3 ++- utilities/ovs-ofctl.c | 6 +++--- 3 files changed, 51

[ovs-dev] [PATCH v3 14/41] ofproto: Add ofp14_flow_update_{header, event, full, abbrev, paused}

2014-06-15 Thread Simon Horman
This is in preparation for supporting OpenFlow1.4 flow monitor replies. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * No change --- include/openflow/openflow-1.4.h | 77 + 1 file changed, 77 insertions(+) diff --git a/include/openflow/openflow

[ovs-dev] [PATCH v3 24/41] ofp-parse: Allow parsing of flow monitor request's only_own flag

2014-06-15 Thread Simon Horman
This has the effect of exposing an new !other argument to ovs-ofctl's monitor subcommand for use with OpenFlow1.4+. A subsequent patch will update the documentation for ovs-ofctl. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * No change --- lib/ofp-parse.c | 3 +++ 1 file changed, 3

[ovs-dev] [PATCH v3 11/41] ofp-util: Add decoder for OF1.4 flow monitor request messages

2014-06-15 Thread Simon Horman
Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * No change --- lib/ofp-util.c | 103 +++-- 1 file changed, 92 insertions(+), 11 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 5c05c70..dd0c1ef 100644 --- a/lib/ofp-util.c

[ovs-dev] [PATCH v3 19/41] ofp-util: Support Decoding of OF14 Flow Monitor Replies

2014-06-15 Thread Simon Horman
Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * No change --- lib/ofp-util.c | 174 - 1 file changed, 147 insertions(+), 27 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index c2767fb..63f65c9 100644 --- a/lib/ofp

[ovs-dev] [PATCH v3 33/41] ofp-util: ofputil_flow_monitor_request abstracts onf13_flow_monitor_request

2014-06-15 Thread Simon Horman
Update documentation of ofputil_flow_monitor_request to note that it abstracts onf13_flow_monitor_request as well as {nx,ofp14}_flow_monitor_request. This is in preparation for supporting EXT-187: flow entry notification extension (ONF flow monitor). Signed-off-by: Simon Horman ho

[ovs-dev] [PATCH v3 26/41] ofproto: OF1.4 flow monitor tests

2014-06-15 Thread Simon Horman
Signed-off-by: Simon Horman ho...@verge.net.au --- v3 * Rebased v2 * Rebased * Remove spurious use of diff-flows * Consistently use a space in OpenFlow 1.4 --- tests/ofproto.at | 461 +++ 1 file changed, 461 insertions(+) diff --git a/tests

[ovs-dev] [PATCH v3 30/41] ofp-msg: Support decoding of ONF extensions for OF1.3

2014-06-15 Thread Simon Horman
This is in preparation for supporting EXT-187: flow entry notification extension (ONF flow monitor). Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- lib/ofp-msgs.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/lib/ofp-msgs.c

[ovs-dev] [PATCH v3 29/41] ofp-msg: Support encoding of ONF extensions for OF1.3

2014-06-15 Thread Simon Horman
This is in preparation for supporting EXT-187: flow entry notification extension (ONF flow monitor). Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- lib/ofp-msgs.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/lib/ofp-msgs.c b

[ovs-dev] [PATCH v3 25/41] ovs-ofctl: Document !other parameter of monitor subcommand

2014-06-15 Thread Simon Horman
This is now supported for OpenFlow1.4+. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * No change --- utilities/ovs-ofctl.8.in | 7 +++ 1 file changed, 7 insertions(+) diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in index 7019fc0..ea31fb9 100644 --- a/utilities/ovs

[ovs-dev] [PATCH v3 27/41] ofproto: Add OFPRAW_ONFST13_FLOW_*

2014-06-15 Thread Simon Horman
Add raw types for EXT-187: flow entry notification extension (ONF flow monitor). Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- lib/ofp-msgs.h | 53 + 1 file changed, 37 insertions(+), 16 deletions(-) diff --git a/lib

[ovs-dev] [PATCH v3 31/41] ofp-print: Test of EXT-187 cancel, paused and resumed messages

2014-06-15 Thread Simon Horman
Test printing of EXT-187: flow entry notification extension (ONF flow monitor) cancel, paused and resumed messages. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- tests/ofp-print.at | 28 1 file changed, 28 insertions(+) diff --git a/tests

[ovs-dev] [PATCH v3 28/41] ofproto: Add onf13_experimenter_{multipart_msg, header}

2014-06-15 Thread Simon Horman
This is in preparation for supporting EXT-187: flow entry notification extension (ONF flow monitor). Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- include/openflow/openflow-1.3.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/openflow

[ovs-dev] [PATCH v3 35/41] ofp-print: Test EXT-187 requests

2014-06-15 Thread Simon Horman
Test printing of EXT-187: flow entry notification (ONF flow monitors) requests. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- tests/ofp-print.at | 12 1 file changed, 12 insertions(+) diff --git a/tests/ofp-print.at b/tests/ofp-print.at index 2fc1e12

[ovs-dev] [PATCH v3 34/41] ofp-util: Support decoding of EXT-187 requests

2014-06-15 Thread Simon Horman
Support decoding of EXT-187: flow entry notification extension (ONF flow monitor) requests. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- lib/ofp-util.c | 58 ++ 1 file changed, 58 insertions(+) diff --git a/lib

[ovs-dev] [PATCH v3 37/41] ofp-util: Support decoding of EXT-187 replies

2014-06-15 Thread Simon Horman
Support decoding of EXT-187: flow entry notification extension (ONF flow monitor) replies. This re-uses existing Nicira extension code as other than the header the wire format is the same. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- lib/ofp-util.c | 3 ++- 1 file

[ovs-dev] [PATCH v3 39/41] ofp-util: Support encoding of EXT-187 replies

2014-06-15 Thread Simon Horman
Support encoding of EXT-187: flow entry notification extension (ONF flow monitor) replies. This re-uses existing Nicira extension code as other than the header the wire format is the same. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- lib/ofp-util.c | 6 -- 1 file

[ovs-dev] [PATCH v3 3/4] ofproto: Support multipart flow monitor requests

2014-06-15 Thread Simon Horman
Signed-off-by: Simon Horman ho...@verge.net.au --- lib/ofp-msgs.c| 3 +- ofproto/ofproto.c | 63 +++- tests/ofproto.at | 122 ++ 3 files changed, 167 insertions(+), 21 deletions(-) diff --git a/lib/ofp-msgs.c b

[ovs-dev] [PATCH v3 41/41] openflow: EXT-187 is now supported

2014-06-15 Thread Simon Horman
EXT-187: flow entry notification extension (ONF flow monitor) is now supported for OpenFlow1.3. OpenFlow1.4 flow monitor is also now supported. Signed-off-by: Simon Horman ho...@verge.net.au --- v3 * Rebase v2 * First post --- OPENFLOW-1.1+ | 6 -- 1 file changed, 6 deletions(-) diff

[ovs-dev] [PATCH v3 4/4] openflow: Multipart requests are now supported

2014-06-15 Thread Simon Horman
Signed-off-by: Simon Horman ho...@verge.net.au --- OPENFLOW-1.1+ | 4 1 file changed, 4 deletions(-) diff --git a/OPENFLOW-1.1+ b/OPENFLOW-1.1+ index 552f83d..51155c2 100644 --- a/OPENFLOW-1.1+ +++ b/OPENFLOW-1.1+ @@ -82,10 +82,6 @@ following additional work. (This is based on the change

[ovs-dev] [PATCH v3 1/4] ofp-msg: Add helpers for allowing multipart requests

2014-06-15 Thread Simon Horman
Add helpers for allowing requests and use them in handle_openflow__(). This is a in preparation for supporting multipart requests on a per message type basis. Signed-off-by: Simon Horman ho...@verge.net.au --- lib/ofp-msgs.c| 34 ++ lib/ofp-msgs.h| 2

[ovs-dev] [PATCH v3 36/41] ofp-util: Support encoding of EXT-187 requests

2014-06-15 Thread Simon Horman
Support encoding of EXT-187: flow entry notification extension (ONF flow monitor) requests. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- lib/ofp-util.c| 29 - ofproto/ofproto.c | 21 + 2 files changed, 41 insertions

[ovs-dev] [PATCH v3 0/4] Support multipart requests with multiple parts

2014-06-15 Thread Simon Horman
this patch-set and its dependencies are available in git at https://github.com/horms/openvswitch.git devel/multipart-request-v3 Simon Horman (4): ofp-msg: Add helpers for allowing multipart requests connmgr: Buffer multipart requests ofproto: Support multipart flow monitor requests

[ovs-dev] [PATCH v3 38/41] ofp-print: Test of EXT-187 replies

2014-06-15 Thread Simon Horman
Test printing of EXT-187: flow entry notification extension (ONF flow monitor) replies. Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- tests/ofp-print.at | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tests/ofp-print.at b/tests/ofp-print.at index

[ovs-dev] [PATCH v3 2/4] connmgr: Buffer multipart requests

2014-06-15 Thread Simon Horman
request support to individual message types. Signed-off-by: Simon Horman ho...@verge.net.au --- v3 * Rebase * Correct type of hash parameter to ofmp_req_find, it should be uint32_t rather than ovs_be32 as the value is in host byte order. v2 * Use ofpmsg_may_buffer_mp_request() to only buffer

[ovs-dev] [PATCH v3 40/41] ofproto: EXT-187 tests

2014-06-15 Thread Simon Horman
Signed-off-by: Simon Horman ho...@verge.net.au --- v2 * First post --- tests/ofproto.at | 345 +++ 1 file changed, 345 insertions(+) diff --git a/tests/ofproto.at b/tests/ofproto.at index e175e7b..af48809 100644 --- a/tests/ofproto.at +++ b

Re: [ovs-dev] [PATCH v3 0/4] Support multipart requests with multiple parts

2014-06-16 Thread Simon Horman
that this and the EXT-187 series will suffer some delay in review. On Jun 15, 2014 7:33 PM, Simon Horman ho...@verge.net.au wrote: This purpose of this patchset is to provide support for multipart requests with more than one part. It does so in three phases: 1. Adds infrastructure for buffering multipart

Re: [ovs-dev] [PATCH v2.60] datapath: Add basic MPLS support to kernel

2014-06-17 Thread Simon Horman
Hi Jesse, I think this is getting pretty close. Is there anything I can do to help edge it over the line? On Fri, Jun 06, 2014 at 07:28:51PM +0900, Simon Horman wrote: Allow datapath to recognize and extract MPLS labels into flow keys and execute actions which push, pop, and set labels

Re: [ovs-dev] [PATCH v2.60] datapath: Add basic MPLS support to kernel

2014-06-18 Thread Simon Horman
On Tue, Jun 17, 2014 at 11:02:21PM -0700, Jesse Gross wrote: I'm currently seeing this compiler error: CC [M] /home/jesse/openvswitch/datapath/linux/gso.o /home/jesse/openvswitch/datapath/linux/gso.c: In function ‘tnl_skb_gso_segment’: /home/jesse/openvswitch/datapath/linux/gso.c:199:2:

[ovs-dev] [PATCH v2.61] datapath: Add basic MPLS support to kernel

2014-06-18 Thread Simon Horman
yamah...@valinux.co.jp Cc: Joe Stringer j...@wand.net.nz Signed-off-by: Simon Horman ho...@verge.net.au --- v2.61 * Rebase - Update key_attr_size accordingly * Clean up fallout from increasing coverage of compatibility code from v3.11 to v3.16 v2.60 * Add missing break statement

Re: [ovs-dev] [PATCH] ofproto: Honour out_port of flow monitors

2014-06-23 Thread Simon Horman
On Mon, Jun 23, 2014 at 02:38:50PM -0700, Ben Pfaff wrote: On Sat, Jun 14, 2014 at 08:33:13AM +0900, Simon Horman wrote: Previously the out_port of a flow monitor was checked in ofmonitor_report() using ofoperation_has_out_port(). When ofoperation_has_out_port() was removed so

Re: [ovs-dev] [PATCH v7 1/3] ofproto-dpif: MPLS recirculation

2014-06-23 Thread Simon Horman
On Mon, Jun 23, 2014 at 02:50:20PM -0700, Ben Pfaff wrote: On Mon, Jun 16, 2014 at 10:09:38AM +0900, Simon Horman wrote: In some cases an pop MPLS action changes a packet to be a non-mpls packet. In this case subsequent any L3+ actions require access to portions of the packet which were

[ovs-dev] [PATCH v8 0/3] Flow-Based Recirculation for MPLS

2014-06-23 Thread Simon Horman
it for recirculation for bonding Key changes between v1 and v2 * Support for: packet_out and patch ports * More tests To aid review this series and its dependencies are available in git https://github.com/horms/openvswitch devel/mpls-flow-based-recirculation-v8 Simon Horman (3): ofproto-dpif: MPLS

[ovs-dev] [PATCH v8 2/3] ofp-actions: Allow pop_mpls on MPLS packets

2014-06-23 Thread Simon Horman
With recirculation in place this should be safe. Signed-off-by: Simon Horman ho...@verge.net.au Acked-by: Ben Pfaff b...@nicira.com --- v8 * Add Ack from Ben Pfaff v2 - v7 * No change --- lib/ofp-actions.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/ofp-actions.c b/lib/ofp

[ovs-dev] [PATCH v8 1/3] ofproto-dpif: MPLS recirculation

2014-06-23 Thread Simon Horman
. Co-authored-by: Ben Pfaff b...@nicira.com Signed-off-by: Ben Pfaff b...@nicira.com Signed-off-by: Simon Horman ho...@verge.net.au --- v8 * As suggested in Ben Pfaff - Unconditionally set ctx-exit in compose_recirculate_action() v7 * New approach to determining if recirculation should occur

Re: [ovs-dev] [PATCH v7 1/3] ofproto-dpif: MPLS recirculation

2014-06-23 Thread Simon Horman
On Mon, Jun 23, 2014 at 03:58:28PM -0700, Ben Pfaff wrote: On Mon, Jun 23, 2014 at 3:55 PM, Simon Horman ho...@verge.net.au wrote: On Mon, Jun 23, 2014 at 02:50:20PM -0700, Ben Pfaff wrote: On Mon, Jun 16, 2014 at 10:09:38AM +0900, Simon Horman wrote: In some cases an pop MPLS action

Re: [ovs-dev] [PATCH v3 01/41] ofproto: Use ofp14_flow_monitor_flags internally

2014-06-24 Thread Simon Horman
On Mon, Jun 23, 2014 at 03:11:57PM -0700, Ben Pfaff wrote: On Mon, Jun 16, 2014 at 11:29:21AM +0900, Simon Horman wrote: Use enum ofp14_flow_monitor_flags in place of enum nx_flow_monitor_flags in struct ofputil_flow_monitor_request and struct rule, translating between the two enumerations

Re: [ovs-dev] [PATCH v3 08/41] ofproto: Use list when handling monitor requests

2014-06-24 Thread Simon Horman
On Mon, Jun 23, 2014 at 05:00:53PM -0700, Ben Pfaff wrote: On Mon, Jun 16, 2014 at 11:29:28AM +0900, Simon Horman wrote: Use a list rather than an array to track monitor requests in handle_flow_monitor_request(). This is in preparation for supporting OpenFlow1.4 flow monitor requests

[ovs-dev] [PATCH v2.62] datapath: Add basic MPLS support to kernel

2014-06-24 Thread Simon Horman
yamah...@valinux.co.jp Cc: Joe Stringer j...@wand.net.nz Signed-off-by: Simon Horman ho...@verge.net.au --- v2.62 * Rebase v2.61 * Rebase - Update key_attr_size accordingly * Clean up fallout from increasing coverage of compatibility code from v3.11 to v3.16 v2.60 * Add missing break

Re: [ovs-dev] [PATCH v2.62] datapath: Add basic MPLS support to kernel

2014-06-24 Thread Simon Horman
On Tue, Jun 24, 2014 at 04:24:37PM -0700, Jesse Gross wrote: On Tue, Jun 24, 2014 at 4:56 AM, Simon Horman ho...@verge.net.au wrote: Allow datapath to recognize and extract MPLS labels into flow keys and execute actions which push, pop, and set labels on packets. Based heavily on work

Re: [ovs-dev] [PATCH v3 08/41] ofproto: Use list when handling monitor requests

2014-06-24 Thread Simon Horman
On Tue, Jun 24, 2014 at 07:50:24AM -0700, Ben Pfaff wrote: On Tue, Jun 24, 2014 at 05:22:08PM +0900, Simon Horman wrote: On Mon, Jun 23, 2014 at 05:00:53PM -0700, Ben Pfaff wrote: On Mon, Jun 16, 2014 at 11:29:28AM +0900, Simon Horman wrote: Use a list rather than an array to track

Re: [ovs-dev] [PATCH v3 02/41] connmgr: Support OFPFMF14_ONLY_OWN

2014-06-25 Thread Simon Horman
On Mon, Jun 23, 2014 at 03:16:59PM -0700, Ben Pfaff wrote: On Mon, Jun 16, 2014 at 11:29:22AM +0900, Simon Horman wrote: If the ONLY_OWN flag of a flow monitor is set then ofmonitor_report should skip sending updates to other controllers. This is in preparation for supporting OpenFlow1.4

Re: [ovs-dev] [PATCH v3 10/41] ofproto: Handle monitor and delete commands in flow monitor requests

2014-06-25 Thread Simon Horman
On Mon, Jun 23, 2014 at 05:14:52PM -0700, Ben Pfaff wrote: On Mon, Jun 16, 2014 at 11:29:30AM +0900, Simon Horman wrote: Handle modify and delete commands in OpenFlow1.4 flow monitor requests. These commands are not yet allowed by the decoder which will be updated by a subsequent patch

Re: [ovs-dev] [PATCH v8 0/3] Flow-Based Recirculation for MPLS

2014-06-25 Thread Simon Horman
On Wed, Jun 25, 2014 at 02:19:38PM -0700, Ben Pfaff wrote: On Tue, Jun 24, 2014 at 08:46:30AM +0900, Simon Horman wrote: The motivation of this series is to allow some sequences of actions that include MPLS actions to be performed using recirculation. Sequences of actions that could

<    1   2   3   4   5   6   7   8   9   10   >