On Thu, Aug 29, 2013 at 09:54:40PM -0700, Ben Pfaff wrote:
On Fri, Aug 30, 2013 at 01:48:15PM +0900, Simon Horman wrote:
On Thu, Aug 29, 2013 at 02:00:51PM -0700, Ben Pfaff wrote:
From: Neil Zhu z...@centecnetworks.com
This doesn't include a dpif implementation of groups functionality
On Thu, Aug 29, 2013 at 02:00:51PM -0700, Ben Pfaff wrote:
From: Neil Zhu z...@centecnetworks.com
This doesn't include a dpif implementation of groups functionality. In its
current form, it is untested. Before this is committed, it needs some
more comments and an ovs-ofctl manpage update.
Signed-off-by: Simon Horman ho...@verge.net.au
---
Ben, feel free to squash this into 'Implement OpenFlow 1.1+ groups protocol'.
---
utilities/ovs-ofctl.8.in | 108 +++
1 file changed, 108 insertions(+)
diff --git a/utilities/ovs-ofctl.8.in b
On Fri, Aug 30, 2013 at 09:15:19AM -0700, Ben Pfaff wrote:
On Fri, Aug 30, 2013 at 05:42:54PM +0900, Simon Horman wrote:
Signed-off-by: Simon Horman ho...@verge.net.au
---
Ben, feel free to squash this into 'Implement OpenFlow 1.1+ groups
protocol'.
Thanks, done. I added your
includes duration also.
Signed-off-by: Ben Pfaff b...@nicira.com
Reviewed-by: Simon Horman ho...@verge.net.au
---
OPENFLOW-1.1+ | 18 --
1 file changed, 18 deletions(-)
diff --git a/OPENFLOW-1.1+ b/OPENFLOW-1.1+
index 753dbba..aacbca9 100644
--- a/OPENFLOW-1.1+
+++ b
On Fri, Aug 30, 2013 at 01:40:16PM -0700, Jarno Rajahalme wrote:
Indirect groups can have at most one bucket.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
Reviewed-by: Simon Horman ho...@verge.net.au
---
lib/ofp-parse.c | 14 +++---
1 file changed, 11 insertions(+), 3
On Fri, Aug 30, 2013 at 01:40:17PM -0700, Jarno Rajahalme wrote:
Also, since all kinds of groups can refer to other groups, there is no
reason to delete indirect groups first.
This seems reasonable to me, but its not clear to me
how the code prevents the deletion of groups that
are still
On Wed, Aug 28, 2013 at 05:45:28PM +0900, Simon Horman wrote:
Hi Ethan,
On Wed, Aug 28, 2013 at 12:25:31AM -0700, Ethan Jackson wrote:
In short, it would make my life much easier if facets could be looked up
execute_flow_miss(). And I am interested to know if you have any plans
from Centec Networks, with
some support from Simon Horman. (I hope to commit this before
the hackathon begins.)
* Simon Horman is working on MPLS.
Unclaimed Tasks (Small, Required)
-
The following tasks could use volunteers. These tasks
On Sun, Sep 01, 2013 at 06:24:39PM -0700, Ben Pfaff wrote:
On Sat, Aug 31, 2013 at 02:11:39PM +0900, Simon Horman wrote:
On Fri, Aug 30, 2013 at 01:40:17PM -0700, Jarno Rajahalme wrote:
Also, since all kinds of groups can refer to other groups, there is no
reason to delete indirect groups
Adjust formatting in ovs-ofctl so that apply_actions, clear_actions
write_metadata and goto_table appear at the same level
of indentation as actions rather being indented as if
they are arguments to the learn action.
Signed-off-by: Simon Horman ho...@verge.net.au
---
utilities/ovs-ofctl.8.in | 2
struct ofputil_group_stats
and instead allowing an instance of that structure to be
followed by an any number of struct bucket_counter.
Signed-off-by: Simon Horman ho...@verge.net.au
---
Ben, feel free to squash this patch into
Implement OpenFlow 1.1+ groups protocol if it is
to your liking.
Compile
This is a first step towards implementing the dpif side of groups.
In order to be useful the action translation code needs
to be taught about groups.
Compile tested only.
Signed-off-by: Simon Horman ho...@verge.net.au
---
ofproto/ofproto-dpif.c | 111
Adjust formatting in ovs-ofctl so that apply_actions, clear_actions
write_metadata and goto_table appear at the same level
of indentation as actions rather being indented as if
they are arguments to the learn action.
Signed-off-by: Simon Horman ho...@verge.net.au
---
utilities/ovs-ofctl.8.in | 2
Use enum ofp11_group_type for the 'type' field of struct ofgroup
as the enum exactly covers all the valid values of the field.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* First post
---
ofproto/ofproto-provider.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Hi,
This series is comprised of three components.
A. Enhance existing ofproto group code
[PATCH v2 1/5] Use enum ofp11_group_type in struct ofgroup
[PATCH v2 2/5] ovs-ofctl: Handle any number of buckets in group statistics
B. Support write actions.
With this in place it is possible
set_field in write_actions.
Another possible solution is prohibit problematic the actions listed above
in write actions.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* First post
---
lib/ofp-actions.c| 345 +--
lib/ofp-actions.h
This is a first step towards implementing the dpif side of groups.
In order to be useful the action translation code needs
to be taught about groups.
Compile tested only.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* Corrected group_construct_stats() to allocate stats
is effectively cloned for each bucket; one
packet is processed for each bucket of the group.
* On indirect groups: This group type is effectively identical to an
all group with one bucket.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* First post
---
ofproto/ofproto-dpif-xlate.c | 116
struct ofputil_group_stats
and instead allowing an instance of that structure to be
followed by an any number of struct bucket_counter.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
lib/ofp-print.c | 26 +++---
lib/ofp-util.c| 45
On Wed, Sep 04, 2013 at 04:31:35PM -0700, Ben Pfaff wrote:
On Mon, Sep 02, 2013 at 11:28:10AM +0900, Simon Horman wrote:
struct ofputil_group_stats has an arbitrary limit
of 16 buckets for which it can record statistics.
However the code does not appear to enforce this
limit and it seems
set_field in write_actions.
Another possible solution is prohibit problematic the actions listed above
in write actions.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v3
* No change
v2
* First post
---
lib/ofp-actions.c| 345 +--
lib/ofp
This is a first step towards implementing the dpif side of groups.
In order to be useful the action translation code needs
to be taught about groups.
Compile tested only.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v3
* Rebase for ofproto-dpif: Hide struct rule_dpif internally
* Hide
is effectively cloned for each bucket; one
packet is processed for each bucket of the group.
* On indirect groups: This group type is effectively identical to an
all group with one bucket.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v3
* Rebase for ofproto-dpif: Hide struct rule_dpif
ofputil_group_stats
from a fixed length array to a pointer whose storage is allocated and freed
as necessary.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v3
* As suggested by Ben Pfaff
- Vastly simplify the change by using an explicit pointer for
the 'bucket_stats' member of struct
Use enum ofp11_group_type for the 'type' field of struct ofgroup
as the enum exactly covers all the valid values of the field.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v3
* No change
v2
* First post
---
ofproto/ofproto-provider.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Hi,
This series is comprised of three components.
A. Enhance existing ofproto group code
[PATCH v2 1/5] Use enum ofp11_group_type in struct ofgroup
[PATCH v2 2/5] ovs-ofctl: Handle any number of buckets in group statistics
B. Support write actions.
With this in place it is possible
On Wed, Aug 28, 2013 at 04:14:32PM +0900, Simon Horman wrote:
On Fri, Aug 23, 2013 at 01:16:50PM +1000, Simon Horman wrote:
Hi,
This series implements MPLS actions and matches based on work by
Ravi K, Leo Alterman, Yamahata-san and Joe Stringer.
This series provides two changes
Correct indentation of rule_dpif_{release,credit_stats} prototypes.
This corrects a cosmetic problem introduced by
70742c7f54e7f147 (ofproto-dpif: Hide struct rule_dpif internally.).
Cc: Ethan Jackson et...@nicira.com
Signed-off-by: Simon Horman ho...@verge.net.au
---
Compile tested only
On Thu, Sep 05, 2013 at 03:24:20PM -0700, Jarno Rajahalme wrote:
On Sep 4, 2013, at 10:19 PM, Simon Horman ho...@verge.net.au wrote:
Implementation note:
All actions which modify a field are added to the action set
at the point where set actions should be added. In general
miss support,
which is related.)
* Simon Horman is working on MPLS.
* Alexandru Copot alex.miha...@gmail.com is working on
OFPT_GET_ASYNC_REQUEST and OFPT_GET_ASYNC_REPLY.
* Simon Horman is working on implementing the Write-Actions
instruction (and has
Hi Jesse,
I have been looking at updating the recirculation implementation for
currently merged multi-threaded miss handling and planned changes by
Ethan to remove facts from ovs-vswtichd. I would like this chance to
thank Ethan for sharing his plans with me in some detail, it has been
very
On Thu, Sep 05, 2013 at 04:12:39PM -0700, Jarno Rajahalme wrote:
On Sep 4, 2013, at 10:19 PM, Simon Horman ho...@verge.net.au wrote:
Allow translation of indirect and all groups.
Also allow insertion of indirect and all groups by
changing the maximum permitted number in the groups
On Thu, Sep 05, 2013 at 12:58:40PM -0700, Ben Pfaff wrote:
On Thu, Sep 05, 2013 at 12:55:28PM -0700, Ben Pfaff wrote:
On Thu, Sep 05, 2013 at 02:19:13PM +0900, Simon Horman wrote:
struct ofputil_group_stats has an arbitrary limit
of 16 buckets for which it can record statistics
On Thu, Sep 05, 2013 at 08:52:40PM -0700, Ben Pfaff wrote:
On Fri, Sep 06, 2013 at 10:57:26AM +0900, Simon Horman wrote:
On Thu, Sep 05, 2013 at 12:58:40PM -0700, Ben Pfaff wrote:
On Thu, Sep 05, 2013 at 12:55:28PM -0700, Ben Pfaff wrote:
On Thu, Sep 05, 2013 at 02:19:13PM +0900, Simon
looked over this and nothing jumped out at me.
Reviewed-by: Simon Horman ho...@verge.net.au
include/linux/openvswitch.h |3 +
lib/dpif-linux.c | 40 ++
lib/dpif-netdev.c| 306
+-
lib/dpif-provider.h | 28
to be one
location the enum is currently useful. None the less this ought to help the
compiler to help us to make sure all cases continue to be covered in future.
Signed-off-by: Simon Horman ho...@verge.net.au
---
lib/ofp-print.c | 7 +--
lib/ofp-util.h | 2 +-
2 files changed, 6 insertions(+), 3
From: Joe Stringer j...@wand.net.nz
This allows for future patches to pass different tci values to
commit_vlan_action() without passing an entire flow structure.
Signed-off-by: Joe Stringer j...@wand.net.nz
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2.36 - v2.39
* No change
v2.35
From: Joe Stringer j...@wand.net.nz
This patch adds a new compatibility enum for use with MPLS, so that the
differing behaviour between OpenFlow 1.2 and 1.3 can be implemented in
ofproto-dpif-xlate.
Signed-off-by: Joe Stringer j...@wand.net.nz
Signed-off-by: Simon Horman ho...@verge.net.au
.
For push_mpls, ofpact_push_mpls.ofpact.compat is set to
OFPUTIL_OFPAT13_PUSH_MPLS, which allows correct VLAN+MPLS datapath
behaviour to be determined at odp translation time.
Signed-off-by: Joe Stringer j...@wand.net.nz
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2.36 - v2.39
* No change
v2.35
-off-by: Joe Stringer j...@wand.net.nz
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2.38 - v2.39
* No change
v2.37
* Rebase
v2.36
* No change
v2.5
* First post
---
lib/odp-util.c | 10 ++-
lib/odp-util.h | 4 +-
ofproto/ofproto-dpif-xlate.c | 95
yamah...@valinux.co.jp
Cc: Joe Stringer j...@wand.net.nz
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2.39
* Rebase for removal of vlan, checksum and skb-mark compat code
v2.38
* Rebase for SCTP support
* Refactor validate_tp_port() to iterate over eth_types rather
than open-coding
:
Joe Stringer (5):
odp: Only pass vlan_tci to commit_vlan_action()
odp: Allow VLAN actions after MPLS actions
ofp-actions: Add OFPUTIL_OFPAT13_PUSH_MPLS
ofp-actions: Add separate OpenFlow 1.3 action parser
lib: Push MPLS tags in the OpenFlow 1.3 ordering
Simon Horman (1):
datapath: Add
Break out deacceleration portion of vlan_push into vlan_put
so that it may be re-used by mpls_push.
For both vlan_push and mpls_push if there is an accelerated VLAN tag
present then it should be deaccelerated, adding it to the data of
the skb, before the new tag is added.
Signed-off-by: Simon
-off-by: Joe Stringer j...@wand.net.nz
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2.36 - v2.39
* No change
v2.35
* First post
---
lib/flow.c | 2 +-
lib/packets.c| 10 +-
lib/packets.h| 2 +-
ofproto/ofproto-dpif-xlate.c | 10
On Mon, Sep 09, 2013 at 04:20:00PM +0900, Simon Horman wrote:
Hi,
This series implements MPLS actions and matches based on work by
Ravi K, Leo Alterman, Yamahata-san and Joe Stringer.
This series provides two changes
* Provide user-space support for the VLAN/MPLS tag insertion order
change.
On Sun, Sep 8, 2013 at 6:28 PM, Simon Horman ho...@verge.net.au wrote:
It seems convenient and in keeping with other Open vSwtich code to use enum
ofp11_table_config as the type of the config field in struct
ofputil_table_mod.
Although the presence of OFPTC11_TABLE_MISS_MASK
On Thu, Sep 12, 2013 at 12:06:36PM -0700, Ben Pfaff wrote:
I've totally lost track of the status of this patch series. I assume it
needs Jesse's review. Jesse, if I'm wrong about that, let me know and
I'll take a pass at it.
My understanding is that you have looked over the approach
taken
On Fri, Sep 13, 2013 at 03:07:12PM -0700, Jesse Gross wrote:
On Mon, Sep 9, 2013 at 12:20 AM, Simon Horman ho...@verge.net.au wrote:
diff --git a/datapath/actions.c b/datapath/actions.c
index 30ea1d2..6741d81 100644
--- a/datapath/actions.c
+++ b/datapath/actions.c
@@ -105,22 +105,29
On Fri, Sep 13, 2013 at 03:15:17PM -0700, Jesse Gross wrote:
On Thu, Sep 12, 2013 at 3:54 PM, Ben Pfaff b...@nicira.com wrote:
On Fri, Sep 13, 2013 at 07:56:14AM +0900, Simon Horman wrote:
On Thu, Sep 12, 2013 at 12:06:36PM -0700, Ben Pfaff wrote:
I've totally lost track of the status
On Mon, Sep 16, 2013 at 01:46:19PM -0700, Ben Pfaff wrote:
On Mon, Sep 16, 2013 at 03:38:21PM -0500, Jesse Gross wrote:
- Ben, do you want to take over for the userspace portions of the
series on the assumption that the above comments can be fixed fairly
easily?
Yes, that's fine.
On Tue, Sep 17, 2013 at 11:38:18AM -0700, Pravin Shelar wrote:
On Mon, Sep 9, 2013 at 12:20 AM, Simon Horman ho...@verge.net.au wrote:
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work
On Fri, Sep 13, 2013 at 03:07:12PM -0700, Jesse Gross wrote:
On Mon, Sep 9, 2013 at 12:20 AM, Simon Horman ho...@verge.net.au wrote:
diff --git a/datapath/actions.c b/datapath/actions.c
index 30ea1d2..6741d81 100644
--- a/datapath/actions.c
+++ b/datapath/actions.c
@@ -105,22 +105,29
On Mon, Sep 16, 2013 at 03:38:21PM -0500, Jesse Gross wrote:
On Mon, Sep 9, 2013 at 12:20 AM, Simon Horman ho...@verge.net.au wrote:
diff --git a/datapath/actions.c b/datapath/actions.c
index 6741d81..2335014 100644
--- a/datapath/actions.c
+++ b/datapath/actions.c
+/* Push MPLS after
On Wed, Sep 18, 2013 at 05:07:59PM -0500, Simon Horman wrote:
On Tue, Sep 17, 2013 at 11:38:18AM -0700, Pravin Shelar wrote:
On Mon, Sep 9, 2013 at 12:20 AM, Simon Horman ho...@verge.net.au wrote:
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which
On Thu, Sep 19, 2013 at 12:21:33PM -0500, Jesse Gross wrote:
On Thu, Sep 19, 2013 at 10:57 AM, Simon Horman ho...@verge.net.au wrote:
On Mon, Sep 16, 2013 at 03:38:21PM -0500, Jesse Gross wrote:
On Mon, Sep 9, 2013 at 12:20 AM, Simon Horman ho...@verge.net.au wrote:
@@ -616,6 +736,13
On Thu, Sep 19, 2013 at 12:31:51PM -0500, Jesse Gross wrote:
On Wed, Sep 18, 2013 at 5:07 PM, Simon Horman ho...@verge.net.au wrote:
On Tue, Sep 17, 2013 at 11:38:18AM -0700, Pravin Shelar wrote:
On Mon, Sep 9, 2013 at 12:20 AM, Simon Horman ho...@verge.net.au wrote:
diff --git a/datapath
On Mon, Sep 23, 2013 at 02:17:50PM -0700, Jesse Gross wrote:
On Sat, Sep 21, 2013 at 10:34 PM, Simon Horman ho...@verge.net.au wrote:
On Thu, Sep 19, 2013 at 12:21:33PM -0500, Jesse Gross wrote:
On Thu, Sep 19, 2013 at 10:57 AM, Simon Horman ho...@verge.net.au wrote:
On Mon, Sep 16, 2013
On Mon, Sep 23, 2013 at 02:24:31PM -0700, Jesse Gross wrote:
On Mon, Sep 23, 2013 at 12:47 PM, Pravin Shelar pshe...@nicira.com wrote:
This patch does not work since vport-netdev does not include compat
gso header. after including gso.h it gives me compiler error.
Can you post combined
On Mon, Sep 23, 2013 at 06:38:23PM -0700, Jesse Gross wrote:
On Mon, Sep 23, 2013 at 6:32 PM, Simon Horman ho...@verge.net.au wrote:
On Mon, Sep 23, 2013 at 02:17:50PM -0700, Jesse Gross wrote:
On Sat, Sep 21, 2013 at 10:34 PM, Simon Horman ho...@verge.net.au wrote:
On Thu, Sep 19, 2013
Push vlan tag onto packet before segmentation to simplify the code.
As suggested by Pravin Shelar and Jesse Gross.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
datapath/vport-netdev.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions(-)
diff
As suggested by Jesse Gross and Pravin Shelar
in the course of the review of [PATCH v2.39 0/7] MPLS actions and matches.
This series applies on top of the master branch.
Simon Horman (2):
datapath: simplify VLAN segmentation
datapath: Move segmentation compatibility code into a compatibility
always returns the length of the original skb.
Signed-off-by: Simon Horman ho...@verge.net.au
--
v2
- Remove stray '// 1'
- Move rpl_dev_queue_xmit definition from gso.h to linux/netdevice.h
- Correct compilation errors with kernels older than 2.6.27
---
datapath/linux/compat/gso.c
) in compose_mpls_pop_action(()
if the actions of a flow include pop_mpls twice without
a push_mpls in between.
Signed-off-by: Simon Horman ho...@verge.net.au
---
lib/flow.c | 6 ++-
lib/flow.h | 9 ++--
lib/match.c | 2 +-
lib/nx-match.c
On Tue, Sep 24, 2013 at 08:42:50AM -0700, Ben Pfaff wrote:
On Tue, Sep 24, 2013 at 04:51:35PM +0900, Simon Horman wrote:
Rather than tracking the MPLS depth as a field in the
flow, which is an entirely poor place for it, just track
the delta to the MPLS depth during translation
eth_mpls_depth() has been unused as of 1ac7c9bdb2b6fdcb (ofproto-dpif: Use
execute_actions to execute controller actions).
Signed-off-by: Simon Horman ho...@verge.net.au
---
lib/packets.c | 26 --
lib/packets.h | 2 --
2 files changed, 28 deletions(-)
diff --git a/lib
The sole purpose of this change is to avoid sparse warnings
about memset of zero length in the case where the zero field
of struct flow is zero bytes long, as is the case after
Remove mpls_depth field from flow.
Signed-off-by: Simon Horman ho...@verge.net.au
---
This patch could trivially
) in compose_mpls_pop_action(()
if the actions of a flow include pop_mpls twice without
a push_mpls in between.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* As suggested by Ben Pfaff
- Move pre_push_mpls_lse fron a local variable of do_xlate_actions()
to a field of struct xlate_ctx
resubmit
and goto table actions.
- Move removal of eth_mpls_depth() into a separate patch.
It is not strictly related to this change.
- Correct spelling errors
[PATCH 2/2] flow: Add helper to zero padding of flow
* New and entirely optional patch
See changelog for details
Simon Horman (2
On Wed, Sep 25, 2013 at 09:03:17AM -0700, Ben Pfaff wrote:
On Wed, Sep 25, 2013 at 08:57:08AM -0700, Ben Pfaff wrote:
On Wed, Sep 25, 2013 at 01:31:08PM +0900, Simon Horman wrote:
The sole purpose of this change is to avoid sparse warnings
about memset of zero length in the case where
On Wed, Sep 25, 2013 at 09:09:27AM -0700, Ben Pfaff wrote:
On Wed, Sep 25, 2013 at 01:31:07PM +0900, Simon Horman wrote:
Rather than tracking the MPLS depth as a field in the
flow, which is an entirely poor place for it, just track
the delta to the MPLS depth during translation
On Wed, Sep 25, 2013 at 06:21:30PM -0700, Jesse Gross wrote:
On Tue, Sep 24, 2013 at 12:44 AM, Simon Horman ho...@verge.net.au wrote:
Move segmentation compatibility code out of netdev_send and into
rpl_dev_queue_xmit(), a compatibility function used in place
of dev_queue_xmit
On Thu, Sep 26, 2013 at 09:42:20AM +0900, Simon Horman wrote:
On Wed, Sep 25, 2013 at 09:09:27AM -0700, Ben Pfaff wrote:
On Wed, Sep 25, 2013 at 01:31:07PM +0900, Simon Horman wrote:
Rather than tracking the MPLS depth as a field in the
flow, which is an entirely poor place for it, just
On Thu, Sep 26, 2013 at 12:24:56PM -0700, Ben Pfaff wrote:
On Thu, Sep 26, 2013 at 05:34:49PM +0900, Simon Horman wrote:
On Thu, Sep 26, 2013 at 09:42:20AM +0900, Simon Horman wrote:
On Wed, Sep 25, 2013 at 09:09:27AM -0700, Ben Pfaff wrote:
On Wed, Sep 25, 2013 at 01:31:07PM +0900
) in compose_mpls_pop_action(()
if the actions of a flow include pop_mpls twice without
a push_mpls in between.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v3
* As suggested by Ben Pfaff
- Remove empty zeros field from struct flow
v2
* As suggested by Ben Pfaff
- Move pre_push_mpls_lse
From: Joe Stringer j...@wand.net.nz
This patch adds a new compatibility enum for use with MPLS, so that the
differing behaviour between OpenFlow 1.2 and 1.3 can be implemented in
ofproto-dpif-xlate.
Signed-off-by: Joe Stringer j...@wand.net.nz
Signed-off-by: Simon Horman ho...@verge.net.au
separate OpenFlow 1.3 action parser
lib: Push MPLS tags in the OpenFlow 1.3 ordering
Simon Horman (2):
datapath: Break out deacceleration portion of vlan_push
datapath: Add basic MPLS support to kernel
datapath/Modules.mk | 1 +
datapath/actions.c
yamah...@valinux.co.jp
Cc: Joe Stringer j...@wand.net.nz
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2.40
* Rebase for:
+ New dev_queue_xmit compat code
+ Updated put_vlan()
* As suggested by Jesse Gross
+ Remove bogus mac_len update from push_mpls()
+ Slightly simplify push_mpls
From: Joe Stringer j...@wand.net.nz
This allows for future patches to pass different tci values to
commit_vlan_action() without passing an entire flow structure.
Signed-off-by: Joe Stringer j...@wand.net.nz
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2.36 - v2.39
* No change
v2.35
Break out deacceleration portion of vlan_push into vlan_put
so that it may be re-used by mpls_push.
For both vlan_push and mpls_push if there is an accelerated VLAN tag
present then it should be deaccelerated, adding it to the data of
the skb, before the new tag is added.
Signed-off-by: Simon
-off-by: Joe Stringer j...@wand.net.nz
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2.40
* Rebase for removal of mpls_depth from struct flow
v2.38 - v2.39
* No change
v2.37
* Rebase
v2.36
* No change
v2.5
* First post
---
lib/odp-util.c | 9 +-
lib/odp-util.h
On Sun, Sep 29, 2013 at 02:51:19PM +1300, Joe Stringer wrote:
On Sat, Sep 28, 2013 at 7:21 AM, Ben Pfaff b...@nicira.com wrote:
On Fri, Sep 27, 2013 at 09:18:31AM +0900, Simon Horman wrote:
From: Joe Stringer j...@wand.net.nz
OpenFlow 1.2 and 1.3 differ on their handling of MPLS
On Fri, Sep 27, 2013 at 12:30:10PM -0700, Ben Pfaff wrote:
On Fri, Sep 27, 2013 at 09:18:32AM +0900, Simon Horman wrote:
From: Joe Stringer j...@wand.net.nz
This patch adds a new compatibility enum for use with MPLS, so that the
differing behaviour between OpenFlow 1.2 and 1.3 can
On Fri, Sep 27, 2013 at 12:41:19PM -0700, Ben Pfaff wrote:
On Fri, Sep 27, 2013 at 09:18:33AM +0900, Simon Horman wrote:
From: Joe Stringer j...@wand.net.nz
This patch adds new ofpact_from_openflow13() and
ofpacts_from_openflow13() functions parallel to the existing ofpact
handling
On Wed, Sep 25, 2013 at 08:54:31AM -0700, Ben Pfaff wrote:
On Tue, Sep 24, 2013 at 04:45:14PM -0700, Ethan Jackson wrote:
Both the IPFIX and SFLOW modules are thread safe, so there's no
particular reason to pass them up to the main thread. Eliminating
this step significantly simplifies the
On Mon, Sep 30, 2013 at 09:45:25PM -0700, Ben Pfaff wrote:
On Tue, Oct 01, 2013 at 01:23:20PM +0900, Simon Horman wrote:
On Wed, Sep 25, 2013 at 08:54:31AM -0700, Ben Pfaff wrote:
On Tue, Sep 24, 2013 at 04:45:14PM -0700, Ethan Jackson wrote:
Both the IPFIX and SFLOW modules are thread
.).
I do not expect this change has any runtime implications.
Detected using sparse.
Cc: Ethan Jackson et...@nicira.com
Cc: Ben Pfaff b...@nicira.com
Signed-off-by: Simon Horman ho...@verge.net.au
---
ofproto/ofproto-dpif-upcall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
-off-by: Simon Horman ho...@verge.net.au
---
v2.41 [Simon Horman]
* As suggested by Ben Pfaff
+ Expand struct ofpact_reg_load to include a mpls_before_vlan field
rather than using the compat field of the ofpact field of
struct ofpact_reg_load.
+ Pass version
ofpact_push_mpls. This field is set when
parsing OpenFlow actions.
Signed-off-by: Joe Stringer j...@wand.net.nz
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2.41 [Simon Horman]
* Use mpls_before_vlan field of struct ofpact_reg_load.
* Reword changelog to describe the difference in behaviour
Break out deacceleration portion of vlan_push into vlan_put
so that it may be re-used by mpls_push.
For both vlan_push and mpls_push if there is an accelerated VLAN tag
present then it should be deaccelerated, adding it to the data of
the skb, before the new tag is added.
Signed-off-by: Simon
: Allow VLAN actions after MPLS actions
ofp-actions: Add separate OpenFlow 1.3 action parser
lib: Support pushing of MPLS LSE before or after VLAN tag
Simon Horman (2):
datapath: Break out deacceleration portion of vlan_push
datapath: Add basic MPLS support to kernel
datapath/Modules.mk
for this will be added by a subsequent patch that makes use of
the infrastructure added by this patch.
Signed-off-by: Joe Stringer j...@wand.net.nz
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2.41
* Rework comments to make things a little clearer
v2.40
* Rebase for removal of mpls_depth from struct flow
yamah...@valinux.co.jp
Cc: Joe Stringer j...@wand.net.nz
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2.40
* Rebase for:
+ New dev_queue_xmit compat code
+ Updated put_vlan()
* As suggested by Jesse Gross
+ Remove bogus mac_len update from push_mpls()
+ Slightly simplify push_mpls
On Tue, Oct 01, 2013 at 04:02:17PM -0700, Jesse Gross wrote:
On Mon, Sep 30, 2013 at 11:47 PM, Simon Horman ho...@verge.net.au wrote:
diff --git a/datapath/actions.c b/datapath/actions.c
index d961e5d..bfab9ec 100644
--- a/datapath/actions.c
+++ b/datapath/actions.c
+/* Push MPLS after
On Wed, Oct 02, 2013 at 11:03:57AM -0700, Pravin Shelar wrote:
On Mon, Sep 30, 2013 at 11:47 PM, Simon Horman ho...@verge.net.au wrote:
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work
On Thu, Oct 03, 2013 at 07:46:46PM -0700, Pravin Shelar wrote:
On Wed, Oct 2, 2013 at 5:20 PM, Simon Horman ho...@verge.net.au wrote:
On Wed, Oct 02, 2013 at 11:03:57AM -0700, Pravin Shelar wrote:
On Mon, Sep 30, 2013 at 11:47 PM, Simon Horman ho...@verge.net.au wrote:
Allow datapath
yamah...@valinux.co.jp
Cc: Joe Stringer j...@wand.net.nz
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2.42
* Rebase for:
+ 0585f7a (datapath: Simplify mega-flow APIs.)
+ a097c0b (datapath: Restructure datapath.c and flow.c)
* As suggested by Jesse Gross
+ Take into account
-off-by: Simon Horman ho...@verge.net.au
---
v2.41 [Simon Horman]
* As suggested by Ben Pfaff
+ Expand struct ofpact_reg_load to include a mpls_before_vlan field
rather than using the compat field of the ofpact field of
struct ofpact_reg_load.
+ Pass version
for this will be added by a subsequent patch that makes use of
the infrastructure added by this patch.
Signed-off-by: Joe Stringer j...@wand.net.nz
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2.41
* Rework comments to make things a little clearer
v2.40
* Rebase for removal of mpls_depth from struct flow
pushing of MPLS LSE before or after VLAN tag
Simon Horman (2):
datapath: Break out deacceleration portion of vlan_push
datapath: Add basic MPLS support to kernel
datapath/Modules.mk | 1 +
datapath/actions.c | 158 -
datapath
501 - 600 of 4353 matches
Mail list logo
