Re: [ovs-dev] [PATCH 08/12] dpif-netdev: Reorder elements in dp_netdev_port structure.

2016-10-10 Thread Bodireddy, Bhanuprakash
>-Original Message- >From: Jarno Rajahalme [mailto:ja...@ovn.org] >Sent: Friday, October 7, 2016 10:11 PM >To: Bodireddy, Bhanuprakash <bhanuprakash.bodire...@intel.com> >Cc: dev@openvswitch.org >Subject: Re: [ovs-dev] [PATCH 08/12] dpif-netdev: Reorder ele

Re: [ovs-dev] [PATCH 08/12] dpif-netdev: Reorder elements in dp_netdev_port structure.

2016-10-07 Thread Jarno Rajahalme
Would equivalent packing be achieved by moving the line down before the bool instead? If yes, it would be preferable. Acked-by: Jarno Rajahalme > On Oct 7, 2016, at 9:17 AM, Bhanuprakash Bodireddy > wrote: > > By reordering the data elements

[ovs-dev] [PATCH 08/12] dpif-netdev: Reorder elements in dp_netdev_port structure.

2016-10-07 Thread Bhanuprakash Bodireddy
By reordering the data elements in dp_netdev_port structure, pad bytes can be reduced and there by saving a cache line. Before: structure size:136, holes:3, sum padbytes:15, cachelines:3 After: structure size:128, holes:1, sum padbytes:7, cachelines:2 Signed-off-by: Bhanuprakash Bodireddy