Re: Programmatic instance look up

2016-12-28 Thread John D. Ament
Created and added patch to https://issues.apache.org/jira/browse/OWB-1164 If you guys want to take a look. I can also raise a PR but since you're on SVN... dunno. John On Wed, Dec 28, 2016 at 4:05 PM Romain Manni-Bucau wrote: > Ok, can do it tmr if nobody beats me at it

Re: Programmatic instance look up

2016-12-28 Thread Romain Manni-Bucau
Ok, can do it tmr if nobody beats me at it Le 28 déc. 2016 21:41, "Mark Struberg" a écrit : > John is right, we should likely check for @Any in ThirdPartyBean and add > it if missing. > > > LieGrue, > Strub > > > > Am 28.12.2016 um 14:44 schrieb Romain Manni-Bucau

Re: Programmatic instance look up

2016-12-28 Thread Mark Struberg
John is right, we should likely check for @Any in ThirdPartyBean and add it if missing. LieGrue, Strub > Am 28.12.2016 um 14:44 schrieb Romain Manni-Bucau : > > Almost there too except on "declare qualifier" which was for me through > annotation which implied custom

Re: Programmatic instance look up

2016-12-28 Thread Romain Manni-Bucau
Almost there too except on "declare qualifier" which was for me through annotation which implied custom beans had to do it themself. Not sure to be honest. @Mark: how do you read it on your side? Romain Manni-Bucau @rmannibucau | Blog

Re: Programmatic instance look up

2016-12-28 Thread John D. Ament
It does not. I'm not sure I should add it though. When I look at the relevant section of the spec http://docs.jboss.org/cdi/spec/1.2/cdi-spec.html#programmatic_lookup the example mentions that the resulting bean only has

Re: Programmatic instance look up

2016-12-28 Thread John D. Ament
Looks like you already applied a fix. There's still one issue. Your bean behind CDI.current() has an any qualifier on it. AFAIK it should not. This causes programmatic lookup to try to include Any in the qualifiers which doesn't make sense. Since you fixed the NPE now I'm able to see that (

Re: Programmatic instance look up

2016-12-28 Thread Romain Manni-Bucau
think I spotted the issue(s): 1. a NPE when missing an injection point (trivial to solve) 2. we dont strip Default qualifier when user select(AnotherQualifier.LITERAL) which leads to something pretty much never resolvable will check if i can fix it in my spare time today Romain Manni-Bucau

Re: Programmatic instance look up

2016-12-28 Thread Romain Manni-Bucau
looks like a bug, we reused InstanceBean ( https://github.com/apache/openwebbeans/blob/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/OwbCDI.java#L45) but this only works with injection points. Using our injection resolver would work (from the webbeanscontext). We have a release

Re: Programmatic instance look up

2016-12-27 Thread John D. Ament
Its a single classloader. Programmatic lookup is just CDI.current().select(SomeClass.class).select(someAnnotationLiteral).get(); This fails, I would imagine, at least last time I did this on OWB, because there's no injection point defined @Inject @SomeAnnotation private SomeClass sc; and the

Re: Programmatic instance look up

2016-12-27 Thread Romain Manni-Bucau
Hi John What does the lookup look like? Using the related bean manager un several apps with success. Side note: is your classloader well setup? Le 27 déc. 2016 23:29, "John D. Ament" a écrit : > Hi, > > So I'm starting to run into my old friend, where instance doesn't

Programmatic instance look up

2016-12-27 Thread John D. Ament
Hi, So I'm starting to run into my old friend, where instance doesn't work the same in OWB and Weld. Basically anytime I use CDI.current() to resolve a bean, it fails. The same lookup works when using BeanManager.getReference, or even the DeltaSpike utilities. My understanding is that I should