Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?

2012-09-13 Thread Udo Schnurpfeil
Hi, I would like to make some tests (and may be optimization) on OWB-703 before the release. I can do that tomorrow. When do you want to start the release? (Not before Friday evening?) Regards, Udo Am 12.09.12 20:03, schrieb Mark Struberg: 2nd try as my previous got eaten by the spam filter

Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?

2012-09-12 Thread Thomas Andraschko
Hi Mark, it's already fixed but i attached an patch with some refactoring + unittests to #OWB-702. I know that i could commit it but it would be great if anyone could review it :) Regards, Thomas 2012/9/12 Mark Struberg strub...@yahoo.de 2nd try as my previous got eaten by the spam filter :/

Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?

2012-09-12 Thread Romain Manni-Bucau
HI Mark, ok for me, what about javassist issue, do we fix it? *Romain Manni-Bucau* *Twitter: @rmannibucau* *Blog: http://rmannibucau.wordpress.com* 2012/9/12 Thomas Andraschko zoi...@gmail.com Hi Mark, it's already fixed but i attached an patch with some refactoring + unittests to

Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?

2012-09-12 Thread Joseph Bergmark
I started to review the patch, and the changes I saw looked good, but there is so much whitespace reformatting in that patch that its hard to focus on just the implementation changes. Sincerely, Joe On Wed, Sep 12, 2012 at 2:24 PM, Thomas Andraschko zoi...@gmail.com wrote: Hi Mark, it's

Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?

2012-09-12 Thread Thomas Andraschko
i know, sorry. Should i deactivate remove trailing spaces in my IDE? 2012/9/12 Joseph Bergmark bergm...@apache.org I started to review the patch, and the changes I saw looked good, but there is so much whitespace reformatting in that patch that its hard to focus on just the implementation

Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?

2012-09-12 Thread Mark Struberg
Manni-Bucau rmannibu...@gmail.com To: dev@openwebbeans.apache.org Cc: Sent: Wednesday, September 12, 2012 8:25 PM Subject: Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week? HI Mark, ok for me, what about javassist issue, do we fix it? *Romain Manni-Bucau* *Twitter: @rmannibucau

Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?

2012-09-12 Thread Joseph Bergmark
I'm not at all sure whats leading to the whitespace differences. Do you use Eclipse? If so I can send you the eclipse formatter that Gurkan sent me a couple years back. Sincerely, Joe On Wed, Sep 12, 2012 at 2:38 PM, Thomas Andraschko zoi...@gmail.com wrote: i know, sorry. Should i

Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?

2012-09-12 Thread Romain Manni-Bucau
@Mark: spoke about finalize, not asm issue *Romain Manni-Bucau* *Twitter: @rmannibucau* *Blog: http://rmannibucau.wordpress.com* 2012/9/12 Joseph Bergmark bergm...@apache.org I'm not at all sure whats leading to the whitespace differences. Do you use Eclipse? If so I can send you the

Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week?

2012-09-12 Thread Thomas Andraschko
@Joe Yey, i use eclipse :) That would be great! @Mark all right, thanks for the infos! 2012/9/12 Joseph Bergmark bergm...@apache.org I'm not at all sure whats leading to the whitespace differences. Do you use Eclipse? If so I can send you the eclipse formatter that Gurkan sent me a couple