Re: svn commit: r1481253 - in /openwebbeans/trunk/webbeans-impl/src: main/java/org/apache/webbeans/portable/AnnotatedTypeImpl.java test/java/org/apache/webbeans/portable/AnnotatedTypeImplTest.java

2013-05-11 Thread Romain Manni-Bucau
Not really, fake beans = we reuse constructor logic from cdi for ee objects (servlet, ejb...). Mainly allows constructor injections without duplicating code. Model is clean up so we shouldnt have issues. Le 11 mai 2013 18:01, "Joseph Bergmark" a écrit : > On a side note, if you are creating "fake

Re: svn commit: r1481253 - in /openwebbeans/trunk/webbeans-impl/src: main/java/org/apache/webbeans/portable/AnnotatedTypeImpl.java test/java/org/apache/webbeans/portable/AnnotatedTypeImplTest.java

2013-05-11 Thread Joseph Bergmark
On a side note, if you are creating "fake beans" by using BeanManager.createInjectionTarget, at one point it had a side affect of registering ObserMethodImpls with the NotificantManager. Joe On Sat, May 11, 2013 at 5:05 AM, Romain Manni-Bucau wrote: > To explain a bit for people not having the d

Re: svn commit: r1481253 - in /openwebbeans/trunk/webbeans-impl/src: main/java/org/apache/webbeans/portable/AnnotatedTypeImpl.java test/java/org/apache/webbeans/portable/AnnotatedTypeImplTest.java

2013-05-11 Thread Gerhard Petracek
@ romain: +1 regards, gerhard 2013/5/11 Romain Manni-Bucau > To explain a bit for people not having the details: > > Basically AT are not thread safe but owb startup objects by app neither. So > that s ok. > > Then if we want it thread safe at runtime we should make AT immutable after > start

Re: svn commit: r1481253 - in /openwebbeans/trunk/webbeans-impl/src: main/java/org/apache/webbeans/portable/AnnotatedTypeImpl.java test/java/org/apache/webbeans/portable/AnnotatedTypeImplTest.java

2013-05-11 Thread Romain Manni-Bucau
To explain a bit for people not having the details: Basically AT are not thread safe but owb startup objects by app neither. So that s ok. Then if we want it thread safe at runtime we should make AT immutable after startup and not do anything lazily. Finally if it was a fix for tomee please Davi

Re: svn commit: r1481253 - in /openwebbeans/trunk/webbeans-impl/src: main/java/org/apache/webbeans/portable/AnnotatedTypeImpl.java test/java/org/apache/webbeans/portable/AnnotatedTypeImplTest.java

2013-05-11 Thread Romain Manni-Bucau
Should be reverted IMO Le 11 mai 2013 05:21, a écrit : > Author: dblevins > Date: Sat May 11 03:20:48 2013 > New Revision: 1481253 > > URL: http://svn.apache.org/r1481253 > Log: > OWB-858: AnnotatedTypeImpl not thread safe > Fixed > > Modified: > > openwebbeans/trunk/webbeans-impl/src/main/java/o