Re: Backport for OWB 1.7.x

2018-11-22 Thread Daniel Cunha
Ok, in this case I'll back the asm changes. I'll update the patch. Em qua, 21 de nov de 2018 7:02 AM, Thomas Andraschko < andraschko.tho...@gmail.com escreveu: > +1 to not change the old default > > Am Di., 20. Nov. 2018 um 21:27 Uhr schrieb Romain Manni-Bucau < > rmannibu...@gmail.com>: > > > Ex

Re: Backport for OWB 1.7.x

2018-11-22 Thread Daniel Cunha
hi folks, patch updated again: https://github.com/apache/openwebbeans/pull/13 :) Em qui, 22 de nov de 2018 às 08:14, Daniel Cunha escreveu: > Ok, in this case I'll back the asm changes. I'll update the patch. > > Em qua, 21 de nov de 2018 7:02 AM, Thomas Andraschko < > andraschko.tho...@gmail.c

Re: Backport for OWB 1.7.x

2018-11-22 Thread Thomas Andraschko
Hi Daniel, not sure if i didn't understand it correclty but IMO we should upgrade to ASM7 - BUT - default the bytecode version to Java6 or Java7 in AbstractProxyFactory#determineDefaultJavaVersion. Could you please clarify Romain? Best regards, Thomas Am Do., 22. Nov. 2018 um 13:48 Uhr schrieb D

Re: Backport for OWB 1.7.x

2018-11-22 Thread Romain Manni-Bucau
+1 Thomas Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book

Re: Backport for OWB 1.7.x

2018-11-22 Thread Jonathan Gallimore
I think you can keep ASM 7, but leave this: https://github.com/apache/openwebbeans/pull/13/commits/cb600aada79427ab7eff31e7da92038b6af6ed19#diff-f58069aef7df21dd8d4b0bd3546a747aR104 as `return Opcodes.V1_6;`. Hope that helps. Jon On Thu, Nov 22, 2018 at 1:26 PM Romain Manni-Bucau wrote: > +1

Re: Backport for OWB 1.7.x

2018-11-22 Thread Daniel Cunha
Ah.. Ok, I get it! Thanks Thomas and Jon Em qui, 22 de nov de 2018 às 10:30, Jonathan Gallimore < jonathan.gallim...@gmail.com> escreveu: > I think you can keep ASM 7, but leave this: > > https://github.com/apache/openwebbeans/pull/13/commits/cb600aada79427ab7eff31e7da92038b6af6ed19#diff-f58069a

Re: Backport for OWB 1.7.x

2018-11-22 Thread Daniel Cunha
Ok. patch updated again. :) Em qui, 22 de nov de 2018 às 10:32, Daniel Cunha escreveu: > Ah.. > > Ok, I get it! > Thanks Thomas and Jon > > Em qui, 22 de nov de 2018 às 10:30, Jonathan Gallimore < > jonathan.gallim...@gmail.com> escreveu: > >> I think you can keep ASM 7, but leave this: >> >> ht