[GitHub] orc pull request #151: ORC-226 Support getWriterId in c++ reader interface

2017-08-15 Thread xndai
Github user xndai commented on a diff in the pull request: https://github.com/apache/orc/pull/151#discussion_r10343 --- Diff: c++/include/orc/Reader.hh --- @@ -288,6 +288,17 @@ namespace orc { virtual uint64_t getCompressionSize() const = 0; /** +

[GitHub] orc pull request #151: ORC-226 Support getWriterId in c++ reader interface

2017-08-15 Thread omalley
Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/151#discussion_r10120 --- Diff: c++/include/orc/Reader.hh --- @@ -288,6 +288,17 @@ namespace orc { virtual uint64_t getCompressionSize() const = 0; /** +

[GitHub] orc pull request #154: ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS co...

2017-08-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/orc/pull/154 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] orc pull request #157: ORC-223 FileDump utility should print user metadata

2017-08-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/orc/pull/157 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] orc pull request #158: ORC-230: Add OSX os to travis testing

2017-08-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/orc/pull/158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] orc issue #149: ORC-224: Implement column writers of primitive types

2017-08-15 Thread wgtmac
Github user wgtmac commented on the issue: https://github.com/apache/orc/pull/149 @majetideepak No worries. Thanks for looking into this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] orc issue #134: Orc 17

2017-08-15 Thread majetideepak
Github user majetideepak commented on the issue: https://github.com/apache/orc/pull/134 I am adding a Travis test for OSX os. It should ease catching OSX issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] orc issue #134: Orc 17

2017-08-15 Thread jamesclampffer
Github user jamesclampffer commented on the issue: https://github.com/apache/orc/pull/134 Those errors should go away after HDFS-10787 is finished (or applied to the PR temporarily) since it exposes an API to get at the configuration without using std::tr2::optional. We had to

[GitHub] orc issue #149: ORC-224: Implement column writers of primitive types

2017-08-15 Thread majetideepak
Github user majetideepak commented on the issue: https://github.com/apache/orc/pull/149 @wgtmac Sorry for taking longer. I will definitely try to complete this as soon as possible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] orc issue #134: Orc 17

2017-08-15 Thread omalley
Github user omalley commented on the issue: https://github.com/apache/orc/pull/134 It looks like it is a "long" vs "long long" problem. /Users/owen/work/code/orc/build/libhdfspp_ep-prefix/src/libhdfspp_ep/lib/common/configuration.cc:85:12: error: no viable

[GitHub] orc issue #134: Orc 17

2017-08-15 Thread AnatoliShein
Github user AnatoliShein commented on the issue: https://github.com/apache/orc/pull/134 Hi @omalley , What error messages do you get when trying to build on MacOS? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If