Github user rip-nsk commented on the issue:
https://github.com/apache/orc/pull/198
I don't think it is related to the proposed changes since io/InputStream.cc
(and any headers) are not touched.
---
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/198
This patch works on MacOS, but fails on CentOS 6. In general, for this kind
of change, I like to run the docker/run-all.sh on the patch. I get:
```
[ 42%] Building CXX object
Github user moresandeep commented on the issue:
https://github.com/apache/orc/pull/184
@xndai @omalley I updated the PR with the suggested changes, let me know
if you have any questions.
---
Github user moresandeep commented on a diff in the pull request:
https://github.com/apache/orc/pull/184#discussion_r155629181
--- Diff: java/core/src/test/org/apache/orc/impl/mask/TestUnmaskRange.java
---
@@ -0,0 +1,165 @@
+package org.apache.orc.impl.mask;
+
+/**
Github user moresandeep commented on a diff in the pull request:
https://github.com/apache/orc/pull/184#discussion_r155629073
--- Diff:
java/core/src/java/org/apache/orc/impl/mask/RedactMaskFactory.java ---
@@ -245,8 +271,8 @@ public void maskData(ColumnVector original,
Github user moresandeep commented on a diff in the pull request:
https://github.com/apache/orc/pull/184#discussion_r155629140
--- Diff:
java/core/src/java/org/apache/orc/impl/mask/RedactMaskFactory.java ---
@@ -619,7 +646,7 @@ public double maskDouble(double value) {
}
Github user moresandeep commented on a diff in the pull request:
https://github.com/apache/orc/pull/184#discussion_r155628665
--- Diff:
java/core/src/java/org/apache/orc/impl/mask/RedactMaskFactory.java ---
@@ -114,6 +120,10 @@
private final boolean maskDate;
private
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/184#discussion_r155623157
--- Diff: java/core/src/test/org/apache/orc/impl/mask/TestUnmaskRange.java
---
@@ -0,0 +1,165 @@
+package org.apache.orc.impl.mask;
+
+/**
+ *
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/184#discussion_r154761512
--- Diff:
java/core/src/java/org/apache/orc/impl/mask/RedactMaskFactory.java ---
@@ -245,8 +271,8 @@ public void maskData(ColumnVector original,
ColumnVector
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/184#discussion_r154762146
--- Diff:
java/core/src/java/org/apache/orc/impl/mask/RedactMaskFactory.java ---
@@ -619,7 +646,7 @@ public double maskDouble(double value) {
} else if
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/198#discussion_r155619755
--- Diff: c++/src/Int128.cc ---
@@ -22,6 +22,7 @@
#include
#include
#include
+#include // std::min
--- End diff --
nit: you
Github user wgtmac commented on the issue:
https://github.com/apache/orc/pull/199
Thanks @xndai. Please see the last commit for the fixes that you have
mentioned.
@omalley @majetideepak Please take a look when you have time. Thanks!
---
Github user moresandeep commented on the issue:
https://github.com/apache/orc/pull/184
@omalley I updated the PR with your suggestions, thanks for the review !
---
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/198
LGTM
---
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/199#discussion_r155596136
--- Diff: tools/src/CSVFileImport.cc ---
@@ -0,0 +1,411 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/199#discussion_r155593796
--- Diff: tools/src/CSVFileImport.cc ---
@@ -0,0 +1,411 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/199#discussion_r155594426
--- Diff: tools/src/CSVFileImport.cc ---
@@ -0,0 +1,411 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
17 matches
Mail list logo
