Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/277#discussion_r192919379
--- Diff: c++/src/TypeImpl.cc ---
@@ -258,31 +258,34 @@ namespace orc {
case STRUCT: {
StructVectorBatch *result = new StructVecto
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/277#discussion_r192909966
--- Diff: c++/src/TypeImpl.cc ---
@@ -498,54 +506,54 @@ namespace orc {
}
ORC_UNIQUE_PTR Type::buildTypeFromString(const std::string& input)
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/277#discussion_r192907281
--- Diff: c++/src/TypeImpl.cc ---
@@ -258,31 +258,34 @@ namespace orc {
case STRUCT: {
StructVectorBatch *result = new StructVectorBatch
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/277#discussion_r192910566
--- Diff: c++/src/Compression.cc ---
@@ -282,6 +285,11 @@ DIAGNOSTIC_PUSH
}
}
+ void ZlibCompressionStream::end() {
+(void)defl
Github user asfgit closed the pull request at:
https://github.com/apache/orc/pull/279
---
Github user prasanthj commented on the issue:
https://github.com/apache/orc/pull/279
lgtm
---
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/279
Prasanth, rather than adding the flush count, which is really test code in
the main source, how about creating a StringTreeWriter and catching the stream
directly. I'd propose this -
https://github.com
Github user majetideepak commented on the issue:
https://github.com/apache/orc/pull/277
@wgtmac, @xndai can you take a look at this patch? ZLIB compression code
seems to be leaking memory. Thanks!
---
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/276
@prasanthj yeah, in general you should make a dev branch for the pull
request (eg. prasanthj:orc-373). Then you can do a force-push to the branch to
update the PR.
---
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/273#discussion_r192729045
--- Diff: c++/test/TestRleEncoder.cc ---
@@ -0,0 +1,243 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contr
10 matches
Mail list logo
