[GitHub] orc issue #132: ORC-202. Add writer implementation enum to file format

2017-06-21 Thread xndai
Github user xndai commented on the issue: https://github.com/apache/orc/pull/132 That makes sense. I add the writer code in c++ writer. We might need a similar change for c++ reader. Will do it in a separate PR. --- If your project is set up for it, you can reply to this email and

[GitHub] orc issue #132: ORC-202. Add writer implementation enum to file format

2017-06-20 Thread omalley
Github user omalley commented on the issue: https://github.com/apache/orc/pull/132 There are a couple of problems with enums in Protobuf... The main is that if it is an unknown value (from a future version) it becomes unset. It is important that we can tell the difference between an

[GitHub] orc issue #132: ORC-202. Add writer implementation enum to file format

2017-06-16 Thread omalley
Github user omalley commented on the issue: https://github.com/apache/orc/pull/132 Ok, I've addressed all of Dain's feedback. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature