[GitHub] orc issue #199: ORC-276: [C++] Create a simple tool to import CSV files

2018-01-11 Thread majetideepak
Github user majetideepak commented on the issue: https://github.com/apache/orc/pull/199 Looks good! Thank you! ---

[GitHub] orc issue #199: ORC-276: [C++] Create a simple tool to import CSV files

2018-01-01 Thread xndai
Github user xndai commented on the issue: https://github.com/apache/orc/pull/199 Hi @majetideepak , Gang is on vacation and will look into your feedback after he's back next week. Thx. ---

[GitHub] orc issue #199: ORC-276: [C++] Create a simple tool to import CSV files

2017-12-21 Thread majetideepak
Github user majetideepak commented on the issue: https://github.com/apache/orc/pull/199 I just realized we need to add tests for each tool as well. `/tools/test` has some examples. Some of the tools are missing tests as well. I will file a JIRA to cover those. Sorry for not

[GitHub] orc issue #199: ORC-276: [C++] Create a simple tool to import CSV files

2017-12-15 Thread wgtmac
Github user wgtmac commented on the issue: https://github.com/apache/orc/pull/199 @majetideepak Please take a look for the updated patch. Thanks! ---

[GitHub] orc issue #199: ORC-276: [C++] Create a simple tool to import CSV files

2017-12-07 Thread wgtmac
Github user wgtmac commented on the issue: https://github.com/apache/orc/pull/199 Thanks @xndai. Please see the last commit for the fixes that you have mentioned. @omalley @majetideepak Please take a look when you have time. Thanks! ---