Github user sershe commented on a diff in the pull request:
https://github.com/apache/orc/pull/222#discussion_r173943752
--- Diff: java/core/src/java/org/apache/orc/impl/RecordReaderUtils.java ---
@@ -306,15 +330,24 @@ public void releaseBuffer(ByteBuffer buffer) {
Github user prasanthj commented on a diff in the pull request:
https://github.com/apache/orc/pull/222#discussion_r173941203
--- Diff: java/core/src/java/org/apache/orc/impl/RecordReaderUtils.java ---
@@ -306,15 +330,24 @@ public void releaseBuffer(ByteBuffer buffer) {
Github user sershe commented on a diff in the pull request:
https://github.com/apache/orc/pull/222#discussion_r171728816
--- Diff: java/core/src/java/org/apache/orc/impl/WriterImpl.java ---
@@ -645,6 +645,8 @@ public void
appendUserMetadata(List userMetadata) {
return
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/222#discussion_r171719585
--- Diff: java/core/src/java/org/apache/orc/impl/WriterImpl.java ---
@@ -645,6 +645,8 @@ public void
appendUserMetadata(List userMetadata) {
return
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/222#discussion_r171720836
--- Diff: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java ---
@@ -1353,6 +1353,8 @@ public static String encodeTranslatedSargColumn(int
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/222#discussion_r171720713
--- Diff: java/core/src/java/org/apache/orc/impl/ReaderImpl.java ---
@@ -472,8 +473,9 @@ public static OrcTail extractFileTail(ByteBuffer
buffer, long
GitHub user sershe opened a pull request:
https://github.com/apache/orc/pull/222
ORC-310 better error handling for codec
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sershe/orc orc-310
Alternatively you can review and apply
