[GitHub] orc pull request #134: Orc 17

2017-06-23 Thread AnatoliShein
Github user AnatoliShein commented on a diff in the pull request: https://github.com/apache/orc/pull/134#discussion_r123841444 --- Diff: c++/src/OrcHdfsFile.cc --- @@ -0,0 +1,170 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

[GitHub] orc pull request #134: Orc 17

2017-06-23 Thread AnatoliShein
Github user AnatoliShein commented on a diff in the pull request: https://github.com/apache/orc/pull/134#discussion_r123841451 --- Diff: c++/src/OrcHdfsFile.cc --- @@ -0,0 +1,170 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

[GitHub] orc pull request #134: Orc 17

2017-06-23 Thread AnatoliShein
Github user AnatoliShein commented on a diff in the pull request: https://github.com/apache/orc/pull/134#discussion_r123842164 --- Diff: c++/src/OrcHdfsFile.cc --- @@ -0,0 +1,170 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

[GitHub] orc pull request #134: Orc 17

2017-06-23 Thread xndai
Github user xndai commented on a diff in the pull request: https://github.com/apache/orc/pull/134#discussion_r123853204 --- Diff: c++/src/OrcHdfsFile.cc --- @@ -34,15 +34,13 @@ #include "common/hdfs_configuration.h" #include "common/configuration_loader.h" -#defi

[GitHub] orc pull request #134: Orc 17

2017-06-23 Thread xndai
Github user xndai commented on a diff in the pull request: https://github.com/apache/orc/pull/134#discussion_r123852932 --- Diff: c++/src/OrcHdfsFile.cc --- @@ -121,39 +116,24 @@ namespace orc { } uint64_t getNaturalReadSize() const override { - retu

[GitHub] orc pull request #134: Orc 17

2017-06-23 Thread xndai
Github user xndai commented on a diff in the pull request: https://github.com/apache/orc/pull/134#discussion_r123853053 --- Diff: c++/src/OrcHdfsFile.cc --- @@ -66,22 +64,22 @@ namespace orc { options = config->GetOptions(); } hdfs::IoService * io_