[jira] [Created] (ORC-376) Add Ubuntu18 docker file

2018-06-05 Thread Owen O'Malley (JIRA) 
Owen O'Malley created ORC-376:
-

 Summary: Add Ubuntu18 docker file
 Key: ORC-376
 URL: https://issues.apache.org/jira/browse/ORC-376
 Project: ORC
  Issue Type: Improvement
Reporter: Owen O'Malley
Assignee: Owen O'Malley


We should add an Ubuntu 18 docker file, so that we can test against gcc7.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ORC-375) v1.5.1 install from source fails under GCC 7.3.0

2018-06-05 Thread Serge Fein (JIRA) 
Serge Fein created ORC-375:
--

 Summary: v1.5.1 install from source fails under GCC 7.3.0
 Key: ORC-375
 URL: https://issues.apache.org/jira/browse/ORC-375
 Project: ORC
  Issue Type: Bug
  Components: build, C++
Affects Versions: 1.5.1, 1.5.0
Reporter: Serge Fein


Build fails when trying to build a dependent package:

orc/build/libhdfspp_ep-prefix/src/libhdfspp_ep/lib/common/async_stream.h:39:16: 
error: ‘std::function’ has not been declared

    std::function

[GitHub] orc pull request #277: ORC-372: Enable valgrind for C++ travis-ci tests

2018-06-05 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/orc/pull/277


---

[GitHub] orc pull request #277: ORC-372: Enable valgrind for C++ travis-ci tests

2018-06-05 Thread majetideepak 
Github user majetideepak commented on a diff in the pull request:

https://github.com/apache/orc/pull/277#discussion_r193159979
  
--- Diff: c++/src/Compression.cc ---
@@ -199,13 +199,16 @@ namespace orc {
   uint64_t blockSize,
   MemoryPool& pool);
 
+~ZlibCompressionStream() { end(); }
--- End diff --

Thanks!


---

[GitHub] orc pull request #277: ORC-372: Enable valgrind for C++ travis-ci tests

2018-06-05 Thread omalley 
Github user omalley commented on a diff in the pull request:

https://github.com/apache/orc/pull/277#discussion_r193106126
  
--- Diff: c++/test/CMakeLists.txt ---
@@ -64,7 +64,12 @@ target_link_libraries (create-test-files
   protobuf
 )
 
-add_test (NAME orc-test COMMAND orc-test)
+if (TEST_VALGRIND_MEMCHECK)
+  add_test (orc-test  
--- End diff --

You have trailing spaces here.


---

[GitHub] orc pull request #277: ORC-372: Enable valgrind for C++ travis-ci tests

2018-06-05 Thread omalley 
Github user omalley commented on a diff in the pull request:

https://github.com/apache/orc/pull/277#discussion_r19313
  
--- Diff: c++/src/Compression.cc ---
@@ -199,13 +199,16 @@ namespace orc {
   uint64_t blockSize,
   MemoryPool& pool);
 
+~ZlibCompressionStream() { end(); }
--- End diff --

You need an override on this or the mac complains.


---