[GitHub] orc pull request #283: ORC-378

2018-06-14 Thread sershe
GitHub user sershe opened a pull request: https://github.com/apache/orc/pull/283 ORC-378 You can merge this pull request into a Git repository by running: $ git pull https://github.com/sershe/orc master-378 Alternatively you can review and apply these changes as the patch

[GitHub] orc pull request #222: ORC-310 better error handling for codec

2018-02-28 Thread sershe
GitHub user sershe opened a pull request: https://github.com/apache/orc/pull/222 ORC-310 better error handling for codec You can merge this pull request into a Git repository by running: $ git pull https://github.com/sershe/orc orc-310 Alternatively you can review and apply

[GitHub] orc pull request #222: ORC-310 better error handling for codec

2018-03-12 Thread sershe
Github user sershe commented on a diff in the pull request: https://github.com/apache/orc/pull/222#discussion_r173943752 --- Diff: java/core/src/java/org/apache/orc/impl/RecordReaderUtils.java --- @@ -306,15 +330,24 @@ public void releaseBuffer(ByteBuffer buffer

[GitHub] orc issue #222: ORC-310 better error handling for codec

2018-03-01 Thread sershe
Github user sershe commented on the issue: https://github.com/apache/orc/pull/222 Updated the JIRA with motivation. I will rename the flag; there isn't a better way primarily because of the TODOs you are asking me to remove - we don't have access to information about errors

[GitHub] orc pull request #222: ORC-310 better error handling for codec

2018-03-01 Thread sershe
Github user sershe commented on a diff in the pull request: https://github.com/apache/orc/pull/222#discussion_r171728816 --- Diff: java/core/src/java/org/apache/orc/impl/WriterImpl.java --- @@ -645,6 +645,8 @@ public void appendUserMetadata(List userMetadata) { return