[GitHub] orc issue #253: ORC-346: [C++] Add one second when writing negative Timestam...

2018-04-27 Thread omalley 
Github user omalley commented on the issue:

https://github.com/apache/orc/pull/253
  
*Sigh* This is caused by the fact that Java defined Timestamp badly and 
then Hive copied those semantics into the ColumnVector.

We really need to fix these semantics in ORCv2.

I'll also comment that it would probably be nicer to our users if we 
weren't modifying the data in the columnVector they passed into us, but clearly 
we are already doing that.


---

[GitHub] orc issue #253: ORC-346: [C++] Add one second when writing negative Timestam...

2018-04-23 Thread rip-nsk 
Github user rip-nsk commented on the issue:

https://github.com/apache/orc/pull/253
  
I'm not sure that it is correct fix, IMO, TimestampColumnReader should not 
do this:
if (secsBuffer[i] < 0 && nanoBuffer[i] != 0) {
  secsBuffer[i] -= 1;
}
but it seems necessary to match the java reader.


---