[GitHub] orc issue #276: ORC-373: Option to disable dictionary encoding

2018-06-04 Thread omalley 
Github user omalley commented on the issue:

https://github.com/apache/orc/pull/276
  
@prasanthj yeah, in general you should make a dev branch for the pull 
request (eg. prasanthj:orc-373).  Then you can do a force-push to the branch to 
update the PR.


---

[GitHub] orc issue #276: ORC-373: Option to disable dictionary encoding

2018-06-04 Thread prasanthj 
Github user prasanthj commented on the issue:

https://github.com/apache/orc/pull/276
  
@damiencarol added junit tests. my branches got messed up. So had to give 
another PR. #279


---

[GitHub] orc issue #276: ORC-373: Option to disable dictionary encoding

2018-06-02 Thread damiencarol 
Github user damiencarol commented on the issue:

https://github.com/apache/orc/pull/276
  
@prasanthj no unit test?


---