[GitHub] orc issue #293: ORC-388: Fix isSafeSubtract to use logic operator instead of...

2018-07-29 Thread majetideepak 
Github user majetideepak commented on the issue:

https://github.com/apache/orc/pull/293
  
+1 LGTM.
logical operator helps in short-circuit evaluation as well.


---

[GitHub] orc issue #293: ORC-388: Fix isSafeSubtract to use logic operator instead of...

2018-07-25 Thread xndai 
Github user xndai commented on the issue:

https://github.com/apache/orc/pull/293
  
LGTM


---