[GitHub] oschaaf closed pull request #1552: Honor assume yes when installing dependencies

oschaaf closed pull request #1552: Honor assume yes when installing dependencies URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1552 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] dsanders11 commented on issue #1552: Honor assume yes when installing dependencies

dsanders11 commented on issue #1552: Honor assume yes when installing dependencies URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1552#issuecomment-385091110 Perhaps all the dependencies are installed in the case of `--devel` (or already on the server). I believe if it found

[GitHub] jmarantz commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript

jmarantz commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript URL: https://github.com/apache/incubator-pagespeed-mod/issues/1761#issuecomment-385018037 This is expected behavior. Pagespeed does not attempt to rewrite URLs embedded in

[GitHub] jmarantz commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript

jmarantz commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript URL: https://github.com/apache/incubator-pagespeed-mod/issues/1761#issuecomment-385018037 This is expected behavior. Pagespeed does not attemptto rewrite URLs embedded in

[GitHub] eldk commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript

eldk commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript URL: https://github.com/apache/incubator-pagespeed-mod/issues/1761#issuecomment-385013034 Hello, I have modified /mod_pagespeed_example/proxy_external_resource.html -

[GitHub] eldk commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript

eldk commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript URL: https://github.com/apache/incubator-pagespeed-mod/issues/1761#issuecomment-385013034 Hello, I have modified /mod_pagespeed_example/proxy_external_resource.html -

[GitHub] eldk commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript

eldk commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript URL: https://github.com/apache/incubator-pagespeed-mod/issues/1761#issuecomment-385013034 Hello, I have modified /mod_pagespeed_example/proxy_external_resource.html -

[GitHub] oschaaf commented on issue #1758: ModPagespeedHonorCsp ignores that unsafe-eval is not an allowed script source

oschaaf commented on issue #1758: ModPagespeedHonorCsp ignores that unsafe-eval is not an allowed script source URL: https://github.com/apache/incubator-pagespeed-mod/issues/1758#issuecomment-384974178 @RajaHassan As far as I know, no-one is working to fix this right now. Not sure if

[GitHub] oschaaf commented on issue #1552: Honor assume yes when installing dependencies

oschaaf commented on issue #1552: Honor assume yes when installing dependencies URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1552#issuecomment-384973046 Code change looks good, and in terms of function it looks like this makes a lot of sense. I have to dive in some more

[GitHub] dsanders11 opened a new pull request #1552: Honor assume yes when installing dependencies

dsanders11 opened a new pull request #1552: Honor assume yes when installing dependencies URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1552 Currently running `build_ngx_pagespeed.sh` with `--assume-yes` won't automatically send yes when installing dependencies, defeating

[GitHub] RajaHassan commented on issue #1758: ModPagespeedHonorCsp ignores that unsafe-eval is not an allowed script source

RajaHassan commented on issue #1758: ModPagespeedHonorCsp ignores that unsafe-eval is not an allowed script source URL: https://github.com/apache/incubator-pagespeed-mod/issues/1758#issuecomment-384929638 can anybody tell that is this issue being fixed ?