[GitHub] robov commented on issue #1181: Support Alpine
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356498629 I would definately be interested, but I am not bringing much to this table. My experience in linux is very low and I consider myself a newbie in this space This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oppianmatt commented on issue #1524: build instructions no longer working for all versions
oppianmatt commented on issue #1524: build instructions no longer working for
all versions
URL:
https://github.com/apache/incubator-pagespeed-ngx/issues/1524#issuecomment-356427654
after a bit of googling and testing found that psol moved to a new place and
so that needs to be fixed.
Here are my fixes locally which need to be updated into the readme
```
wget https://github.com/pagespeed/ngx_pagespeed/archive/v${NPS_VERSION}.zip
unzip v${NPS_VERSION}.zip -d ngx_pagespeed-${NPS_VERSION}
cd ngx_pagespeed-${NPS_VERSION}/
NPS_RELEASE_NUMBER=${NPS_VERSION/-beta/}
# NPS_RELEASE_NUMBER=${NPS_VERSION/stable/}
psol_url=https://github.com/apache/incubator-pagespeed-mod/archive/v${NPS_RELEASE_NUMBER}.zip
[ -e scripts/format_binary_url.sh ] &&
psol_url=$(scripts/format_binary_url.sh PSOL_BINARY_URL)
wget ${psol_url}
unzip $(basename ${psol_url}) -d psol # extracts to psol/
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] nberlee commented on issue #1181: Support Alpine
nberlee commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356353214 @hgl The sed line was a workaround for a Alpine 3.7 busybox wait bug. (which never stopped waiting) This seems to be fixed since, making the line now obsolete. Fixed my branch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hgl commented on issue #1181: Support Alpine
hgl commented on issue #1181: Support Alpine
URL:
https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356277892
But since the name is tentative, that mv command could easily fail when that
happens. A better approach:
```
mkdir -p /tmp/ngx_pagespeed-${PAGESPEED_VERSION}-stable \
&& cd /tmp/ngx_pagespeed-${PAGESPEED_VERSION}-stable \
&& curl -L
https://github.com/pagespeed/ngx_pagespeed/archive/v${PAGESPEED_VERSION}-${PAGESPEED_BRANCH}.tar.gz
\
| tar -xj --strip-components=1
```
You do have to install tar though, because busybox tar doesn't support
`strip-components`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] oschaaf commented on issue #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds
oschaaf commented on issue #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds URL: https://github.com/apache/incubator-pagespeed-mod/pull/1695#issuecomment-356278838 @jmarantz processed your comments in https://github.com/apache/incubator-pagespeed-mod/pull/1695/commits/eed1ff19bacfc07a220e643ae84a1e08eb705a05 (barring the one about test-coverage, which I proposed to land in the follow up to this) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hgl commented on issue #1181: Support Alpine
hgl commented on issue #1181: Support Alpine
URL:
https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356277892
But since the name is tentative, that mv command could easily fail when that
happens. A better approach:
```
mkdir -p /tmp/modpagespeed-${PAGESPEED_VERSION} \
&& cd /tmp/modpagespeed-${PAGESPEED_VERSION} \
&& curl -L
https://github.com/We-Amp/ngx-pagespeed-alpine/blob/master/mod-pagespeed-beta-${PAGESPEED_VERSION}.tar.bz2?raw=true
\
| tar -xj --strip-components=1
```
You do have to install tar though, because busybox tar doesn't support
`strip-components`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] hgl commented on issue #1181: Support Alpine
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356277277 Yes, that script is never used in the Dockerfile This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hgl commented on issue #1181: Support Alpine
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356255779 @oschaaf Thanks for the head up. But it seems `Dockerfile`s from most unofficial alpine images don't use this script. So they'll continue to fail to build until fixed. Another reason to have an official nginx + pagespeed alpine image. :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hgl commented on issue #1181: Support Alpine
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356255779 @oschaaf Thanks for the head up. But it seems `Dockerfile`s from most unofficial alpine images don't use this script. So they will continue to fail to build until fixed. Another reason to have an official nginx + pagespeed alpine image. :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oschaaf commented on issue #1181: Support Alpine
oschaaf commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356254446 With regard to the renaming of the repo, https://github.com/apache/incubator-pagespeed-ngx/commit/e733a838c35a0f2108768c2d1ead6fb7ee806cf8 was merged yesterday to unbreak the install script. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] oschaaf commented on issue #1181: Support Alpine
oschaaf commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356254572 (The repo may be renamed again at some stage later on, and this change hopefully is resilient to that) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hgl commented on issue #1181: Support Alpine
hgl commented on issue #1181: Support Alpine
URL:
https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356253735
@robov in @nberlee's Dockerfile
add
```
mv /tmp/incubator-pagespeed-ngx-1.12.34.3-stable
/tmp/ngx_pagespeed-1.12.34.3-stable && \
```
below
```
curl -L
https://github.com/pagespeed/ngx_pagespeed/archive/v${NGX_PAGESPEED_VERSION}-stable.tar.gz
| tar -zx && \
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] hgl commented on issue #1181: Support Alpine
hgl commented on issue #1181: Support Alpine
URL:
https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356253735
@robov in @nberlee's Dockerfile
add
```
mv incubator-pagespeed-ngx-1.12.34.3-stable
/tmp/ngx_pagespeed-1.12.34.3-stable && \
```
below
```
curl -L
https://github.com/pagespeed/ngx_pagespeed/archive/v${NGX_PAGESPEED_VERSION}-stable.tar.gz
| tar -zx && \
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] hgl commented on issue #1181: Support Alpine
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356254153 @nberlee a quick question, why is [this line](https://github.com/nberlee/ngx-pagespeed-alpine/blob/3.7/Dockerfile#L47) necessary? I try to compile without it, and see no error. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] robov commented on issue #1181: Support Alpine
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356242638 I am a pretty newbie... can you share your changed code ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] robov commented on issue #1181: Support Alpine
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356242099 @HGL AWESOME.. yes I was very frustrated that even my backup files did not work anymore... So I guess you are right This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hgl commented on issue #1181: Support Alpine
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356237144 After some digging, I found the root cause is that this project just got moved to `apache/incubator-pagespeed-ngx`, so after downloading the archive file, it extracts to `/tmp/incubator-pagespeed-ngx-1.12.34.3-stable`, and eventually `/tmp/ngx_pagespeed-1.12.34.3-stable` only contains psol. I've successful compiled on 3.7 after correcting the folder name. I expect most derivatives of wernight/docker-alpine-nginx-pagespeed to fail to build with the same error currently. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
