[GitHub] [incubator-pagespeed-mod] oschaaf commented on pull request #2105: Update Envoy
oschaaf commented on PR #2105: URL: https://github.com/apache/incubator-pagespeed-mod/pull/2105#issuecomment-1304568278 In https://source.chromium.org/chromium/chromium/src/+/8de0ee1ed01cd1444d45263207a7a9c8b4d4463c:url/url_canon_stdstring.h;dlc=ec3532203dd162ad783e3318119cf9d5bd8e3633 `SetQuery` is made private; so we no longer can rely on that. Instead we now use `SetQueryStr`. Looking at the change we now pass, but I need to clean up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pagespeed.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-pagespeed-mod] oschaaf commented on pull request #2105: Update Envoy
oschaaf commented on PR #2105: URL: https://github.com/apache/incubator-pagespeed-mod/pull/2105#issuecomment-1304493451 Note: GoogleURL needed to update, because of the GURL api changing, which we pulled in transitively via our Envoy dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pagespeed.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-pagespeed-mod] oschaaf merged pull request #2104: Update to Envoy ff49762696b2e6ed3f408a22e1f7a1b7d2487318 (Oct 11th)
oschaaf merged PR #2104: URL: https://github.com/apache/incubator-pagespeed-mod/pull/2104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pagespeed.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
