[GitHub] robov commented on issue #1181: Support Alpine

robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356498629 I would definately be interested, but I am not bringing much to this table. My experience in linux is very low and I consider myself a newbie in this

[GitHub] oppianmatt commented on issue #1524: build instructions no longer working for all versions

oppianmatt commented on issue #1524: build instructions no longer working for all versions URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1524#issuecomment-356427654 after a bit of googling and testing found that psol moved to a new place and so that needs to be fixed.

[GitHub] nberlee commented on issue #1181: Support Alpine

nberlee commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356353214 @hgl The sed line was a workaround for a Alpine 3.7 busybox wait bug. (which never stopped waiting) This seems to be fixed since, making the line now

[GitHub] hgl commented on issue #1181: Support Alpine

hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356277892 But since the name is tentative, that mv command could easily fail when that happens. A better approach: ``` mkdir -p

[GitHub] oschaaf commented on issue #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds

oschaaf commented on issue #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds URL: https://github.com/apache/incubator-pagespeed-mod/pull/1695#issuecomment-356278838 @jmarantz processed your comments in

[GitHub] hgl commented on issue #1181: Support Alpine

hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356277892 But since the name is tentative, that mv command could easily fail when that happens. A better approach: ``` mkdir -p

[GitHub] hgl commented on issue #1181: Support Alpine

hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356277277 Yes, that script is never used in the Dockerfile This is an automated message from the

[GitHub] hgl commented on issue #1181: Support Alpine

hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356255779 @oschaaf Thanks for the head up. But it seems `Dockerfile`s from most unofficial alpine images don't use this script. So they'll continue to fail to

[GitHub] hgl commented on issue #1181: Support Alpine

hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356255779 @oschaaf Thanks for the head up. But it seems `Dockerfile`s from most unofficial alpine images don't use this script. So they will continue to fail to

[GitHub] oschaaf commented on issue #1181: Support Alpine

oschaaf commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356254446 With regard to the renaming of the repo, https://github.com/apache/incubator-pagespeed-ngx/commit/e733a838c35a0f2108768c2d1ead6fb7ee806cf8 was merged

[GitHub] oschaaf commented on issue #1181: Support Alpine

oschaaf commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356254572 (The repo may be renamed again at some stage later on, and this change hopefully is resilient to that)

[GitHub] hgl commented on issue #1181: Support Alpine

hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356253735 @robov in @nberlee's Dockerfile add ``` mv /tmp/incubator-pagespeed-ngx-1.12.34.3-stable /tmp/ngx_pagespeed-1.12.34.3-stable && \ ```

[GitHub] hgl commented on issue #1181: Support Alpine

hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356253735 @robov in @nberlee's Dockerfile add ``` mv incubator-pagespeed-ngx-1.12.34.3-stable /tmp/ngx_pagespeed-1.12.34.3-stable && \ ```

[GitHub] hgl commented on issue #1181: Support Alpine

hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356254153 @nberlee a quick question, why is [this line](https://github.com/nberlee/ngx-pagespeed-alpine/blob/3.7/Dockerfile#L47) necessary? I try to compile

[GitHub] robov commented on issue #1181: Support Alpine

robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356242638 I am a pretty newbie... can you share your changed code ? This is an automated message

[GitHub] robov commented on issue #1181: Support Alpine

robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356242099 @HGL AWESOME.. yes I was very frustrated that even my backup files did not work anymore... So I guess you are right

[GitHub] hgl commented on issue #1181: Support Alpine

hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356237144 After some digging, I found the root cause is that this project just got moved to `apache/incubator-pagespeed-ngx`, so after downloading the archive