[GitHub] edeis53 commented on issue #1704: Redis cache TTL

2018-05-08 Thread GitBox
edeis53 commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387566711 I would suggest a default -1 expiry to match current pagespeed config behaviour, and yes we'd probably use a long TTL like 1 year in our config.

[GitHub] edeis53 commented on issue #1704: Redis cache TTL

2018-05-08 Thread GitBox
edeis53 commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387566711 I would suggest a default -1 expiry to match current pagespeed config behaviour, and yes we'd probably use a long TTL like 1 year in our config.

[GitHub] edeis53 commented on issue #1704: Redis cache TTL

2018-05-08 Thread GitBox
edeis53 commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387566711 I would suggest a default -1 expiry to match current pagespeed config behaviour, and yes we'd probably use a long TTL like 1 year in our config.

[GitHub] oschaaf commented on issue #1771: Redis DB index aliasing

2018-05-08 Thread GitBox
oschaaf commented on issue #1771: Redis DB index aliasing URL: https://github.com/apache/incubator-pagespeed-mod/issues/1771#issuecomment-387449218 Ugh, looks like you are right, nice catch. This is an automated message from

[GitHub] jmarantz commented on issue #1704: Redis cache TTL

2018-05-08 Thread GitBox
jmarantz commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387400092 @oschaaf thanks for pulling up the example. I missed in the PR review that the DB-index is not in the map key. I think it needs to be incorporated

[GitHub] jmarantz opened a new issue #1771: Redis DB index aliasing

2018-05-08 Thread GitBox
jmarantz opened a new issue #1771: Redis DB index aliasing URL: https://github.com/apache/incubator-pagespeed-mod/issues/1771 Looking at the code, I believe that if two different VirtualHosts in the same config construct redis caches that differ only DB-index then the first one will win, a

[GitHub] jmarantz commented on issue #1704: Redis cache TTL

2018-05-08 Thread GitBox
jmarantz commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387413295 RE the original premise of this feature-request; I have a couple of questions: 1. Won't Redis evict uninteresting keys based on some reasonabl

[GitHub] jmarantz commented on issue #1704: Redis cache TTL

2018-05-08 Thread GitBox
jmarantz commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387400092 @oschaaf thanks for pulling up the example. I missed in the PR review that the DB-index is not in the map key. I think it needs to be incorporated

[GitHub] oschaaf commented on issue #1704: Redis cache TTL

2018-05-08 Thread GitBox
oschaaf commented on issue #1704: Redis cache TTL URL: https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387341073 https://github.com/pagespeed/mod_pagespeed/pull/1627/files shows plumbing that is similar to what would be needed to implement this.

[GitHub] ebaystaticfile opened a new issue #1555: centos 6.9 Installing nginx with 1.13.35.1-beta fails

2018-05-08 Thread GitBox
ebaystaticfile opened a new issue #1555: centos 6.9 Installing nginx with 1.13.35.1-beta fails URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1555 # **history command** > cd /www/server/nginx/ > NPS_VERSION=1.13.35.1-beta > wget https://github.com/apache/incubat