[GitHub] huguesalary commented on issue #1756: hint_preload_subresources filter not working as intended

2018-06-27 Thread GitBox
huguesalary commented on issue #1756: hint_preload_subresources filter not working as intended URL: https://github.com/apache/incubator-pagespeed-mod/issues/1756#issuecomment-400823684 I am running into the exact same issue for MPS 1.13.35.2-stable (apache). The example, however,

[GitHub] oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400822330 No problem. If you intend to have a go at making changes, let me know, I'd be happy to assist / review.

[GitHub] brianbest closed issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
brianbest closed issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574 This is an automated message from the Apache Git Service. To respond to the

[GitHub] njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400820969 Thanks for all your help @oschaaf! This is an

[GitHub] njakobsen edited a comment on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen edited a comment on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400820969 Will do. Thanks for all your help @oschaaf!

[GitHub] oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400818085 The design doc I posted above would probably be worth closely looking at too, but I think a good starting point to

[GitHub] njakobsen edited a comment on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen edited a comment on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400814920 Ha! Posted that 14 seconds before you :) Oh, actually I see our suggestions are slightly different,

[GitHub] njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400814920 Ha! Posted that 14 seconds before you :) This is

[GitHub] oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400814705 I see. One thought I have is that maybe a stale-while-revalidate (like) mechanism would be helpful here. Stale data

[GitHub] njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400814633 What I was hoping to get clarification on was when a Pagespeed cache entry is stale, is there a reason it _must_

[GitHub] njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400812125 We have a mix of high traffic and low traffic pages. We are trying to boost the perceived speed for users, as

[GitHub] oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400809317 When it is time to re-beacon, pagespeed will inject js into the html to make that happen. So you would be seeing

[GitHub] njakobsen edited a comment on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen edited a comment on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400802823 ...and after the TTL it always deletes the optimization instead of checking if the underlying page has

[GitHub] njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400802823 ...and after the TTL it always deletes the optimization instead of checking if the underlying page has actually

[GitHub] oschaaf edited a comment on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf edited a comment on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400792374 As far as critical css/image data is concerned, I think yes, correct. Other filters use different ways to

[GitHub] njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400787853 So changes to an underlying page that happen within the beacon timer do not invalidate the Pagespeed cache? Only

[GitHub] oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400781258 Pagespeed is only able to detect changes when the beacon js is delivered, which in turn only happens on a cold

[GitHub] brianbest commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
brianbest commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400778491 Thanks for the quick reply @oschaaf. Just one more question on this it looks like Pagespeed can detect when the

[GitHub] oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400777046 There is https://github.com/apache/incubator-pagespeed-mod/wiki/Design-Doc:-Critical-CSS-Beaconing Bumping

[GitHub] brianbest opened a new issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
brianbest opened a new issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574 Hey all, I'm looking for some information on how `prioritize_critical_css` works and why. I've seen some other issues