[GitHub] jmarantz commented on issue #1578: goog.crypt.base64 not working after pagespeed is enabled

2018-07-12 Thread GitBox 
jmarantz commented on issue #1578: goog.crypt.base64 not working after 
pagespeed is enabled
URL: 
https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-404562822
 
 
   The compile can't be run from your web page. It's run by installing it on
   your workstation and incorporating it into a process for compiling your
   JavaScript source code into new JavaScript that is suitable for delivery on
   the web.
   
   AFAIK the libraries you are using are intended only for use with the
   closure compiler. So if you have not incorporated I'm very curious to know
   how you're loading the JavaScript.  E.g. are you hosting the closure
   compiler source JS yourself?
   
   
   On Thu, Jul 12, 2018 at 4:22 PM NisariAIT  wrote:
   
   > @jmarantz , How can I check if the script is
   > using a compiler? The script is as below:
   > goog.require('goog.crypt.base64');
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] NisariAIT edited a comment on issue #1578: goog.crypt.base64 not working after pagespeed is enabled

2018-07-12 Thread GitBox 
NisariAIT edited a comment on issue #1578: goog.crypt.base64 not working after 
pagespeed is enabled
URL: 
https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-404510025
 
 
   @jmarantz, Can you tell me how I can check if the script is using a 
compiler? I am not sure how the library is compiled.  The script used is:
   
   goog.require('goog.crypt.base64');
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] NisariAIT edited a comment on issue #1578: goog.crypt.base64 not working after pagespeed is enabled

2018-07-12 Thread GitBox 
NisariAIT edited a comment on issue #1578: goog.crypt.base64 not working after 
pagespeed is enabled
URL: 
https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-404510025
 
 
   @jmarantz, How can I check if the script is using a compiler? I am not sure 
how the library is compiled.  The script is as below:
   goog.require('goog.crypt.base64');
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] NisariAIT edited a comment on issue #1578: goog.crypt.base64 not working after pagespeed is enabled

2018-07-12 Thread GitBox 
NisariAIT edited a comment on issue #1578: goog.crypt.base64 not working after 
pagespeed is enabled
URL: 
https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-404510025
 
 
   @jmarantz, How can I check if the script is using a compiler? I am not sure 
how the library is compiled.  The script used is:
   goog.require('goog.crypt.base64');
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] NisariAIT edited a comment on issue #1578: goog.crypt.base64 not working after pagespeed is enabled

2018-07-12 Thread GitBox 
NisariAIT edited a comment on issue #1578: goog.crypt.base64 not working after 
pagespeed is enabled
URL: 
https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-404510025
 
 
   @jmarantz, How can I check if the script is using a compiler? I am not sure 
how the library is compiled.  The script used is:
   
   goog.require('goog.crypt.base64');
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] NisariAIT commented on issue #1578: goog.crypt.base64 not working after pagespeed is enabled

2018-07-12 Thread GitBox 
NisariAIT commented on issue #1578: goog.crypt.base64 not working after 
pagespeed is enabled
URL: 
https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-404510025
 
 
   @jmarantz, How can I check if the script is using a compiler? The script is 
as below:
   goog.require('goog.crypt.base64');
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] NisariAIT removed a comment on issue #1578: goog.crypt.base64 not working after pagespeed is enabled

2018-07-12 Thread GitBox 
NisariAIT removed a comment on issue #1578: goog.crypt.base64 not working after 
pagespeed is enabled
URL: 
https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-404495259
 
 
   @jmarantz, I am not compiling javascript using closure compiler. I have not 
installed a compiler/builder(https://developers.google.com/closure/compiler/) 
as well. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] NisariAIT edited a comment on issue #1578: goog.crypt.base64 not working after pagespeed is enabled

2018-07-12 Thread GitBox 
NisariAIT edited a comment on issue #1578: goog.crypt.base64 not working after 
pagespeed is enabled
URL: 
https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-404495259
 
 
   @jmarantz, I am not compiling javascript using closure compiler. I have not 
installed a compiler/builder(https://developers.google.com/closure/compiler/) 
as well. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jmarantz commented on issue #1578: goog.crypt.base64 not working after pagespeed is enabled

2018-07-12 Thread GitBox 
jmarantz commented on issue #1578: goog.crypt.base64 not working after 
pagespeed is enabled
URL: 
https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-404475184
 
 
   How are you integrating the closure-library? Are you compiling
    your JavaScript with the
   closure library? Usually goog.require doesn't run when you load the page;
   it is handled at the compilation step. There are various ad-hoc ways of
   getting around this so you can load your closure-library dependencies
   without a compilation step. I use them myself, but only for debugging
   JavaScript.
   
   It's possible that PageSpeed's use of closure-compiled libraries (e.g. for
   detecting above-the-fold images) is interfering with some ad-hoc mechanism
   you've picked up somewhere. Or maybe PageSpeed's renaming of JavaScript
   files is getting in the way of that ad-hoc mechanism.
   
   It should be easy to get to the bottom of this if you give more detail
   about how you are using the closure library.
   
   
   On Thu, Jul 12, 2018 at 11:07 AM NisariAIT  wrote:
   
   > No @Lofesa . I have not enabled defer
   > javascript.
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] NisariAIT edited a comment on issue #1578: goog.crypt.base64 not working after pagespeed is enabled

2018-07-12 Thread GitBox 
NisariAIT edited a comment on issue #1578: goog.crypt.base64 not working after 
pagespeed is enabled
URL: 
https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-404426852
 
 
   No @Lofesa. I have not enabled defer javascript.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] NisariAIT edited a comment on issue #1578: goog.crypt.base64 not working after pagespeed is enabled

2018-07-12 Thread GitBox 
NisariAIT edited a comment on issue #1578: goog.crypt.base64 not working after 
pagespeed is enabled
URL: 
https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-404426852
 
 
   No @Lofesa. I have not enabled defer javascript. Also, I have noticed that 
once I restart nginx, the first load fetches everything correctly. From the 
second time again the issue persists.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] NisariAIT edited a comment on issue #1578: goog.crypt.base64 not working after pagespeed is enabled

2018-07-12 Thread GitBox 
NisariAIT edited a comment on issue #1578: goog.crypt.base64 not working after 
pagespeed is enabled
URL: 
https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-404426852
 
 
   No @Lofesa. I have not enabled defer javascript. Also, I have noticed that 
once I restart nginx, the first load fetches everything correctly. Fromthe 
second time again the issue persists.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] NisariAIT commented on issue #1578: goog.crypt.base64 not working after pagespeed is enabled

2018-07-12 Thread GitBox 
NisariAIT commented on issue #1578: goog.crypt.base64 not working after 
pagespeed is enabled
URL: 
https://github.com/apache/incubator-pagespeed-ngx/issues/1578#issuecomment-404426852
 
 
   No @Lofesa. I have not enabled defer javascript.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services