[GitHub] [incubator-pagespeed-mod] oschaaf commented on issue #2084: bazel build / psol

2021-10-18 Thread GitBox
oschaaf commented on issue #2084: URL: https://github.com/apache/incubator-pagespeed-mod/issues/2084#issuecomment-946111536 I wouldn't say doomed.. but it will require some effort to get ngx_pagespeed to work with the bleeding edge / bazel build system. The path of least resistance is

[GitHub] [incubator-pagespeed-mod] eilandert edited a comment on issue #2084: bazel build / psol

2021-10-18 Thread GitBox
eilandert edited a comment on issue #2084: URL: https://github.com/apache/incubator-pagespeed-mod/issues/2084#issuecomment-946102223 @oschaaf Does that mean we are doomed to use the latest-stable tag? I am trying to cook some things up with docker (

[GitHub] [incubator-pagespeed-mod] eilandert commented on issue #2084: bazel build / psol

2021-10-18 Thread GitBox
eilandert commented on issue #2084: URL: https://github.com/apache/incubator-pagespeed-mod/issues/2084#issuecomment-946102223 @oschaaf Does that mean we are doomed to use the latest-stable tag? I am trying to cook some things up with docker (

[GitHub] [incubator-pagespeed-mod] oschaaf commented on issue #2084: bazel build / psol

2021-10-18 Thread GitBox
oschaaf commented on issue #2084: URL: https://github.com/apache/incubator-pagespeed-mod/issues/2084#issuecomment-946051372 I don't think I ever really got to producing/testing a standalone `pagespeed_automatic.a`. Checking I did find this script, but unfortunately I left no

[GitHub] [incubator-pagespeed-mod] eilandert edited a comment on issue #2084: bazel build / psol

2021-10-18 Thread GitBox
eilandert edited a comment on issue #2084: URL: https://github.com/apache/incubator-pagespeed-mod/issues/2084#issuecomment-946012731 > What do you need to add that `#include` into? > > pagespeed_automatic.a is an intermediate library which can be used to build the Apache or nginx

[GitHub] [incubator-pagespeed-mod] eilandert commented on issue #2084: bazel build / psol

2021-10-18 Thread GitBox
eilandert commented on issue #2084: URL: https://github.com/apache/incubator-pagespeed-mod/issues/2084#issuecomment-946012731 > What do you need to add that `#include` into? > > pagespeed_automatic.a is an intermediate library which can be used to build the Apache or nginx

[GitHub] [incubator-pagespeed-mod] jmarantz commented on issue #2084: bazel build / psol

2021-10-18 Thread GitBox
jmarantz commented on issue #2084: URL: https://github.com/apache/incubator-pagespeed-mod/issues/2084#issuecomment-945991794 What do you need to add that `#include` into? pagespeed_automatic.a is an intermediate library which can be used to build the Apache or nginx versions. --

[GitHub] [incubator-pagespeed-mod] eilandert opened a new issue #2084: bazel build

2021-10-18 Thread GitBox
eilandert opened a new issue #2084: URL: https://github.com/apache/incubator-pagespeed-mod/issues/2084 @oschaaf or whoever knows how to do this ... :-) First, when I build with bazel I need to add #include to pagespeed/kernel/base/string.h or else bazel build will fail. When