[GitHub] Dead2 commented on issue #1775: Deadlock in shm statistics

2018-06-06 Thread GitBox
Dead2 commented on issue #1775: Deadlock in shm statistics URL: https://github.com/apache/incubator-pagespeed-mod/issues/1775#issuecomment-394993817 The other proxy is an Nginx one for load-balancing and caching without touching the application server, and we don't want mod_pagespeed at

[GitHub] oschaaf commented on issue #1773: inline_javascript should not inline scripts with a defer-attribute

2018-05-29 Thread GitBox
oschaaf commented on issue #1773: inline_javascript should not inline scripts with a defer-attribute URL: https://github.com/apache/incubator-pagespeed-mod/issues/1773#issuecomment-392789536 @morlovich left a relevant comment in the filter:

[GitHub] Dreamsorcerer opened a new issue #1772: collapse_whitespace in

2018-05-28 Thread GitBox
Dreamsorcerer opened a new issue #1772: collapse_whitespace in URL: https://github.com/apache/incubator-pagespeed-mod/issues/1772 The documentation says: > ..is normally ignored by the browser outside of tags like pre> and , one can use CSS properties such as "white-space: pre" to

[GitHub] oschaaf commented on issue #1772: collapse_whitespace in

2018-05-28 Thread GitBox
oschaaf commented on issue #1772: collapse_whitespace in URL: https://github.com/apache/incubator-pagespeed-mod/issues/1772#issuecomment-392530161 Sounds reasonable to me, and looks like it's easy to accomplish. It looks like it is just a matter of adding `` to `kSensitiveTags` here:

[GitHub] tspicer commented on issue #1181: Support Alpine

2018-05-31 Thread GitBox
tspicer commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-393522885 @nberlee so the solution is to use the actual docker build and all the associated patches from https://github.com/We-Amp/ngx-pagespeed-alpine rather

[GitHub] oschaaf commented on issue #1763: Ubuntu 16.04 : make apache_install_conf fails

2018-06-04 Thread GitBox
oschaaf commented on issue #1763: Ubuntu 16.04 : make apache_install_conf fails URL: https://github.com/apache/incubator-pagespeed-mod/issues/1763#issuecomment-394360773 I wouldn't expect that to be needed, if the script still fails I would think either `PAGESPEED_TEST_HOST` is pointing

[GitHub] morlovich commented on issue #1785: Fix mismatch between decompression and headers

2018-07-02 Thread GitBox
morlovich commented on issue #1785: Fix mismatch between decompression and headers URL: https://github.com/apache/incubator-pagespeed-mod/pull/1785#issuecomment-401771386 (Note that I've only ran this through unit tests...) The high risk point is probably using the headers in

[GitHub] hotaery opened a new issue #1576: I compile nginx with pagespeed module, but encounter some problems with undefined reference.

2018-07-01 Thread GitBox
hotaery opened a new issue #1576: I compile nginx with pagespeed module, but encounter some problems with undefined reference. URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1576 this is my system enviroment: ``` #uname -a Linux localhost.localdomain

[GitHub] ivanionut commented on issue #1572: Fetch as Google & images Temporarily unreachable

2018-06-26 Thread GitBox
ivanionut commented on issue #1572: Fetch as Google & images Temporarily unreachable URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1572#issuecomment-400407643 @Lofesa, in my opinion you're a bit confused... ``` User-agent: * Disallow: / ``` The

[GitHub] Lofesa commented on issue #1572: Fetch as Google & images Temporarily unreachable

2018-06-26 Thread GitBox
Lofesa commented on issue #1572: Fetch as Google & images Temporarily unreachable URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1572#issuecomment-400411446 I know, I know. but is not "Disallow: / ", I talk about "Disallow:" w/o the slash, as you can see in the

[GitHub] ivanionut commented on issue #1572: Fetch as Google & images Temporarily unreachable

2018-06-26 Thread GitBox
ivanionut commented on issue #1572: Fetch as Google & images Temporarily unreachable URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1572#issuecomment-400442020 ok, I understand. but robots.txt is ok as it is.

[GitHub] Lofesa commented on issue #1572: Fetch as Google & images Temporarily unreachable

2018-06-26 Thread GitBox
Lofesa commented on issue #1572: Fetch as Google & images Temporarily unreachable URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1572#issuecomment-400403915 Hi @ivanionut I know that the Allow directive is valid.. but is not a

[GitHub] Lofesa edited a comment on issue #1572: Fetch as Google & images Temporarily unreachable

2018-06-26 Thread GitBox
Lofesa edited a comment on issue #1572: Fetch as Google & images Temporarily unreachable URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1572#issuecomment-400411446 I know, I know. but is not "Disallow: / ", I talk about "Disallow:" w/o the slash, as you can see in the

[GitHub] Lofesa edited a comment on issue #1572: Fetch as Google & images Temporarily unreachable

2018-06-26 Thread GitBox
Lofesa edited a comment on issue #1572: Fetch as Google & images Temporarily unreachable URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1572#issuecomment-400411446 I know, I know. but is not "Disallow: / ", I talk about "Disallow:" w/o the slash, as you can see in the

[GitHub] brianbest commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
brianbest commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400778491 Thanks for the quick reply @oschaaf. Just one more question on this it looks like Pagespeed can detect when the

[GitHub] njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400787853 So changes to an underlying page that happen within the beacon timer do not invalidate the Pagespeed cache? Only

[GitHub] oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400809317 When it is time to re-beacon, pagespeed will inject js into the html to make that happen. So you would be seeing

[GitHub] brianbest opened a new issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
brianbest opened a new issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574 Hey all, I'm looking for some information on how `prioritize_critical_css` works and why. I've seen some other issues

[GitHub] oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400777046 There is https://github.com/apache/incubator-pagespeed-mod/wiki/Design-Doc:-Critical-CSS-Beaconing Bumping

[GitHub] oschaaf edited a comment on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf edited a comment on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400792374 As far as critical css/image data is concerned, I think yes, correct. Other filters use different ways to

[GitHub] njakobsen edited a comment on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen edited a comment on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400802823 ...and after the TTL it always deletes the optimization instead of checking if the underlying page has

[GitHub] njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400802823 ...and after the TTL it always deletes the optimization instead of checking if the underlying page has actually

[GitHub] oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400781258 Pagespeed is only able to detect changes when the beacon js is delivered, which in turn only happens on a cold

[GitHub] njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400812125 We have a mix of high traffic and low traffic pages. We are trying to boost the perceived speed for users, as

[GitHub] njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400814920 Ha! Posted that 14 seconds before you :) This is

[GitHub] huguesalary commented on issue #1756: hint_preload_subresources filter not working as intended

2018-06-27 Thread GitBox
huguesalary commented on issue #1756: hint_preload_subresources filter not working as intended URL: https://github.com/apache/incubator-pagespeed-mod/issues/1756#issuecomment-400823684 I am running into the exact same issue for MPS 1.13.35.2-stable (apache). The example, however,

[GitHub] njakobsen edited a comment on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen edited a comment on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400814920 Ha! Posted that 14 seconds before you :) Oh, actually I see our suggestions are slightly different,

[GitHub] njakobsen edited a comment on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen edited a comment on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400820969 Will do. Thanks for all your help @oschaaf!

[GitHub] njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400820969 Thanks for all your help @oschaaf! This is an

[GitHub] brianbest closed issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
brianbest closed issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574 This is an automated message from the Apache Git Service. To respond to the

[GitHub] njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400814633 What I was hoping to get clarification on was when a Pagespeed cache entry is stale, is there a reason it _must_

[GitHub] oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400814705 I see. One thought I have is that maybe a stale-while-revalidate (like) mechanism would be helpful here. Stale data

[GitHub] oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400818085 The design doc I posted above would probably be worth closely looking at too, but I think a good starting point to

[GitHub] oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400822330 No problem. If you intend to have a go at making changes, let me know, I'd be happy to assist / review.

[GitHub] Lofesa edited a comment on issue #1572: Fetch as Google & images Temporarily unreachable

2018-06-26 Thread GitBox
Lofesa edited a comment on issue #1572: Fetch as Google & images Temporarily unreachable URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1572#issuecomment-400223485 Hi I don´t know why google bot had problem to fecht you resources, but I think is not pagespeed related.

[GitHub] Lofesa commented on issue #1572: Fetch as Google & images Temporarily unreachable

2018-06-26 Thread GitBox
Lofesa commented on issue #1572: Fetch as Google & images Temporarily unreachable URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1572#issuecomment-400223485 Hi I don´t know why google bot had problem to fecht you resources, but I think is not pagespeed related. I you

[GitHub] ivanionut commented on issue #1572: Fetch as Google & images Temporarily unreachable

2018-06-26 Thread GitBox
ivanionut commented on issue #1572: Fetch as Google & images Temporarily unreachable URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1572#issuecomment-400225988 Hi @Lofesa , I thank you for your reply but the directive in the robots.txt file is correct.

[GitHub] bachi76 edited a comment on issue #1644: pagespeed css request times out with 404 while optimizing

2018-06-19 Thread GitBox
bachi76 edited a comment on issue #1644: pagespeed css request times out with 404 while optimizing URL: https://github.com/apache/incubator-pagespeed-mod/issues/1644#issuecomment-398428265 > If a .pagespeed. resource can't be fetched and rewritten in the timeout, a 404 is returned and

[GitHub] bachi76 commented on issue #1644: pagespeed css request times out with 404 while optimizing

2018-06-19 Thread GitBox
bachi76 commented on issue #1644: pagespeed css request times out with 404 while optimizing URL: https://github.com/apache/incubator-pagespeed-mod/issues/1644#issuecomment-398428265 > If a .pagespeed. resource can't be fetched and rewritten in the timeout, a 404 is returned and the web

[GitHub] morlovich commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-07-01 Thread GitBox
morlovich commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-401620584 Unit test on https://github.com/apache/incubator-pagespeed-mod/tree/morlovich-fix-encoding-mismatch

[GitHub] morlovich opened a new pull request #1785: Fix mismatch between decompression and headers

2018-07-01 Thread GitBox
morlovich opened a new pull request #1785: Fix mismatch between decompression and headers URL: https://github.com/apache/incubator-pagespeed-mod/pull/1785 Fix mismatch between headers and demand-uncompressed payload when hitting rewrite deadline with gzip'ed input. Believed to fix

[GitHub] LiamMcArthur closed issue #722: Unknown directive "pagespeed" in /etc/nginx/nginx.conf:43

2018-07-03 Thread GitBox
LiamMcArthur closed issue #722: Unknown directive "pagespeed" in /etc/nginx/nginx.conf:43 URL: https://github.com/apache/incubator-pagespeed-ngx/issues/722 This is an automated message from the Apache Git Service. To

[GitHub] oschaaf commented on issue #1785: Fix mismatch between decompression and headers

2018-07-03 Thread GitBox
oschaaf commented on issue #1785: Fix mismatch between decompression and headers URL: https://github.com/apache/incubator-pagespeed-mod/pull/1785#issuecomment-402106655 Awesome! This passes `apache_debug_smoke_test`, but the `checkin` tests fail when running `apache_debug_slurp_test`.

[GitHub] oschaaf opened a new pull request #1770: Doc: Apache incubator branding, irc & pre-apache releases

2018-04-30 Thread GitBox
oschaaf opened a new pull request #1770: Doc: Apache incubator branding, irc & pre-apache releases URL: https://github.com/apache/incubator-pagespeed-mod/pull/1770 * Fix incubator branding policy * Mention package are pre-apache releases * Mention #pagespeed IRC channel under

[GitHub] nberlee commented on issue #1181: Support Alpine

2018-05-01 Thread GitBox
nberlee commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-385803288 https://github.com/We-Amp/ngx-pagespeed-alpine All changes of dev are now merged in master. I was running dev in production for some time (also

[GitHub] oschaaf commented on issue #1181: Support Alpine

2018-05-01 Thread GitBox
oschaaf commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-385816899 @nberlee can you ping me at osch...@we-amp.com? This is an automated message from

[GitHub] denigmus commented on issue #1073: Support FreeBSD

2018-05-02 Thread GitBox
denigmus commented on issue #1073: Support FreeBSD URL: https://github.com/apache/incubator-pagespeed-mod/issues/1073#issuecomment-385964141 Still no plans for ngx_pagespeed support FreeBSD? This is an automated message

[GitHub] oschaaf commented on issue #1073: Support FreeBSD

2018-05-02 Thread GitBox
oschaaf commented on issue #1073: Support FreeBSD URL: https://github.com/apache/incubator-pagespeed-mod/issues/1073#issuecomment-385971539 @denigmus As far as I know no-one currently is looking into ngx_pagespeed on FreeBSD. Having said that, @mmokhi's tackled nearly all of the

[GitHub] mmokhi commented on issue #1073: Support FreeBSD

2018-05-03 Thread GitBox
mmokhi commented on issue #1073: Support FreeBSD URL: https://github.com/apache/incubator-pagespeed-mod/issues/1073#issuecomment-386199161 On FreeBSD there is a Nginx port in the port-tree which is very straightforward to build (`make [config]; make install;`) and even easy to extend.

[GitHub] oschaaf closed issue #1769: v

2018-04-26 Thread GitBox
oschaaf closed issue #1769: v URL: https://github.com/apache/incubator-pagespeed-mod/issues/1769 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above

[GitHub] tspicer commented on issue #1181: Support Alpine

2018-05-01 Thread GitBox
tspicer commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-385607588 curious if there has been any progress. seems like things were close but got stuck.

[GitHub] eldk commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript

2018-05-01 Thread GitBox
eldk commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript URL: https://github.com/apache/incubator-pagespeed-mod/issues/1761#issuecomment-385647383 Hello, So the solution, as IPRO will optimize local pictures included in javascript, is

[GitHub] eldk commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript

2018-05-01 Thread GitBox
eldk commented on issue #1761: MapProxyDomain don't rewrite nor proxy pictures included in javascript URL: https://github.com/apache/incubator-pagespeed-mod/issues/1761#issuecomment-385647383 Hello, So the solution, as IPRO will optimize local pictures included in javascript, is

[GitHub] nberlee commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
nberlee commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356353214 @hgl The sed line was a workaround for a Alpine 3.7 busybox wait bug. (which never stopped waiting) This seems to be fixed since, making the line now

[GitHub] oppianmatt commented on issue #1524: build instructions no longer working for all versions

2018-01-09 Thread GitBox
oppianmatt commented on issue #1524: build instructions no longer working for all versions URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1524#issuecomment-356427654 after a bit of googling and testing found that psol moved to a new place and so that needs to be fixed.

[GitHub] nberlee commented on issue #1181: Support Alpine

2018-01-08 Thread GitBox
nberlee commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-355911513 @hgl I fixed compiling in Alpine 3.7... look at https://github.com/nberlee/ngx-pagespeed-alpine/tree/3.7

[GitHub] oschaaf commented on a change in pull request #1703: Removes deprecated mod_access_compat directives

2018-01-08 Thread GitBox
oschaaf commented on a change in pull request #1703: Removes deprecated mod_access_compat directives URL: https://github.com/apache/incubator-pagespeed-mod/pull/1703#discussion_r160168266 ## File path: install/common/pagespeed.conf.template ## @@ -321,15 +321,19 @@

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-08 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356047432 I am not sure yet, but it seems to be related to the nginx version. 1.12.2 seems to be working... 1.13.3 seems to be not. Can anyone confirm ? I am

[GitHub] vitaliytv opened a new pull request #1710: Update config_filters.html

2018-01-10 Thread GitBox
vitaliytv opened a new pull request #1710: Update config_filters.html URL: https://github.com/apache/incubator-pagespeed-mod/pull/1710 fix broken link to insert_image_dimensions This is an automated message from the Apache

[GitHub] googlebot commented on issue #1710: Update config_filters.html

2018-01-10 Thread GitBox
googlebot commented on issue #1710: Update config_filters.html URL: https://github.com/apache/incubator-pagespeed-mod/pull/1710#issuecomment-356851059 CLAs look good, thanks! This is an automated message from the

[GitHub] oschaaf commented on issue #968: Distribute PSOL and mod_pagespeed as a source tarball.

2018-01-11 Thread GitBox
oschaaf commented on issue #968: Distribute PSOL and mod_pagespeed as a source tarball. URL: https://github.com/apache/incubator-pagespeed-mod/issues/968#issuecomment-356868405 https://dl.google.com/dl/linux/mod-pagespeed/tar/beta/mod-pagespeed-beta-1.13.35.2-r0.tar.bz2

[GitHub] oppianmatt commented on issue #1707: Update build_ngx_pagespeed_from_source.html

2018-01-10 Thread GitBox
oppianmatt commented on issue #1707: Update build_ngx_pagespeed_from_source.html URL: https://github.com/apache/incubator-pagespeed-mod/pull/1707#issuecomment-356676091 builds and configures This is an automated message from

[GitHub] nberlee commented on issue #1181: Support Alpine

2018-01-10 Thread GitBox
nberlee commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356654833 @robov https://github.com/moby/moby/issues/7710 This is an automated message from the

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-10 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356577063 oops... my bad... forgot to pull your entire sources This is an automated message from

[GitHub] oschaaf commented on issue #1707: Update build_ngx_pagespeed_from_source.html

2018-01-10 Thread GitBox
oschaaf commented on issue #1707: Update build_ngx_pagespeed_from_source.html URL: https://github.com/apache/incubator-pagespeed-mod/pull/1707#issuecomment-356598953 @oppianmatt updated to fix the ./configure line, could you take a another look?

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-10 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356605923 When I do something like this on a container : docker cp extractfromcontainer:/usr/lib/libpng* compiled/usr/lib then it cannot find anything... when

[GitHub] oschaaf closed pull request #1707: Update build_ngx_pagespeed_from_source.html

2018-01-10 Thread GitBox
oschaaf closed pull request #1707: Update build_ngx_pagespeed_from_source.html URL: https://github.com/apache/incubator-pagespeed-mod/pull/1707 This is an automated message from the Apache Git Service. To respond to the

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356242099 @HGL AWESOME.. yes I was very frustrated that even my backup files did not work anymore... So I guess you are right

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356254153 @nberlee a quick question, why is [this line](https://github.com/nberlee/ngx-pagespeed-alpine/blob/3.7/Dockerfile#L47) necessary? I try to compile

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356253735 @robov in @nberlee's Dockerfile add ``` mv incubator-pagespeed-ngx-1.12.34.3-stable /tmp/ngx_pagespeed-1.12.34.3-stable && \ ```

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356242638 I am a pretty newbie... can you share your changed code ? This is an automated message

[GitHub] oschaaf commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
oschaaf commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356254446 With regard to the renaming of the repo, https://github.com/apache/incubator-pagespeed-ngx/commit/e733a838c35a0f2108768c2d1ead6fb7ee806cf8 was merged

[GitHub] oschaaf commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
oschaaf commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356254572 (The repo may be renamed again at some stage later on, and this change hopefully is resilient to that)

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356253735 @robov in @nberlee's Dockerfile add ``` mv /tmp/incubator-pagespeed-ngx-1.12.34.3-stable /tmp/ngx_pagespeed-1.12.34.3-stable && \ ```

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356255779 @oschaaf Thanks for the head up. But it seems `Dockerfile`s from most unofficial alpine images don't use this script. So they will continue to fail to

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356255779 @oschaaf Thanks for the head up. But it seems `Dockerfile`s from most unofficial alpine images don't use this script. So they'll continue to fail to

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356237144 After some digging, I found the root cause is that this project just got moved to `apache/incubator-pagespeed-ngx`, so after downloading the archive

[GitHub] oschaaf commented on issue #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds

2018-01-09 Thread GitBox
oschaaf commented on issue #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds URL: https://github.com/apache/incubator-pagespeed-mod/pull/1695#issuecomment-356278838 @jmarantz processed your comments in

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356277892 But since the name is tentative, that mv command could easily fail when that happens. A better approach: ``` mkdir -p

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356277277 Yes, that script is never used in the Dockerfile This is an automated message from the

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356277892 But since the name is tentative, that mv command could easily fail when that happens. A better approach: ``` mkdir -p

[GitHub] jmarantz commented on a change in pull request #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds

2018-01-08 Thread GitBox
jmarantz commented on a change in pull request #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds URL: https://github.com/apache/incubator-pagespeed-mod/pull/1695#discussion_r160147479 ## File path: pagespeed/apache/header_util.cc ## @@ -115,6 +115,9 @@

[GitHub] jadatkins commented on issue #1521: install from script fails due to new filename

2018-01-08 Thread GitBox
jadatkins commented on issue #1521: install from script fails due to new filename URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1521#issuecomment-355955246 Thanks @oschaaf, I can see how that works and it seems to work for me too. However, my work depends on automated

[GitHub] jmarantz commented on a change in pull request #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds

2018-01-08 Thread GitBox
jmarantz commented on a change in pull request #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds URL: https://github.com/apache/incubator-pagespeed-mod/pull/1695#discussion_r160147018 ## File path: net/instaweb/http/public/async_fetch.h ## @@ -316,6

[GitHub] jmarantz commented on a change in pull request #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds

2018-01-08 Thread GitBox
jmarantz commented on a change in pull request #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds URL: https://github.com/apache/incubator-pagespeed-mod/pull/1695#discussion_r160146665 ## File path: net/instaweb/http/async_fetch.cc ## @@ -276,6 +276,33 @@

[GitHub] jadatkins commented on issue #1521: install from script fails due to new filename

2018-01-08 Thread GitBox
jadatkins commented on issue #1521: install from script fails due to new filename URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1521#issuecomment-355955902 thanks @oschaaf This is an automated message from

[GitHub] arosenhagen opened a new issue #1521: install from script fails due to new filename

2018-01-08 Thread GitBox
arosenhagen opened a new issue #1521: install from script fails due to new filename URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1521 The script at https://ngxpagespeed.com/install fails to install ngx_pagespeed due to the new name ```incubator-pagespeed-ngx-$VERSION```.

[GitHub] jmarantz commented on a change in pull request #1703: Removes deprecated mod_access_compat directives

2018-01-08 Thread GitBox
jmarantz commented on a change in pull request #1703: Removes deprecated mod_access_compat directives URL: https://github.com/apache/incubator-pagespeed-mod/pull/1703#discussion_r160155613 ## File path: install/common/pagespeed.conf.template ## @@ -321,15 +321,19 @@

[GitHub] REPTILEHAUS opened a new issue #1522: Cannot install - issues with ngx_pagespeed.o

2018-01-08 Thread GitBox
REPTILEHAUS opened a new issue #1522: Cannot install - issues with ngx_pagespeed.o URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1522 I have a docker environment that i have deployed a couple of times and it has always worked except now when provisioning a new server the

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-08 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356011231 @ashishk-1 : When I try to build your dockerfile I get : adding module in /tmp/ngx_pagespeed-1.12.34.3-stable ./configure: error: no

[GitHub] oschaaf closed pull request #1706: Only perform semanage sequence once on CentOS

2018-01-08 Thread GitBox
oschaaf closed pull request #1706: Only perform semanage sequence once on CentOS URL: https://github.com/apache/incubator-pagespeed-mod/pull/1706 This is an automated message from the Apache Git Service. To respond to the

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-08 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356010210 @nberlee : When I try to build your dockerfile I get : ``` adding module in /tmp/ngx_pagespeed-1.12.34.3-stable ./configure: error: no

[GitHub] oschaaf commented on issue #1522: Cannot install - issues with ngx_pagespeed.o

2018-01-08 Thread GitBox
oschaaf commented on issue #1522: Cannot install - issues with ngx_pagespeed.o URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1522#issuecomment-356012833 Could the build process be running out of memory? This

[GitHub] jmarantz commented on a change in pull request #1523: Unbreak install after repo transfers

2018-01-08 Thread GitBox
jmarantz commented on a change in pull request #1523: Unbreak install after repo transfers URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1523#discussion_r160193605 ## File path: scripts/build_ngx_pagespeed.sh ## @@ -612,7 +612,8 @@ Not deleting $directory;

[GitHub] oschaaf closed issue #1522: Cannot install - issues with ngx_pagespeed.o

2018-01-08 Thread GitBox
oschaaf closed issue #1522: Cannot install - issues with ngx_pagespeed.o URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1522 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] oschaaf commented on issue #1522: Cannot install - issues with ngx_pagespeed.o

2018-01-08 Thread GitBox
oschaaf commented on issue #1522: Cannot install - issues with ngx_pagespeed.o URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1522#issuecomment-356022083 No problem, happy to hear its working now! This is an

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-08 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356024910 @nberlee Thanks for sharing. But I got the same error too. ``` configuring additional modules adding module in

[GitHub] oschaaf closed issue #1521: install from script fails due to new filename

2018-01-08 Thread GitBox
oschaaf closed issue #1521: install from script fails due to new filename URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1521 This is an automated message from the Apache Git Service. To respond to the

[GitHub] oschaaf closed pull request #1523: Unbreak install after repo transfers

2018-01-08 Thread GitBox
oschaaf closed pull request #1523: Unbreak install after repo transfers URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1523 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] oschaaf commented on issue #1521: install from script fails due to new filename

2018-01-08 Thread GitBox
oschaaf commented on issue #1521: install from script fails due to new filename URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1521#issuecomment-356026172 Should be fixed, please retry! This is an automated

<    1   2   3   4   5   6   7   8   9   10   >