[GitHub] njakobsen edited a comment on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen edited a comment on issue #1574: prioritize_critical_css 5 minutes 
clarification 
URL: 
https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400820969
 
 
   Will do. Thanks for all your help @oschaaf!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] njakobsen edited a comment on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen edited a comment on issue #1574: prioritize_critical_css 5 minutes 
clarification 
URL: 
https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400814920
 
 
   Ha! Posted that 14 seconds before you :)
   
   Oh, actually I see our suggestions are slightly different, but similar in 
that they would not have a period of time where no optimization is present.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] njakobsen edited a comment on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
njakobsen edited a comment on issue #1574: prioritize_critical_css 5 minutes 
clarification 
URL: 
https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400802823
 
 
   ...and after the TTL it always deletes the optimization instead of checking 
if the underlying page has actually changed first? Or should we be seeing a 
request from Pagespeed to the app server for the underlying page, and then a 
response to the browser from Pagespeed that includes the existing CSS 
optimization in the case where the underlying page has not changed)?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services