[GitHub] tspicer commented on issue #1181: Support Alpine
tspicer commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-393671432 @nberlee not the APK store, but just being able to compile as I would for another OS. At the moment the process to install is tightly coupled into a specific Dockerfile. If you are compiling from nginx source with alternate modules/packages and libraries, your choice is to 1) copy the docker file as provided and modify the nginx build as applicable, then customize any other parts that are warranted or 2) deconstruct the Dockerfile, grab the patches and attempt to incorporate into your own build. So no expectations were set by you :) I just want to make sure what you have referenced is the fix and in basically closes this issue. thanks @oschaaf for clarifying This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tspicer commented on issue #1181: Support Alpine
tspicer commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-393671432 @nberlee not the APK store, but just being able to compile as I would for another OS. At the moment the process to install is tightly coupled into a specific Dockerfile. If you are compiling from nginx source with alternate modules/packages and libraries, then the the choice, it seems, is to 1) copy the docker file as provided and modify the nginx build as applicable, then customize any other parts that are warranted or 2) deconstruct the Dockerfile, grab the patches and attempt to incorporate into your own build. So no expectations were set by you :) I just want to make sure what you have referenced is the fix and in basically closes this issue. thanks @oschaaf for clarifying This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tspicer commented on issue #1181: Support Alpine
tspicer commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-393522885 @nberlee so the solution is to use the actual docker build and all the associated patches from https://github.com/We-Amp/ngx-pagespeed-alpine rather than getting a ngx_pagespeed that can be used outside of that setup? In the case of someone having their own nginx docker build process or using an alternate project, we will need to disassemble the docker file and assets from We-Amp to understand how to get this functional. Am understanding that correctly? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tspicer commented on issue #1181: Support Alpine
tspicer commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-393025913 Any update? Also, will these changes be packaged into the base ngx build or is the model to provide a docker image with patches? Would prefer a stable ngx alpine build without docker wrapper. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tspicer commented on issue #1181: Support Alpine
tspicer commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-385607588 curious if there has been any progress. seems like things were close but got stuck. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services