[GitHub] [incubator-pagespeed-ngx] Danrancan commented on issue #1756: make: *** [Makefile:16: modules] Error 2 when compiling module only against patch aarch64 PSOL Libraries

2022-08-09 Thread GitBox
Danrancan commented on issue #1756: URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1756#issuecomment-1209330063 No I have never used the `patch` command. Should I be using that instead of my suggestion? I did end up using `git apply` command and things compiled correctly.

[GitHub] [incubator-pagespeed-ngx] Danrancan commented on issue #1756: make: *** [Makefile:16: modules] Error 2 when compiling module only against patch aarch64 PSOL Libraries

2022-08-08 Thread GitBox
Danrancan commented on issue #1756: URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1756#issuecomment-1208277403 > I am using my PR1750 patch for later nginx-1.23.0. https://github.com/shigechika/nginx-module-pagespeed/blob/master/PR1750.diff To actually apply this

[GitHub] [incubator-pagespeed-ngx] Danrancan commented on issue #1756: make: *** [Makefile:16: modules] Error 2 when compiling module only against patch aarch64 PSOL Libraries

2022-08-08 Thread GitBox
Danrancan commented on issue #1756: URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1756#issuecomment-1208158699 Thank you. I'm not a developer though and very new to applying patches. Do I just copy and paste this into the .cc file? What lines do I leave out and what lines

[GitHub] [incubator-pagespeed-ngx] Danrancan commented on issue #1756: make: *** [Makefile:16: modules] Error 2 when compiling module only against patch aarch64 PSOL Libraries

2022-08-03 Thread GitBox
Danrancan commented on issue #1756: URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1756#issuecomment-1204058621 > See #1749 (closing this as a duplicate -- this was resolved via #1751) Dang, I checked out your link and read through the conversations, but I can't find