[GitHub] oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-28 Thread GitBox
oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-401146456 That sounds right to me, under the precondition that the cache is sized appropriately. (Else eviction might

[GitHub] oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400822330 No problem. If you intend to have a go at making changes, let me know, I'd be happy to assist / review.

[GitHub] oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400818085 The design doc I posted above would probably be worth closely looking at too, but I think a good starting point to

[GitHub] oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400814705 I see. One thought I have is that maybe a stale-while-revalidate (like) mechanism would be helpful here. Stale data

[GitHub] oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400809317 When it is time to re-beacon, pagespeed will inject js into the html to make that happen. So you would be seeing

[GitHub] oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400781258 Pagespeed is only able to detect changes when the beacon js is delivered, which in turn only happens on a cold

[GitHub] oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification

2018-06-27 Thread GitBox
oschaaf commented on issue #1574: prioritize_critical_css 5 minutes clarification URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1574#issuecomment-400777046 There is https://github.com/apache/incubator-pagespeed-mod/wiki/Design-Doc:-Critical-CSS-Beaconing Bumping