[jira] [Commented] (PARQUET-438) Update RLE encoder/decoder modules from Impala upstream changes and adapt unit tests

2016-01-29 Thread Deepak Majeti (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124538#comment-15124538 ] Deepak Majeti commented on PARQUET-438: --- [~wesmckinn] I misunderstood the parquet-m

[jira] [Updated] (PARQUET-483) Write tests investigating failure modes with malformed encoded levels in data pages

2016-01-29 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wes McKinney updated PARQUET-483: - Summary: Write tests investigating failure modes with malformed encoded levels in data pages (wa

[jira] [Created] (PARQUET-483) Write tests investigate failure modes with malformed encoded levels in data pages

2016-01-29 Thread Wes McKinney (JIRA)
Wes McKinney created PARQUET-483: Summary: Write tests investigate failure modes with malformed encoded levels in data pages Key: PARQUET-483 URL: https://issues.apache.org/jira/browse/PARQUET-483 Pro

[jira] [Commented] (PARQUET-467) Check for and raise error for deprecated BIT_PACKED encoding

2016-01-29 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124182#comment-15124182 ] Wes McKinney commented on PARQUET-467: -- Per PARQUET-462 we can go ahead and implemen

[jira] [Commented] (PARQUET-438) Update RLE encoder/decoder modules from Impala upstream changes and adapt unit tests

2016-01-29 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124173#comment-15124173 ] Wes McKinney commented on PARQUET-438: -- [~mdeepak] If you identify a specific proble

[jira] [Updated] (PARQUET-462) Implement a LevelDecoder class (like Impala) which dispatches to RLE or BIT_PACKED decoding as appropriate

2016-01-29 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wes McKinney updated PARQUET-462: - Summary: Implement a LevelDecoder class (like Impala) which dispatches to RLE or BIT_PACKED decod

[jira] [Commented] (PARQUET-438) Update RLE encoder/decoder modules from Impala upstream changes and adapt unit tests

2016-01-29 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124123#comment-15124123 ] Wes McKinney commented on PARQUET-438: -- See https://github.com/apache/parquet-cpp/pu

[jira] [Commented] (PARQUET-438) Update RLE encoder/decoder modules from Impala upstream changes and adapt unit tests

2016-01-29 Thread Deepak Majeti (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124111#comment-15124111 ] Deepak Majeti commented on PARQUET-438: --- I briefly went through the Impala decoders

[jira] [Updated] (PARQUET-438) Update RLE encoder/decoder modules from Impala upstream changes and adapt unit tests

2016-01-29 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wes McKinney updated PARQUET-438: - Summary: Update RLE encoder/decoder modules from Impala upstream changes and adapt unit tests (w

[jira] [Commented] (PARQUET-463) Add DCHECK* macros for assertions in debug builds

2016-01-29 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124074#comment-15124074 ] Wes McKinney commented on PARQUET-463: -- These macros are all in Google's glog librar

[jira] [Resolved] (PARQUET-432) Complete a todo for method ColumnDescriptor.compareTo()

2016-01-29 Thread Cheng Lian (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Lian resolved PARQUET-432. Resolution: Fixed Issue resolved by pull request 314 [https://github.com/apache/parquet-mr/pull/314

Re: Organizing functional components and a bottom-up testing plan for parquet-cpp

2016-01-29 Thread Julien Le Dem
Sounds good to me. at some point (later) we'll have to do some cross compatibility testing with parquet-mr as well to make sure everything is on the same page. CC'ing some folks who should probably chime in. On Fri, Jan 29, 2016 at 10:21 AM, Wes McKinney wrote: > hi folks, > > Since there's so

[jira] [Resolved] (PARQUET-450) Small typos/issues in parquet-format documentation

2016-01-29 Thread Julien Le Dem (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Le Dem resolved PARQUET-450. --- Resolution: Fixed Fix Version/s: format-2.4.0 Issue resolved by pull request 36 [https

[jira] [Commented] (PARQUET-482) Organize src code file structure to have a very clear folder with public headers.

2016-01-29 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123926#comment-15123926 ] Wes McKinney commented on PARQUET-482: -- Effectively {{parquet/parquet.h}} is the onl

Organizing functional components and a bottom-up testing plan for parquet-cpp

2016-01-29 Thread Wes McKinney
hi folks, Since there's so many moving pieces with creating a full-featured Parquet reader-writer, I propose we start planning out a plan to create test fixtures and tools to enable us to develop faster. Specifically, we need to achieve maximum decoupling between functional components. Every unit

[jira] [Created] (PARQUET-482) Organize src code file structure to have a very clear folder with public headers.

2016-01-29 Thread Nong Li (JIRA)
Nong Li created PARQUET-482: --- Summary: Organize src code file structure to have a very clear folder with public headers. Key: PARQUET-482 URL: https://issues.apache.org/jira/browse/PARQUET-482 Project: Parq

[jira] [Updated] (PARQUET-482) Organize src code file structure to have a very clear folder with public headers.

2016-01-29 Thread Nong Li (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nong Li updated PARQUET-482: Component/s: parquet-cpp > Organize src code file structure to have a very clear folder with public > head

[jira] [Comment Edited] (PARQUET-481) Refactor and expand reader-test

2016-01-29 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123827#comment-15123827 ] Wes McKinney edited comment on PARQUET-481 at 1/29/16 5:26 PM:

[jira] [Commented] (PARQUET-481) Refactor and expand reader-test

2016-01-29 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123827#comment-15123827 ] Wes McKinney commented on PARQUET-481: -- I feel very strongly about keeping the low-l

[jira] [Updated] (PARQUET-472) Clean up InputStream ownership semantics in ColumnReader

2016-01-29 Thread Julien Le Dem (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Le Dem updated PARQUET-472: -- Fix Version/s: cpp-0.1 > Clean up InputStream ownership semantics in ColumnReader > ---

[jira] [Updated] (PARQUET-472) Clean up InputStream ownership semantics in ColumnReader

2016-01-29 Thread Julien Le Dem (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Le Dem updated PARQUET-472: -- Fix Version/s: (was: format-2.4.0) > Clean up InputStream ownership semantics in ColumnRead

[jira] [Created] (PARQUET-481) Refactor and expand reader-test

2016-01-29 Thread Aliaksei Sandryhaila (JIRA)
Aliaksei Sandryhaila created PARQUET-481: Summary: Refactor and expand reader-test Key: PARQUET-481 URL: https://issues.apache.org/jira/browse/PARQUET-481 Project: Parquet Issue Type:

[jira] [Resolved] (PARQUET-472) Clean up InputStream ownership semantics in ColumnReader

2016-01-29 Thread Julien Le Dem (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Le Dem resolved PARQUET-472. --- Resolution: Fixed Fix Version/s: format-2.4.0 Issue resolved by pull request 29 [https

[jira] [Comment Edited] (PARQUET-480) Update for Cascading 3.0

2016-01-29 Thread JIRA
[ https://issues.apache.org/jira/browse/PARQUET-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123708#comment-15123708 ] Cyrille Chépélov edited comment on PARQUET-480 at 1/29/16 4:35 PM:

[jira] [Commented] (PARQUET-480) Update for Cascading 3.0

2016-01-29 Thread JIRA
[ https://issues.apache.org/jira/browse/PARQUET-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123708#comment-15123708 ] Cyrille Chépélov commented on PARQUET-480: -- Pull request here: https://github.co

[jira] [Created] (PARQUET-480) Update for Cascading 3.0

2016-01-29 Thread JIRA
Cyrille Chépélov created PARQUET-480: Summary: Update for Cascading 3.0 Key: PARQUET-480 URL: https://issues.apache.org/jira/browse/PARQUET-480 Project: Parquet Issue Type: Improvement

[jira] [Commented] (PARQUET-479) Improve/expand functional unit tests

2016-01-29 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123660#comment-15123660 ] Wes McKinney commented on PARQUET-479: -- This is fine with me, as long as we don't ex

[jira] [Commented] (PARQUET-479) Improve/expand functional unit tests

2016-01-29 Thread Aliaksei Sandryhaila (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123642#comment-15123642 ] Aliaksei Sandryhaila commented on PARQUET-479: -- IMHO, it's not a big issue t

[jira] [Commented] (PARQUET-479) Improve/expand functional unit tests

2016-01-29 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123632#comment-15123632 ] Wes McKinney commented on PARQUET-479: -- I definitely don't want to bloat the git rep

[jira] [Commented] (PARQUET-479) Improve/expand functional unit tests

2016-01-29 Thread Aliaksei Sandryhaila (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123609#comment-15123609 ] Aliaksei Sandryhaila commented on PARQUET-479: -- So far the jira is a bit vag

[jira] [Commented] (PARQUET-479) Improve/expand functional unit tests

2016-01-29 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123598#comment-15123598 ] Wes McKinney commented on PARQUET-479: -- This JIRA does not have a well defined scope

[jira] [Updated] (PARQUET-479) Improve/expand functional unit tests

2016-01-29 Thread Aliaksei Sandryhaila (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aliaksei Sandryhaila updated PARQUET-479: - Summary: Improve/expand functional unit tests (was: Add regression tests to the

[jira] [Commented] (PARQUET-479) Add regression tests to the build process

2016-01-29 Thread Aliaksei Sandryhaila (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123583#comment-15123583 ] Aliaksei Sandryhaila commented on PARQUET-479: -- Ah, I missed that you've alr

[jira] [Commented] (PARQUET-479) Add regression tests to the build process

2016-01-29 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123574#comment-15123574 ] Wes McKinney commented on PARQUET-479: -- How is this different from just running the

[jira] [Commented] (PARQUET-479) Add regression tests to the build process

2016-01-29 Thread Aliaksei Sandryhaila (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123570#comment-15123570 ] Aliaksei Sandryhaila commented on PARQUET-479: -- In our case, regression test

[jira] [Commented] (PARQUET-479) Add regression tests to the build process

2016-01-29 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123564#comment-15123564 ] Wes McKinney commented on PARQUET-479: -- Can you explain how you envision regression

[jira] [Commented] (PARQUET-479) Add regression tests to the build process

2016-01-29 Thread Aliaksei Sandryhaila (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123565#comment-15123565 ] Aliaksei Sandryhaila commented on PARQUET-479: -- Since we do not have writing

[jira] [Created] (PARQUET-479) Add regression tests to the build process

2016-01-29 Thread Aliaksei Sandryhaila (JIRA)
Aliaksei Sandryhaila created PARQUET-479: Summary: Add regression tests to the build process Key: PARQUET-479 URL: https://issues.apache.org/jira/browse/PARQUET-479 Project: Parquet I