Re: How to set default maximum size of bloom filter?

2018-06-26 Thread 俊杰陈
Thanks, I agree to discuss when we working on write-side task. Ryan Blue 于2018年6月27日周三 上午7:25写道: > Thanks for the additional context, but I don't quite get why a utility > class like this would need to make a call on what the maximum size of a > bloom filter should be in the format. That's

Re: How to set default maximum size of bloom filter?

2018-06-26 Thread Ryan Blue
Thanks for the additional context, but I don't quite get why a utility class like this would need to make a call on what the maximum size of a bloom filter should be in the format. That's really a write-side concern. Can we just remove that code from the current PR and discuss it when we are

Re: How to set default maximum size of bloom filter?

2018-06-26 Thread 俊杰陈
Hi Ryan, The last comment on doc is to provide a benchmark for dictionary vs Bloom filter, I provided benchmark result here , Jim have reviewed this and updated comments on JIRA also. You can

Re: How to set default maximum size of bloom filter?

2018-06-26 Thread Ryan Blue
I thought the plan was to finish the bloom filter spec and then decide how to create appropriately sized filters. This sounds like a write-side implementation detail to me. What is the current plan for getting this work in? On Mon, Jun 25, 2018 at 8:43 PM 俊杰陈 wrote: > Hi devs > > I'm now

[jira] [Commented] (PARQUET-1300) [C++] Parquet modular encryption

2018-06-26 Thread Deepak Majeti (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523726#comment-16523726 ] Deepak Majeti commented on PARQUET-1300: [~thamha], I have not started writing any code in

[jira] [Commented] (PARQUET-1252) [C++] Pass BOOST_ROOT and Boost_NAMESPACE on to Thrift EP

2018-06-26 Thread Tham (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523577#comment-16523577 ] Tham commented on PARQUET-1252: --- {quote}it should be helpful if Boost_USE_STATIC_LIBS is passed on to

[jira] [Comment Edited] (PARQUET-1300) [C++] Parquet modular encryption

2018-06-26 Thread Tham (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523387#comment-16523387 ] Tham edited comment on PARQUET-1300 at 6/26/18 8:10 AM: Thanks [~gershinsky].

[jira] [Commented] (PARQUET-1300) [C++] Parquet modular encryption

2018-06-26 Thread Tham (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523387#comment-16523387 ] Tham commented on PARQUET-1300: --- Thanks [~gershinsky]. Looking forward to your PR with second cipher.

[jira] [Resolved] (PARQUET-1336) PrimitiveComparator should implements Serializable

2018-06-26 Thread Gabor Szadovszky (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Szadovszky resolved PARQUET-1336. --- Resolution: Fixed > PrimitiveComparator should implements Serializable >

[jira] [Commented] (PARQUET-1336) PrimitiveComparator should implements Serializable

2018-06-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523352#comment-16523352 ] ASF GitHub Bot commented on PARQUET-1336: - gszadovszky closed pull request #497: PARQUET-1336:

[jira] [Commented] (PARQUET-1300) [C++] Parquet modular encryption

2018-06-26 Thread Gidon Gershinsky (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523308#comment-16523308 ] Gidon Gershinsky commented on PARQUET-1300: --- [~thamha] Sounds good, I'll update then the

[jira] [Commented] (PARQUET-1300) [C++] Parquet modular encryption

2018-06-26 Thread Tham (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523291#comment-16523291 ] Tham commented on PARQUET-1300: --- [~gershinsky] My code is based on 2 pull requests you created for 

[jira] [Commented] (PARQUET-1300) [C++] Parquet modular encryption

2018-06-26 Thread Gidon Gershinsky (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523271#comment-16523271 ] Gidon Gershinsky commented on PARQUET-1300: --- The Java version > [C++] Parquet modular

[jira] [Commented] (PARQUET-1300) [C++] Parquet modular encryption

2018-06-26 Thread Gidon Gershinsky (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523267#comment-16523267 ] Gidon Gershinsky commented on PARQUET-1300: --- [~thamha] this is excellent news! In