[jira] [Commented] (PARQUET-2149) Implement async IO for Parquet file reader

[ https://issues.apache.org/jira/browse/PARQUET-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556480#comment-17556480 ] ASF GitHub Bot commented on PARQUET-2149: - parthchandra commented on PR #968: URL:

[GitHub] [parquet-mr] parthchandra commented on pull request #968: PARQUET-2149: Async IO implementation for ParquetFileReader

parthchandra commented on PR #968: URL: https://github.com/apache/parquet-mr/pull/968#issuecomment-1160693399 @shangxinli Thank you for the review! I'll address these comments asap. I am reviewing the thread pool and its initialization. IMO, it is better if there is no default

[jira] [Commented] (PARQUET-2149) Implement async IO for Parquet file reader

[ https://issues.apache.org/jira/browse/PARQUET-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556467#comment-17556467 ] ASF GitHub Bot commented on PARQUET-2149: - steveloughran commented on code in PR #968: URL:

[GitHub] [parquet-mr] steveloughran commented on a diff in pull request #968: PARQUET-2149: Async IO implementation for ParquetFileReader

steveloughran commented on code in PR #968: URL: https://github.com/apache/parquet-mr/pull/968#discussion_r901859862 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -126,6 +127,42 @@ public class ParquetFileReader implements Closeable {

[jira] [Commented] (PARQUET-2134) Incorrect type checking in HadoopStreams.wrap

[ https://issues.apache.org/jira/browse/PARQUET-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556465#comment-17556465 ] ASF GitHub Bot commented on PARQUET-2134: - steveloughran commented on code in PR #951: URL:

[GitHub] [parquet-mr] steveloughran commented on a diff in pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap

steveloughran commented on code in PR #951: URL: https://github.com/apache/parquet-mr/pull/951#discussion_r901856428 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/HadoopStreams.java: ## @@ -50,51 +46,45 @@ public class HadoopStreams { */ public static

[jira] [Commented] (PARQUET-2150) parquet-protobuf to compile on mac M1

[ https://issues.apache.org/jira/browse/PARQUET-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556450#comment-17556450 ] ASF GitHub Bot commented on PARQUET-2150: - steveloughran commented on PR #970: URL:

[GitHub] [parquet-mr] steveloughran commented on pull request #970: PARQUET-2150: parquet-protobuf to compile on Mac M1

steveloughran commented on PR #970: URL: https://github.com/apache/parquet-mr/pull/970#issuecomment-1160638077 this patch is based on Dongjoon;s one for hadoop, tells maven to use the x86 artifact on macbook m1 builds. the sunchao one switches to a version of protobuf with a genuine

[jira] [Commented] (PARQUET-2069) Parquet file containing arrays, written by Parquet-MR, cannot be read again by Parquet-MR

[ https://issues.apache.org/jira/browse/PARQUET-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556408#comment-17556408 ] ASF GitHub Bot commented on PARQUET-2069: - theosib-amazon commented on code in PR #957: URL:

[GitHub] [parquet-mr] theosib-amazon commented on a diff in pull request #957: PARQUET-2069: Allow list and array record types to be compatible.

theosib-amazon commented on code in PR #957: URL: https://github.com/apache/parquet-mr/pull/957#discussion_r901748898 ## parquet-avro/src/main/java/org/apache/parquet/avro/AvroReadSupport.java: ## @@ -136,10 +137,22 @@ public RecordMaterializer prepareForRead(

[jira] [Commented] (PARQUET-2069) Parquet file containing arrays, written by Parquet-MR, cannot be read again by Parquet-MR

[ https://issues.apache.org/jira/browse/PARQUET-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556406#comment-17556406 ] ASF GitHub Bot commented on PARQUET-2069: - theosib-amazon commented on code in PR #957: URL:

[GitHub] [parquet-mr] theosib-amazon commented on a diff in pull request #957: PARQUET-2069: Allow list and array record types to be compatible.

theosib-amazon commented on code in PR #957: URL: https://github.com/apache/parquet-mr/pull/957#discussion_r901740673 ## parquet-avro/src/test/java/org/apache/parquet/avro/TestArrayListCompatibility.java: ## @@ -0,0 +1,51 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (PARQUET-2069) Parquet file containing arrays, written by Parquet-MR, cannot be read again by Parquet-MR

[ https://issues.apache.org/jira/browse/PARQUET-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556405#comment-17556405 ] ASF GitHub Bot commented on PARQUET-2069: - theosib-amazon commented on code in PR #957: URL:

[GitHub] [parquet-mr] theosib-amazon commented on a diff in pull request #957: PARQUET-2069: Allow list and array record types to be compatible.

theosib-amazon commented on code in PR #957: URL: https://github.com/apache/parquet-mr/pull/957#discussion_r901733632 ## parquet-avro/src/main/java/org/apache/parquet/avro/AvroReadSupport.java: ## @@ -136,10 +137,22 @@ public RecordMaterializer prepareForRead(

[jira] [Commented] (PARQUET-2161) Row positions are computed incorrectly when range or offset metadata filter is used

[ https://issues.apache.org/jira/browse/PARQUET-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556329#comment-17556329 ] ASF GitHub Bot commented on PARQUET-2161: - ala opened a new pull request, #978: URL:

[GitHub] [parquet-mr] ala opened a new pull request, #978: PARQUET-2161: Fix row index generation in combination with range filtering

ala opened a new pull request, #978: URL: https://github.com/apache/parquet-mr/pull/978 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the

[jira] [Created] (PARQUET-2161) Row positions are computed incorrectly when range or offset metadata filter is used

Ala Luszczak created PARQUET-2161: - Summary: Row positions are computed incorrectly when range or offset metadata filter is used Key: PARQUET-2161 URL: https://issues.apache.org/jira/browse/PARQUET-2161