[GitHub] [parquet-mr] emkornfield commented on a diff in pull request #1000: PARQUET-2196: Support LZ4_RAW codec

emkornfield commented on code in PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#discussion_r984226908 ## parquet-hadoop/src/test/java/org/apache/parquet/hadoop/codec/TestInteropReadLz4RawCodec.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611370#comment-17611370 ] ASF GitHub Bot commented on PARQUET-2196: - emkornfield commented on code in PR #1000: URL:

[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611371#comment-17611371 ] ASF GitHub Bot commented on PARQUET-2196: - emkornfield commented on code in PR #1000: URL:

[GitHub] [parquet-mr] emkornfield commented on a diff in pull request #1000: PARQUET-2196: Support LZ4_RAW codec

emkornfield commented on code in PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#discussion_r984226661 ## parquet-hadoop/src/test/java/org/apache/parquet/hadoop/codec/TestInteropReadLz4RawCodec.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611367#comment-17611367 ] ASF GitHub Bot commented on PARQUET-2196: - emkornfield commented on code in PR #1000: URL:

[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611364#comment-17611364 ] ASF GitHub Bot commented on PARQUET-2196: - emkornfield commented on code in PR #1000: URL:

[GitHub] [parquet-mr] emkornfield commented on a diff in pull request #1000: PARQUET-2196: Support LZ4_RAW codec

emkornfield commented on code in PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#discussion_r984223726 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/codec/Lz4RawCodec.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611363#comment-17611363 ] ASF GitHub Bot commented on PARQUET-2196: - emkornfield commented on code in PR #1000: URL:

[GitHub] [parquet-mr] emkornfield commented on a diff in pull request #1000: PARQUET-2196: Support LZ4_RAW codec

emkornfield commented on code in PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#discussion_r984224486 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/codec/Lz4RawCompressor.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611362#comment-17611362 ] ASF GitHub Bot commented on PARQUET-2196: - emkornfield commented on code in PR #1000: URL:

[GitHub] [parquet-mr] emkornfield commented on a diff in pull request #1000: PARQUET-2196: Support LZ4_RAW codec

emkornfield commented on code in PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#discussion_r984223516 ## parquet-hadoop/pom.xml: ## @@ -102,6 +102,11 @@ jar compile + + io.airlift Review Comment: somebody more familiar with

[GitHub] [parquet-mr] emkornfield commented on a diff in pull request #1000: PARQUET-2196: Support LZ4_RAW codec

emkornfield commented on code in PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#discussion_r984223237 ## parquet-common/src/main/java/org/apache/parquet/hadoop/metadata/CompressionCodecName.java: ## @@ -30,7 +30,8 @@ public enum CompressionCodecName {

[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611361#comment-17611361 ] ASF GitHub Bot commented on PARQUET-2196: - emkornfield commented on code in PR #1000: URL:

[GitHub] [parquet-mr] emkornfield commented on a diff in pull request #1000: PARQUET-2196: Support LZ4_RAW codec

emkornfield commented on code in PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#discussion_r984222684 ## parquet-cli/src/main/java/org/apache/parquet/cli/Util.java: ## @@ -151,6 +151,8 @@ public static String shortCodec(CompressionCodecName codec) {

[GitHub] [parquet-mr] emkornfield commented on a diff in pull request #1000: PARQUET-2196: Support LZ4_RAW codec

emkornfield commented on code in PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#discussion_r984222684 ## parquet-cli/src/main/java/org/apache/parquet/cli/Util.java: ## @@ -151,6 +151,8 @@ public static String shortCodec(CompressionCodecName codec) {

[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611360#comment-17611360 ] ASF GitHub Bot commented on PARQUET-2196: - emkornfield commented on code in PR #1000: URL:

[jira] [Commented] (PARQUET-1222) Specify a well-defined sorting order for float and double types

[ https://issues.apache.org/jira/browse/PARQUET-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611356#comment-17611356 ] Micah Kornfield commented on PARQUET-1222: -- I'd propose the following "fix": - Add a new

[jira] [Commented] (PARQUET-758) [Format] HALF precision FLOAT Logical type

[ https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611355#comment-17611355 ] ASF GitHub Bot commented on PARQUET-758: emkornfield commented on PR #184: URL:

[GitHub] [parquet-format] emkornfield commented on pull request #184: PARQUET-758: Add Float16/Half-float logical type

emkornfield commented on PR #184: URL: https://github.com/apache/parquet-format/pull/184#issuecomment-1263116115 Sorry for the delay, it sounds like PARQUET-1222 is blocker, let me make a proposal there and see if we can at least come to consensus on approach and maybe this feature can be

[jira] [Commented] (PARQUET-758) [Format] HALF precision FLOAT Logical type

[ https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611266#comment-17611266 ] ASF GitHub Bot commented on PARQUET-758: anjakefala commented on PR #184: URL:

[GitHub] [parquet-format] anjakefala commented on pull request #184: PARQUET-758: Add Float16/Half-float logical type

anjakefala commented on PR #184: URL: https://github.com/apache/parquet-format/pull/184#issuecomment-1262879211 @pitrou @emkornfield @gszadovszky Is there anything I can do to move this addition forward? Can I help with any code? My understanding from reading the comments is

[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611094#comment-17611094 ] ASF GitHub Bot commented on PARQUET-2196: - wgtmac commented on PR #1000: URL:

[GitHub] [parquet-mr] wgtmac commented on pull request #1000: PARQUET-2196: Support LZ4_RAW codec

wgtmac commented on PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#issuecomment-1262462916 The interop test has been added. Please take a look again. Thanks! @shangxinli @pitrou -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [parquet-mr] ggershinsky commented on pull request #962: Performance optimization to ByteBitPackingValuesReader

ggershinsky commented on PR #962: URL: https://github.com/apache/parquet-mr/pull/962#issuecomment-1262142129 Optimizations like using byte arrays instead of byte buffers, and allocating the byte array once only, instead of per operation. Done in a concise manner, without unnecessary code

[jira] [Commented] (PARQUET-2193) Encrypting only one field in nested field prevents reading of other fields in nested field without keys

[ https://issues.apache.org/jira/browse/PARQUET-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610868#comment-17610868 ] Gidon Gershinsky commented on PARQUET-2193: --- Hmm, looks like this method runs over all

[jira] [Assigned] (PARQUET-2187) Add Parquet file containing a boolean column with RLE encoding to paquet

[ https://issues.apache.org/jira/browse/PARQUET-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antoine Pitrou reassigned PARQUET-2187: --- Assignee: Nishanth > Add Parquet file containing a boolean column with RLE

[jira] [Resolved] (PARQUET-2187) Add Parquet file containing a boolean column with RLE encoding to paquet

[ https://issues.apache.org/jira/browse/PARQUET-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antoine Pitrou resolved PARQUET-2187. - Resolution: Fixed > Add Parquet file containing a boolean column with RLE encoding to

[jira] [Commented] (PARQUET-2194) parquet.encryption.plaintext.footer parameter being true, code expects parquet.encryption.footer.key

[ https://issues.apache.org/jira/browse/PARQUET-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610855#comment-17610855 ] Gidon Gershinsky commented on PARQUET-2194: --- Footer key is required also in the plaintext