[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

2022-10-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616141#comment-17616141 ] ASF GitHub Bot commented on PARQUET-2196: - wgtmac commented on code in PR #1000: URL:

[GitHub] [parquet-mr] wgtmac commented on a diff in pull request #1000: PARQUET-2196: Support LZ4_RAW codec

2022-10-11 Thread GitBox
wgtmac commented on code in PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#discussion_r992923598 ## parquet-hadoop/pom.xml: ## @@ -102,6 +102,11 @@ jar compile + + io.airlift Review Comment: @shangxinli I have checked that

[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

2022-10-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616140#comment-17616140 ] ASF GitHub Bot commented on PARQUET-2196: - wgtmac commented on code in PR #1000: URL:

[GitHub] [parquet-mr] wgtmac commented on a diff in pull request #1000: PARQUET-2196: Support LZ4_RAW codec

2022-10-11 Thread GitBox
wgtmac commented on code in PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#discussion_r992924054 ## parquet-hadoop/pom.xml: ## @@ -102,6 +102,11 @@ jar compile + + io.airlift Review Comment: From the

[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

2022-10-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616139#comment-17616139 ] ASF GitHub Bot commented on PARQUET-2196: - wgtmac commented on code in PR #1000: URL:

[GitHub] [parquet-mr] wgtmac commented on a diff in pull request #1000: PARQUET-2196: Support LZ4_RAW codec

2022-10-11 Thread GitBox
wgtmac commented on code in PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#discussion_r992923598 ## parquet-hadoop/pom.xml: ## @@ -102,6 +102,11 @@ jar compile + + io.airlift Review Comment: @shangxinli I have checked that

[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

2022-10-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616136#comment-17616136 ] ASF GitHub Bot commented on PARQUET-2196: - wgtmac commented on code in PR #1000: URL:

[GitHub] [parquet-mr] wgtmac commented on a diff in pull request #1000: PARQUET-2196: Support LZ4_RAW codec

2022-10-11 Thread GitBox
wgtmac commented on code in PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#discussion_r992920886 ## parquet-hadoop/src/test/java/org/apache/parquet/hadoop/codec/TestInteropReadLz4RawCodec.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

2022-10-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616126#comment-17616126 ] ASF GitHub Bot commented on PARQUET-2196: - wgtmac commented on code in PR #1000: URL:

[GitHub] [parquet-mr] wgtmac commented on a diff in pull request #1000: PARQUET-2196: Support LZ4_RAW codec

2022-10-11 Thread GitBox
wgtmac commented on code in PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#discussion_r992915727 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/codec/Lz4RawCodec.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

2022-10-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616125#comment-17616125 ] ASF GitHub Bot commented on PARQUET-2196: - wgtmac commented on code in PR #1000: URL:

[GitHub] [parquet-mr] wgtmac commented on a diff in pull request #1000: PARQUET-2196: Support LZ4_RAW codec

2022-10-11 Thread GitBox
wgtmac commented on code in PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#discussion_r992915052 ## parquet-common/src/main/java/org/apache/parquet/hadoop/metadata/CompressionCodecName.java: ## @@ -30,7 +30,8 @@ public enum CompressionCodecName {

[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

2022-10-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616124#comment-17616124 ] ASF GitHub Bot commented on PARQUET-2196: - wgtmac commented on code in PR #1000: URL:

[GitHub] [parquet-mr] wgtmac commented on a diff in pull request #1000: PARQUET-2196: Support LZ4_RAW codec

2022-10-11 Thread GitBox
wgtmac commented on code in PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#discussion_r992914648 ## parquet-cli/src/main/java/org/apache/parquet/cli/Util.java: ## @@ -151,6 +151,8 @@ public static String shortCodec(CompressionCodecName codec) { return

[jira] [Commented] (PARQUET-2196) Support LZ4_RAW codec

2022-10-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616122#comment-17616122 ] ASF GitHub Bot commented on PARQUET-2196: - wgtmac commented on code in PR #1000: URL:

[GitHub] [parquet-mr] wgtmac commented on a diff in pull request #1000: PARQUET-2196: Support LZ4_RAW codec

2022-10-11 Thread GitBox
wgtmac commented on code in PR #1000: URL: https://github.com/apache/parquet-mr/pull/1000#discussion_r992914232 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/codec/Lz4RawDecompressor.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [parquet-mr] parthchandra commented on a diff in pull request #999: [DRAFT] PR to show Vectored IO integration, compilation fails now.

2022-10-11 Thread GitBox
parthchandra commented on code in PR #999: URL: https://github.com/apache/parquet-mr/pull/999#discussion_r992841047 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -1093,10 +1099,38 @@ private ColumnChunkPageReadStore

[GitHub] [parquet-mr] mukund-thakur commented on a diff in pull request #999: [DRAFT] PR to show Vectored IO integration, compilation fails now.

2022-10-11 Thread GitBox
mukund-thakur commented on code in PR #999: URL: https://github.com/apache/parquet-mr/pull/999#discussion_r992826565 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -1093,10 +1099,38 @@ private ColumnChunkPageReadStore

[GitHub] [parquet-mr] mukund-thakur commented on a diff in pull request #999: [DRAFT] PR to show Vectored IO integration, compilation fails now.

2022-10-11 Thread GitBox
mukund-thakur commented on code in PR #999: URL: https://github.com/apache/parquet-mr/pull/999#discussion_r992824827 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -1093,10 +1099,38 @@ private ColumnChunkPageReadStore

[GitHub] [parquet-mr] parthchandra commented on a diff in pull request #999: [DRAFT] PR to show Vectored IO integration, compilation fails now.

2022-10-11 Thread GitBox
parthchandra commented on code in PR #999: URL: https://github.com/apache/parquet-mr/pull/999#discussion_r992787569 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -1093,10 +1099,38 @@ private ColumnChunkPageReadStore

[GitHub] [parquet-mr] mukund-thakur commented on a diff in pull request #999: [DRAFT] PR to show Vectored IO integration, compilation fails now.

2022-10-11 Thread GitBox
mukund-thakur commented on code in PR #999: URL: https://github.com/apache/parquet-mr/pull/999#discussion_r992678347 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -1093,10 +1099,38 @@ private ColumnChunkPageReadStore

[GitHub] [parquet-mr] mukund-thakur commented on a diff in pull request #999: [DRAFT] PR to show Vectored IO integration, compilation fails now.

2022-10-11 Thread GitBox
mukund-thakur commented on code in PR #999: URL: https://github.com/apache/parquet-mr/pull/999#discussion_r992678347 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -1093,10 +1099,38 @@ private ColumnChunkPageReadStore

[GitHub] [parquet-mr] mukund-thakur commented on a diff in pull request #999: [DRAFT] PR to show Vectored IO integration, compilation fails now.

2022-10-11 Thread GitBox
mukund-thakur commented on code in PR #999: URL: https://github.com/apache/parquet-mr/pull/999#discussion_r992670321 ## parquet-common/src/main/java/org/apache/parquet/io/SeekableInputStream.java: ## @@ -23,6 +23,10 @@ import java.io.IOException; import java.io.InputStream;

Re: Vectored IO in Parquet ( https://issues.apache.org/jira/browse/PARQUET-2171)

2022-10-11 Thread Mukund Madhav Thakur
++ Adding Xinli and Gidon. We discussed this during the Apache Con NA. I will be putting the slide deck slideshare after making some changes soon. On Tue, Sep 27, 2022 at 11:29 AM Mukund Madhav Thakur wrote: > Hi Team, > We in hadoop project recently added a new feature in Hadoop Vectored IO >

[jira] [Commented] (PARQUET-2195) Add scan command to parquet-cli

2022-10-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615893#comment-17615893 ] ASF GitHub Bot commented on PARQUET-2195: - wgtmac commented on code in PR #998: URL:

[GitHub] [parquet-mr] wgtmac commented on a diff in pull request #998: PARQUET-2195: Add scan command to parquet-cli

2022-10-11 Thread GitBox
wgtmac commented on code in PR #998: URL: https://github.com/apache/parquet-mr/pull/998#discussion_r992446760 ## parquet-cli/src/main/java/org/apache/parquet/cli/commands/ScanCommand.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[jira] [Commented] (PARQUET-2195) Add scan command to parquet-cli

2022-10-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615889#comment-17615889 ] ASF GitHub Bot commented on PARQUET-2195: - wgtmac commented on code in PR #998: URL:

[GitHub] [parquet-mr] wgtmac commented on a diff in pull request #998: PARQUET-2195: Add scan command to parquet-cli

2022-10-11 Thread GitBox
wgtmac commented on code in PR #998: URL: https://github.com/apache/parquet-mr/pull/998#discussion_r992437914 ## parquet-cli/src/main/java/org/apache/parquet/cli/commands/ScanCommand.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[jira] [Commented] (PARQUET-2195) Add scan command to parquet-cli

2022-10-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615885#comment-17615885 ] ASF GitHub Bot commented on PARQUET-2195: - wgtmac commented on code in PR #998: URL:

[GitHub] [parquet-mr] wgtmac commented on a diff in pull request #998: PARQUET-2195: Add scan command to parquet-cli

2022-10-11 Thread GitBox
wgtmac commented on code in PR #998: URL: https://github.com/apache/parquet-mr/pull/998#discussion_r992436297 ## parquet-cli/src/main/java/org/apache/parquet/cli/commands/ScanCommand.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[jira] [Commented] (PARQUET-2195) Add scan command to parquet-cli

2022-10-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615881#comment-17615881 ] ASF GitHub Bot commented on PARQUET-2195: - wgtmac commented on code in PR #998: URL:

[GitHub] [parquet-mr] wgtmac commented on a diff in pull request #998: PARQUET-2195: Add scan command to parquet-cli

2022-10-11 Thread GitBox
wgtmac commented on code in PR #998: URL: https://github.com/apache/parquet-mr/pull/998#discussion_r992431971 ## parquet-cli/src/main/java/org/apache/parquet/cli/commands/ScanCommand.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +